Re: [Audacity-devel] Inverse RIAA patch for EQ

[Gale A. <ga...@au...>]

| From Martyn Shaw <mar...@go...> 
| Wed, 30 Dec 2009 02:08:34 +0000
| Subject: [Audacity-devel] Inverse RIAA patch for EQ
> I just put this in under EXPERIMENTAL_EQ_INVERT in Experimental.h.  It 
> is more complete now and I welcome comments.
> 
> TTFN
> Martyn


Martyn, I had this more complete version in my "nightly" builds for most 
of January and it worked well in both Draw Curves and Graphic mode
(the earlier version did not cause "select curve" to change to custom
when you inverted, but this does). 

Three users commented, two of whom said they would still prefer an
actual built-in "Inverse RIAA" curve as well as the "Invert" button.
Users may be looking for the curve in the list, rather than a function 
to invert curves that are already there, plus it avoids the need to save 
the inverted curve if they want to use it a lot. I tend to agree because
people may quite often be recording 78s through modern decks, but 
don't feel very strongly.

Maybe it would help to make the button read "Inverted" instead of 
"Invert"? Then it matches with "Flat" (both are then adjectives
describing the properties of the curve, rather than one being an 
adjective and one a verb).  

Anyway, can we commit this please with or without my suggestions? 



Thanks


Gale 





> Martyn Shaw wrote:
> > Hi Gale
> > 
> > Your patch is an option but not a very general one, so I'm not inclined 
> > to support it.
> > 
> > Better is a button to invert any curve (as I think I said before) and 
> > here is my first patch for that.  Incomplete in many ways.  It only 
> > really works in 'Draw Curves' mode, not 'Graphic EQ'.  But it does 
> > invert a curve.
> > 
> > I could remove the button from 'Graphic EQ' or make it adjust the 
> > sliders in 'Graphic EQ', I guess.  Just removing the button would 
> > probably be easier.  YMMV.
> > 
> > TTFN
> > Martyn
> > 
> > Gale Andrews wrote:
> >> | From Martyn Shaw <mar...@go...> | Mon, 30 Nov 2009 
> >> 00:52:27 +0000
> >> | Subject: [Audacity-devel] code and translation freeze for Audacity 
> >> 1.3.10 beta
> >>> Gale (Audacity Team) wrote:
> >>>
> >>>> ... except it has an Inverse
> >>>> RIAA addition to Equalization in at the moment that users have been 
> >>>> asking
> >>>> for. 
> >>> Please send that, post-release, so I can take a look.
> >>
> >> Attached, thanks. It will be listed on:
> >> http://wiki.audacityteam.org/index.php?title=Patches
> >>
> >>
> >>
> >>
> >> Gale
> >>
> >> ------------------------------------------------------------------------
> >>
> >> ------------------------------------------------------------------------------ 
> >>
> >> Join us December 9, 2009 for the Red Hat Virtual Experience,
> >> a free event focused on virtualization and cloud computing. Attend 
> >> in-depth sessions from your desk. Your couch. Anywhere.
> >> http://p.sf.net/sfu/redhat-sfdev2dev
> >>
> >>
> >> ------------------------------------------------------------------------
> >>
> >> _______________________________________________
> >> audacity-devel mailing list
> >> aud...@li...
> >> https://lists.sourceforge.net/lists/listinfo/audacity-devel
> 
> ------------------------------------------------------------------------------
> This SF.Net email is sponsored by the Verizon Developer Community
> Take advantage of Verizon's best-in-class app development support
> A streamlined, 14 day to market process makes app distribution fast and easy
> Join now and get one step closer to millions of Verizon customers
> http://p.sf.net/sfu/verizon-dev2dev 
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel