[Audacity-devel] Patch for fixes, and RE: Mod Script Pipe problem with stopping playback

[Marty G. <jmg...@sy...>]

Hi James,

Thanks.  I agree that the aforementioned Menus.cpp change isn't really a solution.  In fact, I spoke too soon, because while it seemed to work for my NamedPipe test program, it doesn't actually work for SayPlay.  So, I consider it merely an experiment in WxWidgets event handling... where I must yet discover a solution.

Enclosed is a patch file for the correct SetProjectInfoCommand default type, for the SetTrackInfo missing lines, and ScripterCallback.h version number to match.


An aside, I kept running into this assert during playback:  (Envelope.cpp, line 1085):

// JC: If bufferLen ==0 we have probably just allocated a zero sized buffer.
//   wxASSERT( bufferLen > 0 );

It was a bufferLen of zero each time it was encountered (i.e. never a negative number).  
I had to change it to assert that bufferLen was greater or equal to 0.  Attempting to allocate a zero length buffer doesn't seem to be a problem, at least functionally.    Is this a concern? (I haven't noticed any discussions).

Best Regards,
Marty
________________________________________
From: James Crook [cr...@in...]
Sent: Wednesday, February 17, 2010 4:16 PM
To: aud...@li...
Cc: Marty Goddard
Subject: Re: [Audacity-devel] Mod Script Pipe problem with stopping playback

Marty,

Sorry for not yet having replied to your message of the 12th.

Certainly would like a patch for the 'lines not yet checked in'.

I don't like the solution to the play-stop issue since (as long as we
continue to use the convention of greyed out menu items) your solution
does not do the greying out correctly.

--James.


On 16/02/2010 14:12, Marty Goddard wrote:
> Hello,
>
> Regarding the version number mismatch in the module, and the problem in SetProjectInfo.cpp and missing lines from SetTrackInfo.cpp, should I have submitted a patch for these fixes?
>
> Further to the problem in stopping playback over the named pipe, I discovered that a simple change to the default settings for the Stop menu command gives the correct performance without any apparent drawback except an obvious cosmetic problem:  The Stop menu is disabled during playback.  This does not prevent the stop command from being available via the spacebar or the scripting interface.
>
> I changed the following line in Menus.cpp (line 594)
>
> c->AddItem(wxT("Stop"), _("&Stop"), FN(OnStop) ); //  Menus.cpp line 594, was
> c->AddItem(wxT("Stop"), _("&Stop"), FN(OnStop), AudioIOBusyFlag, AudioIOBusyFlag);
>
>
> I believe that by removing the dependence on , AudioIOBusyFlag, the command reverts to the default dependency upon AudioIONotBusyFlag, from:
>
>     c->SetDefaultFlags(AudioIONotBusyFlag, AudioIONotBusyFlag);  // Menus.cpp line 587
>
> Given that it works for me, I'll keep the above until I can figure out how make the Stop command always available (It shouldn't cause a problem if it's enabled when no playback is happening, right?)
>
> Best Regards,
> Marty
>
>
> ----------------------------------------------------------------------
> On Date: Fri, 12 Feb 2010 14:18:38 +0000
> Marty Goddard<jmg...@sy...>
> wrote:
>
>
>> Content-Type: text/plain; charset="us-ascii"
>>
>
>> Hi James, Dan, Everyone:
>>
>
>> Summary: 1. Bug in SetProjectInfo, 2. Mod-Script-Pipe module version string outdated,  3. Checkin
>> problem, 4. Play/Stop toggle problem from remote scripting.  5. Stacking clips 2-cents. 6. Finding interested
>> "SayPlay" users.
>>
>
>> 1. I found a bug in the Mod-Script Pipe code that I added, where the default command for
>> SetProjectInfo.cpp, line 39, was still set to "Name" after having removed that command option.  It needs the
>> default to be "SelectedTracks" instead of "Name".
>>
>
>> 2. Also, several lines of code in SetTrackInfo.cpp that I thought I had checked in didn't appear.  It's
>> possible that I failed to check them in at all.  Argh.
>>
>
>> 3. The version string for the Mod-Script-Pipe module wasn't updated to 1.3.12, from 1.3.10, so the module
>> wouldn't load.  This is in ScripterCallback.h, line 45 (#define SCRIPT_PIPE_REVISION  12).
>>
>
>> 4. There is a mysterious Play-Stop toggle problem, which has something to do with which window is
>> topmost and active.  I believe it is one that Dan H. mentioned.  I need to go after this one because it's a
>> show-stopper  for me.  I'll send more detailed info asking for insights in another message.
>>
> ----------------------------------------------------------------------
> ------------------------------------------------------------------------------
> SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
> Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
> http://p.sf.net/sfu/solaris-dev2dev
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
>
>