[Audacity-devel] Mod Script Pipe problem with stopping playback

[Marty G. <jmg...@sy...>]

Hello,

Regarding the version number mismatch in the module, and the problem in SetProjectInfo.cpp and missing lines from SetTrackInfo.cpp, should I have submitted a patch for these fixes?

Further to the problem in stopping playback over the named pipe, I discovered that a simple change to the default settings for the Stop menu command gives the correct performance without any apparent drawback except an obvious cosmetic problem:  The Stop menu is disabled during playback.  This does not prevent the stop command from being available via the spacebar or the scripting interface.

I changed the following line in Menus.cpp (line 594)

c->AddItem(wxT("Stop"), _("&Stop"), FN(OnStop) ); //  Menus.cpp line 594, was
c->AddItem(wxT("Stop"), _("&Stop"), FN(OnStop), AudioIOBusyFlag, AudioIOBusyFlag);  


I believe that by removing the dependence on , AudioIOBusyFlag, the command reverts to the default dependency upon AudioIONotBusyFlag, from:

   c->SetDefaultFlags(AudioIONotBusyFlag, AudioIONotBusyFlag);  // Menus.cpp line 587

Given that it works for me, I'll keep the above until I can figure out how make the Stop command always available (It shouldn't cause a problem if it's enabled when no playback is happening, right?)

Best Regards,
Marty


----------------------------------------------------------------------
On Date: Fri, 12 Feb 2010 14:18:38 +0000
Marty Goddard <jmg...@sy...>
wrote:

> Content-Type: text/plain; charset="us-ascii"

> Hi James, Dan, Everyone:

> Summary: 1. Bug in SetProjectInfo, 2. Mod-Script-Pipe module version string outdated,  3. Checkin 
> problem, 4. Play/Stop toggle problem from remote scripting.  5. Stacking clips 2-cents. 6. Finding interested 
> "SayPlay" users.

> 1. I found a bug in the Mod-Script Pipe code that I added, where the default command for 
> SetProjectInfo.cpp, line 39, was still set to "Name" after having removed that command option.  It needs the 
> default to be "SelectedTracks" instead of "Name".

> 2. Also, several lines of code in SetTrackInfo.cpp that I thought I had checked in didn't appear.  It's 
> possible that I failed to check them in at all.  Argh.

> 3. The version string for the Mod-Script-Pipe module wasn't updated to 1.3.12, from 1.3.10, so the module 
> wouldn't load.  This is in ScripterCallback.h, line 45 (#define SCRIPT_PIPE_REVISION  12).

> 4. There is a mysterious Play-Stop toggle problem, which has something to do with which window is 
> topmost and active.  I believe it is one that Dan H. mentioned.  I need to go after this one because it's a 
> show-stopper  for me.  I'll send more detailed info asking for insights in another message.
----------------------------------------------------------------------