Re: [Audacity-devel] Snap-To needs attention
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Ed M. <edg...@wa...> - 2010-02-14 16:45:17
|
This also affects on-the-fly translation because we do the same (create a new TTC) to get the current (might just have changed if the user changed languages) string for a displayed object. This happens at least as often as every OnDraw() (very often) if we want on-the-fly translation. A while back we batted around some ideas in a translation bug thread. --Ed > -----Original Message----- > From: James Crook [mailto:cr...@in...] > Sent: Sunday, February 14, 2010 7:56 AM > To: aud...@li...; Al Dimond > Subject: [Audacity-devel] Snap-To needs attention > > Al, > > You recently fixed snap-to behaviour, which is very welcome. > > However some details of current snap-to implementation aren't so good. > TimeTextCtrls were being created and deleted at a great rate when dragging with snap-to > on. This caused a window to appear in the toolbar when dragging. There is possibly also > a lot of access to gPrefs which we normally try to avoid in anything that happens > repeatedly since, at least in principle, it could be doing file access. > > I applied a band-aid which was to extract a TimeConverter class from TimeTextCtrl so > that we don't need an actual window. It removes the flicker from the extra window > appearing when dragging, but that still happens on a mouse down because SnapManager > creates one. I also see that GridMove() creates a TimeTextCtrl too. That could be fixed in > the same way. > > I'm wondering though, is there a reason not to have a TimeConverter permanently in > Project that we just re-use? Or even use the selection toolbar itself for conversion? I > don't know the answer, so I think some design discussion here would help. You know > this class better than me. > The changes I made were just to split the class so that we did not have to have a control > associated with it. > > Can we discuss what should happen to snap-to here? I can do either way of fixing the > mouse-down flicker, but am not sure which one to do. > > Thanks, > > > --James. > > > > ---------------------------------------------------------------------------- -- > SOLARIS 10 is the OS for Data Centers - provides features such as DTrace, Predictive > Self Healing and Award Winning ZFS. Get Solaris 10 NOW http://p.sf.net/sfu/solaris- > dev2dev > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel |