Re: [Audacity-devel] Code Reviews

[Michael C. <mc...@gm...>]

Hi James, I'll be looking at on tuesday.  I've poked around a bit and
found some apparently thread/performance safe but dumb code with
ODComputeSummary tasks where the last one doesn't get deleted until
the next one is.

Best,
Michael

On 2/1/10, James Crook <cr...@in...> wrote:
> Three code reviews done so far:
>
> http://wiki.audacityteam.org/wiki/Code_Review_Triage
>
> Michael could you have a look at the most recent one on WaveClip?
> Particularly these two comments - I'd like a second opinion by someone
> who knows the code.  Are these two bugs?
>
> 695 was oldCache freed on this path?
>
> 1242 OK.  So we now have resampledClip.  However it is now not
> mentioned again until it is deleted, so was setting it up
> completely pointless?  If it wasn't there needs to be comment
> explaining why.
>
> Could we safely delete it right here?
>
>
> Thanks,
>
>
> --James.
>
>