Re: [Audacity-devel] [patch] slider tooltip language localization

[Richard A. <ri...@au...>]

On Tue, 2009-12-29 at 19:17 -0800, Ed Musgrove wrote:
> Patch attached
> P3 bug changing language in Preferences , some elements don't change... The
> problems listed under this bug are due to multiple different issues. 
> 
> Much more complicated because it affects all sliders with tooltip value
> display. In all cases it was a question of caching a translated string for
> future use; the string becomes "stale" when the language is changed.

Do I take it that what you have done here is to modify the Aslider class
so that instead of mStyle being the type of slider, but the caller
getting to choose what the label (mName) is (so many sliders of the same
mStyle can have different labels), you now force a given mStyle to have
a fixed label, and if we want a new label, we have to create another
possible value for mStyle (which should be an enumerated type but wasn't
before either)?

If so, I don't like this patch, because you have converted an easy to
use interface (choose the type of slider and name separately) into a
hard to use one (where the two independent choices are entangled) which
is also not scalable (what if I decided the mixer board should have the
user-specified track name in the tool-tip to make the board easier to
use?).

Wouldn't it be much less invasive to store an untranslated string and
then force a translation of it when required with wxGetTranslation() - 
http://docs.wxwidgets.org/stable/wx_stringfunctions.html#wxgettranslation

Whilst some mechanism is needed to ensure that anything that might get
pushed into that is in fact extracted for translation by the xgettext
process, this needn't be that taxing (hint - macros or overloading are
probably the answer, remember that xgettext works on the un-preprocessed
sources).

This is likely to be much more maintainable and stable than the solution
involving changing all the mStyle values and their names.

Richard