Re: [Audacity-devel] Crash with Sound Activated Recording

[Al D. <bus...@gm...>]

On Wednesday 09 December 2009 11:32:14 Michael Schwendt wrote:
> On Fri, 4 Dec 2009 15:05:03 +0100, me wrote:
> > Audacity 1.3.9-beta
> >
> > There's a race-condition in AudioIO::StartStream() and
> > AudioIO::SetMeters(), which affects audacityAudioCallback() and
> > leads to a crash when enabling "Sound Activated Recording".
> >
> > At the start of a recording, the callback may run into
> > mInputMeter still being NULL, which causes it to crash when
> > trying to call the input meter's GetMaxPeak() method.
> >
> > http://bugzilla.redhat.com/544125
> 
> ACK or NACK, anyone?
> 

I haven't got it to repro, but it looks very plausible. I have 

if(gAudioIO->mPauseRec && inputBuffer) {

on AudioIO.cpp:3006, and I'll just add a test for
gAudioIO->mInputBuffer. It compiles and runs just the same for me, and 
should get rid of the race. Is that basically what your workaround is 
also?

More generally, after 2.0 perhaps we should look at whether it's a 
good idea for AudioIO to be global; if so I think we ought to keep 
track of all projects, their meters, etc, instead of just having one 
current.

 - Al

> -------------------------------------------------------------------
> ----------- Return on Information:
> Google Enterprise Search pays you back
> Get the facts.
> http://p.sf.net/sfu/google-dev2dev
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>