Re: [Audacity-devel] audacity 1.3.10 FTBFS on Debian hurd-i386

[Al D. <bus...@gm...>]

On Friday 04 December 2009 17:47:03 Benjamin Drung wrote:
> Hi,
> 
> audacity 1.3.10 failed to build from source (FTBFS) on Debian
>  hurd-i386 architecture. Here is the failing part:
> 
> cc -DPACKAGE_NAME=\"libnyquist\" -DPACKAGE_TARNAME=\"libnyquist\"
> -DPACKAGE_VERSION=\"0.1\" -DPACKAGE_STRING=\"libnyquist\ 0.1\"
> -DPACKAGE_BUGREPORT=\"\" -DPACKAGE=\"libnyquist\" -DVERSION=\"0.1\"
> -DINSTALL_PREFIX=\"/usr\" -DHAVE_STRCHR=1 -DHAVE_MEMMOVE=1
> -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1
> -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1
>  -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1
>  -DHAVE_UNISTD_H=1
> -DHAVE_STDLIB_H=1 -DHAVE_MALLOC=1 -DHAVE_STDBOOL_H=1
>  -DSTDC_HEADERS=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -I.   -Wall
>  -I. -Inyquist/nyqsrc -Inyquist/tran -Inyquist/xlisp
>  -Inyquist/sys/unix -Inyquist/cmt -Inyquist/ffts/src
>  -Inyquist/nyqstk/include -Inyquist/nyqstk
>  -I../portaudio-v19/include -I../libsndfile/src -DCMTSTUFF -DEXT -g
>  -O2 -g -Wall -O2 -Wstrict-prototypes  -Wall -c -o midifns.o `test
>  -f 'nyquist/cmt/midifns.c' || echo './'`nyquist/cmt/midifns.c In
>  file included from nyquist/cmt/midifns.c:75:
> nyquist/cmt/midifns.h:109: warning: function declaration isn't a
>  prototype In file included from nyquist/cmt/midifns.c:76:
> nyquist/cmt/userio.h:73: warning: function declaration isn't a
>  prototype nyquist/cmt/midifns.c:333: warning: function declaration
>  isn't a prototype nyquist/cmt/midifns.c:334: warning: function
>  declaration isn't a prototype nyquist/cmt/midifns.c:335: warning:
>  function declaration isn't a prototype nyquist/cmt/midifns.c:336:
>  warning: function declaration isn't a prototype
>  nyquist/cmt/midifns.c: In function 'eventwait':
> nyquist/cmt/midifns.c:434: error: 'NOFILE' undeclared (first use in
>  this function) nyquist/cmt/midifns.c:434: error: (Each undeclared
>  identifier is reported only once nyquist/cmt/midifns.c:434: error:
>  for each function it appears in.) nyquist/cmt/midifns.c: At top
>  level:

Here on Linux there's a note in <sys/param.h> that NOFILE is obsolete 
and its value is incorrect. So I guess HURD just leaves it out?

I see two possible solutions: change NOFILE references to 
getdtablesize() from <unistd.h> or make up a fake value for NOFILE (on 
my machine it's 256). I can't find any hard evidence of this in 
libnyquist's CVS tree but I suspect they might have done just this 
with OPEN_MAX (defined at midifns.c:29 and then never used) at some 
point before their CVS history started and then changed OPEN_MAX 
references to NOFILE without changing the definition.

Changing NOFILE references to getdtablesize() works on my Linux 
system, as does changing the stuff around line 29 so it defines NOFILE 
instead of OPEN_MAX. Do these also solve the compile problem on HURD?

 - Al

> nyquist/cmt/midifns.c:525: warning: function declaration isn't a
>  prototype nyquist/cmt/midifns.c:1482: warning: function
>  declaration isn't a prototype nyquist/cmt/midifns.c:1595: warning:
>  function declaration isn't a prototype nyquist/cmt/midifns.c:1771:
>  warning: function declaration isn't a prototype make[3]: ***
>  [midifns.o] Error 1
> make[3]: Leaving directory
>  `/build/buildd/audacity-1.3.10/lib-src/libnyquist' make[2]: ***
>  [libnyquist-recursive] Error 2
> make[2]: Leaving directory `/build/buildd/audacity-1.3.10/lib-src'
> make[1]: *** [audacity] Error 2
> make[1]: Leaving directory `/build/buildd/audacity-1.3.10'
> make: *** [debian/stamp-makefile-build] Error 2
> 
> The full log can be found here:
>  https://buildd.debian.org/fetch.cgi?pkg=audacity;ver=1.3.10-1;arch
> =hurd-i386;stamp=1259844285
>