Re: [Audacity-devel] release.txt (win only)
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Martyn S. <mar...@go...> - 2009-11-29 21:55:11
|
Vaughan Johnson wrote: > Martyn Shaw wrote: >> Hi Vaughan > Hi, Martyn. > >> Vaughan Johnson wrote: >>> Martyn Shaw wrote: >>>> Hi >>>> >>>> Do we still need step 3e in release.txt about pre-sp1 runtimes? I >>>> will have a job testing that, since I probably have VC9 on the the >>>> machines that I have available. >>> Visual Studio 2008 uses VC9, so I think you do have it. (Microsoft >>> numbering, go figure.) >> Yes I have VC9. I meant that I would have a job finding a machine >> without it so that I could test if it broke when that wasn't present >> (I assume that was the problem). I did try another machine without VS >> and the rc1 worked, but no guarantee that it will elsewhere. > Thanks, sorry I didn't recall that having VC9 could block the problem. > > But we're including the VC9 runtimes (msvcp90.dll and msvcr90.dll) from > the Visual Studio folder (C:\Program Files\Microsoft Visual Studio > 9.0\VC\redist\x86\Microsoft.VC90.CRT) now in the Audacity installer > scripts to put in the Audacity executable folder, so it needs to refer > to those, and I think they're still marked as the pre-sp1 versions, so I > think you should do it per the release.txt instructions. > > Did you have some news it changed? Ee are still at MSVC9sp1, so the > instructions are still right. > > >>>> I suspect we don't, since it refers to 1.3.8 release and I don't >>>> remember the problem with 1.3.9 (but I don't remember many other >>>> things either!). >>> I think we do. The latest patch is sp1 and that's what introduced the >>> problem. Check >>> C:\Program Files\Microsoft Visual Studio >>> 9.0\VC\redist\x86\Microsoft.VC90.CRT and see which runtimes it refers >>> to. I'm still building with the hacked (fixed) version. >> The manifest there refers to version="9.0.30729.1", which is the >> version of the 3 redistributables there also. > That's the sp1 set, so I'd be surprised if it works on machines without > VC9. I think I can find a machine that far behind, so please post the > link of your build again and I'll test it. http://dl.dropbox.com/u/1327769/audacity-win-unicode-1.3.10-rc1.exe I will post an rc2 later, with better help and the fixed manifest. > >> ... >>> I haven't looked at that file in a while, but I think some errors have >>> crept in: >>> >>> 1. I think 2c is incorrect. "Release" build is vs "Unicode_Release", >>> or "Debug" or "Unicode_Debug", and means it optimizes and doesn't >>> include debug info. It's not relevant to whether you're building >>> an Audacity beta or not. Our beta releases are built with Release >>> and Unicode_Release. Anyway, shouldn't the correct setting just be >>> maintained in Audacity.h in CVS (so 2c should just be removed)? >> I think it should say "non-Beta" rather than "Release" (avoiding the >> 'S' word here!). Similarly the 2. heading. Have changed accordingly. >> Feel free to revert (as ever!). > Stable, stable, stable! I'm so profane, using *standard* terminology. Be > very afraid. > > Anyway, this won't be read by the scaredy-cats Gale is trying to seduce, > so just use "stable". That's what it is. Will do later. > >> (Perhaps worthy of note here, IS_BETA is used very little but will >> cause the 'About' box text to change from "This is a Beta version of >> the program. It may contain bugs and unfinished features..." to "This >> is a stable, completed release of the program..." and the 'Run >> Benchmark...' menu item to disappear.) > Thanks, but especially if that IS_BETA flag is extended to other > behaviors, it should be in HEAD, so unnecessary to talk about in > release.txt, and dependent on whether we're working toward beta or stable. I think a reminder here to check it is useful, and harmless so I'll leave it in. > Stable, stable. Good word. > > :-) > > >>> 2. Also, at the top, it says "Release (for Windows 98/ME) and >>> Unicode_Release (for 2000/XP/Vista). These instructions apply for >>> either one, but example values are for Unicode_Release. " Some >>> later additions refer to Release instead. >> I can't see here you mean, perhaps it was the 2. title? No biggy. > No, it was the further instructions where everywhere else uses > Unicode_Release as examples for both Unicode_Release and Release. Some > cases have crept in where it refers to "Release". > >>> 3. For 2e, doesn't that need to be msgfmt.exe, not msgfmt.zip? >> You are probably correct, although I can't currently locate either of >> these on my machine, yet locale builds correctly! Must be my >> searching or something. I don't understand my machine always :-(. > On my machine, it's msgfmt.exe in C:\windows, which is in my PATH. I've found it there as well now, I think the search thingy wasn't looking there for some reason! TTFN Martyn >>> 4. 3b is unnecessary. The installer scripts pick up those files from >>> their location in the CVS hierarchy. (And I've always made the zip >>> by running the installer, removing the unins.* then zipping it (as >>> in step 5), so those files make it in there, too.) >> That works here. Have updated file accordingly. > Thanks. Wonder how that got in there anyway, when it was working without it. ;-) > >>> 5. I think 3d is fully automated now, so we can remove or update it. >> That doesn't appear to be true. I followed the instructions without >> it and get no wxstd.mo files in each directory in Languages. I also >> see no automation in place. Have left that bit in (now 3c). > Leland? Please confirm. > >>> 6. Whoever updates this file, please add yourself to the authors >>> list. In 3d, e.g., it says "or I can't make it" and that wasn't I. >> That was me, sorry. Have added my name at the top and a sig on the >> comment. > > ;-) > > >>> I didn't fix any of those, pending discussion/confirmation. >> I did some, since we are 2 devs, and so 'allowed' at this time ;-). > > Thanks! ;-) > > - V > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day > trial. Simplify your report design, integration and deployment - and focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > |