Re: [Audacity-devel] Cancel Edit metadata
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Ed M. <edg...@wa...> - 2009-11-13 20:39:01
|
Markus, David and I all seem to agree that adding a "Cancel" button is not good/right. Currently: *The "OK" button is the same as a "Continue" button. *The "Cancel" button in the metadata editor cancels the Save As... completely -- closing the Save As dialog. Clicking the "Close Window" gadget is exactly the same as clicking the "Cancel" button. 1) It would seem that some people want the Cancel button in the metadata editor to close the metadata editor dialog but reopened the Save As dialog. 2) It seems that some people are confused about clicking the OK button with no data in the metadata fields to continue saving with no metadata, just the audio. I do not have a strong opinion on the first item. I lean toward leaving it the way it is now -- any time you click cancel during a chain of actions it cancels the entire action set. I do understand that there is benefit from being able to cancel one portion of the set and step backward through the chain. It might be counterintuitive, and I'm not necessarily suggesting this, but if clicking the Cancel button did not close the Save As dialog (i.e. step backward through the chain) then we might set the Close Window button to perform in a different mode -- it would end the chain -- closing the metadata and the Save As dialogs. I have a moderately strong opinion on the second item. I would not add an extra button. I would lean toward adding a little bit of text to the dialog reminding the user that it is all right to click "OK" even though there is no data in fields. Alternately, changing the name of the OK button to "Continue" might improve user comfort. --Ed > -----Original Message----- > From: Markus Meyer [mailto:me...@me...] > Sent: Friday, November 13, 2009 1:12 AM > To: aud...@li... > Cc: Mar...@go... > Subject: Re: [Audacity-devel] Cancel Edit metadata > > Ed Musgrove schrieb: > > This is pretty easy to do, but probably unnecessary. As it turns out, > > you may click the OK button with no data entered. > > > > The attached patch contains code which adds the button. When the > > button is clicked it simply calls the OK function. I had to create a > > new string --_("Continue"); I do not know how language localization > > works but this might break "string freeze". Another method of > > resolving this would be to add a little bit of text to the dialog > > explaining that it was acceptable to click the OK button when all the > > metadata fields were empty; this would certainly break the "string freeze". >> >>I would not recommend committing this patch without major consensus. >> >>--Ed > > > Ed, > > thanks for the patch. However, I consider it bad design to have two buttons > which do the same thing. Clicking OK with no data entered is the natural thing > and is already quite straight-forward UI-wise. > > > Markus > -----Original Message----- > From: David Bailes [mailto:drb...@go...] > On Fri, Nov 13, 2009 at 9:12 AM, Markus Meyer <me...@me...> wrote: > > Ed Musgrove schrieb: > > > > thanks for the patch. However, I consider it bad design to have two > > buttons which do the same thing. Clicking OK with no data entered is > > the natural thing and is already quite straight-forward UI-wise. > > I agree that a continue button would not be helpful or good design. I think > that the only question is whether the cancel button should cancel the export > as well as any edits the user has made to the metadata. If the user presses > the save button in the export file dialog, makes some edits in the metadata > dialog, and then presses cancel, do they expect the file to be saved. Maybe > it's just not easier to get the right behaviour with a series of two dialogs. > > David. |