Re: [Audacity-devel] Cancel Edit metadata

[David B. <drb...@go...>]

On Fri, Nov 13, 2009 at 9:12 AM, Markus Meyer <me...@me...> wrote:
> Ed Musgrove schrieb:
>> This is pretty easy to do, but probably unnecessary. As it turns out, you
>> may click the OK button with no data entered.
>>
>> The attached patch contains code which adds the button. When the button is
>> clicked it simply calls the OK function. I had to create a new string
>> --_("Continue"); I do not know how language localization works but this
>> might break "string freeze". Another method of resolving this would be to
>> add a little bit of text to the dialog explaining that it was acceptable to
>> click the OK button when all the metadata fields were empty; this would
>> certainly break the "string freeze".
>>
> Ed,
>
> thanks for the patch. However, I consider it bad design to have two
> buttons which do the same thing. Clicking OK with no data entered is the
> natural thing and is already quite straight-forward UI-wise.

I agree that a continue button would not be helpful or good design. I
think that the only question is whether the cancel button should
cancel the export as well as any edits the user has made to the
metadata. If the user presses the save button in the export file
dialog, makes some edits in the metadata dialog, and then presses
cancel, do they expect the file to be saved. Maybe it's just not
easier to get the right behaviour with a series of two dialogs.

David.