Re: [Audacity-devel] irritating bug in Keyboard Preferences when seeking to the next command by hit
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Ed M. <edg...@wa...> - 2009-10-17 23:55:47
|
Hi Bill! One thing I need to know, is the report that you give a "before" or "after" situation? In fact, if possible I need to know what happens before you comment out the function code and what happens after you comment out the function code. This is exactly the information I needed. Unfortunately it is not good news. What we have is three different behaviors -- Windows, Mac and Linux all behave differently. I think the design behavior is this: *change the focus from the left-hand panel (chooses which preference page is displayed) to the right-hand panel: (Windows) click the column heading (Command) to change focus without selecting an item or select an item. (Linux) click an item (clicking the column heading doesn't seem to do anything). (Mac) your report did not make it clear if clicking the column header brought focus to that panel. *press a key which is the first letter of any of the commands (obviously, don't use the first letter of the active command as the result might be confusing). The list of commands should scroll and the next command whose label begins with the letter pressed in step two above should be displayed and selected (have focus). This has nothing to do with whether the list is sorted or not . Sorting is not (currently) allowed on this command list . The actual results are this (before the function code is commented out): On Windows, an item is selected, brought into focus and view, but it is one item passed the proper item on the list (although it will have the same first letter as the proper item). On Linux, the proper item is selected brought into focus and scrolled into view (this is the behavior that window users expect). On Mac, whatever is happening is as yet unclear. After the function code is commented out, Windows performs properly and Linux performs like your report for the Mac. If the Mac code (before commenting it out) works the way the Linux code does (before commenting out) I can simply surround the code with #ifdef Windows. --Ed > -----Original Message----- > From: Bill Wharrie [mailto:bi...@go...] > Sent: Saturday, October 17, 2009 4:13 PM > To: aud...@li... > Subject: Re: [Audacity-devel] irritating bug in Keyboard Preferences when > seeking to the next command by hitting a keyboard character > > > On 17-Oct-09, at 6:02 PM, Ed Musgrove wrote: > > > This appears to have fallen off the radar. My quick fix appears to > > work on Microsoft XP and Vista; the problem does not appear to be > > there in Linux. I need to know what the behavior is on the Mac. Do we > > have an active Mac developer on the list? On a somewhat separate > > track, do we have a list of active beta testers (non-developers) who > > are comfortable with checking out the nightly build, following > > explicit steps to test program changes and reporting? > > I would be one of the latter. As long as a G5 running 10.5.8 is useful. > > > > > To experience the bug: > > *Start Audacity, open Preferences editor, navigate to Keyboard. > > *(On Windows) With the Key Bindings panel open, click on the word > > "Command" (a column heading -- this moves focus from the preferences > > pages list to the key binding column without selecting an item). > > (On Linux) With the Key Bindings panel open, click on the word "New" > > ( this moves focus from the preferences pages list to the key binding > > column but selects an item). > > (On Mac) I have no idea, try both of the above. > > With the 1.3.10 Oct 16 build ... > > On Mac (in my case a Dual G5 2 GHz PPC): click on the word "New" - the > line with "New Command+N" is highlighted, and "Command+N" is in the > text box. > > > *Press the <s> key; note that (on Windows) the list item "Save Project > > As..." is selected (takes focus and is highlighted), when the item > > immediately preceding it "Save Project" should have been selected. > > Pressing the <s> key, nothing appears to happen, except that "New" is > deselected. The contents of the text box do not change. > > Pressing the <j> key scrolls the list so that "Join" is visible at the bottom of > the list, but it is not selected. The contents of the text box do not change. > > > *Now try pressing the <i> key; note that (on Windows) the list item > > "Import Labels..." is selected when the "Import Audio..." should > > have been selected. > > Pressing the <i> key scrolls the list again so that "Import Audio..." > is visible at the top of the list, but again nothing is selected. The contents of > the text box do not change. > > How is this meant to work if the list is not sorted alphabetically in the first > place? > > --Bill Wharrie > > > > > Simply commenting out all the code in the function: > > void KeyConfigPrefs::OnKeyDown(wxListEvent & e) in file: > > audacity/src/prefs/KeyConfigPrefs.cpp > > at line # 396 (in the current CVS head which I just checked out a > > moment ago), eliminates the problem for me. > > > > Try commenting out the code in the function as noted above. Run the > > above test again. > > > > > > You need to comment ALL the code in the function out (removing the > > function requires a bit more work--editing the EVENT_TABLE etc.-- > > which I do for the real repair) this leaves an empty function stub: > > Function > > { > > //every > > //line > > /* or > > Do > > It this > > Way*/ > > } > > > > Thanks! > > > > --Ed > > > > > > > > ---------------------------------------------------------------------- > > -------- Come build with us! The BlackBerry(R) Developer Conference in > > SF, CA is the only developer event you need to attend this year. > > Jumpstart your developing skills, take BlackBerry mobile applications > > to market and stay ahead of the curve. Join us from November 9 - 12, > > 2009. Register now! > > http://p.sf.net/sfu/devconference > > _______________________________________________ > > audacity-devel mailing list > > aud...@li... > > https://lists.sourceforge.net/lists/listinfo/audacity-devel > > > ---------------------------------------------------------------------------- -- > Come build with us! The BlackBerry(R) Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9 - 12, 2009. Register now! > http://p.sf.net/sfu/devconference > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel |