Re: [Audacity-devel] GSoC delay => release delay?

[Dan H. <da...@go...>]

On Fri, Aug 28, 2009 at 11:03:53PM +0100, Martyn Shaw wrote:
> Dan Horgan wrote:
> > On Thu, Aug 27, 2009 at 10:00:02AM +0100, Gale Andrews wrote:
> >> OK someone on feedback@ has given us something to go on
> >> which confirms Noise Generation is broken on a newly 
> >> initialized .cfg. I can replicate all of the below in 1.3.9
> >> Unicode Release:
> >> [snip]
> > 
> > Ah... I suspect the noise problem is my fault, from when I moved some
> > initialisation of that effect into an Init method so that I could use it
> > in a script. Sorry! I'll see if I can find a fix.
> 
> Good report on feedback@!  Please thank that person.
> 
> gPrefs->Read returns true or false depending whether it read from the 
> pref or used the default
> http://docs.wxwidgets.org/2.8/wx_wxconfigbase.html#wxconfigbaseread
> 
> All other ::Init()s return true.  I see no reason not to in Noise.cpp 
> so I've committed the change.  Looks fixed to me, and I traced the 
> error and then lack of it.

Thanks, good catch... this was the conclusion I came to as well, but I
hadn't found time to test properly and commit it. Silly mistake of mine, sorry
once again!

Dan

> 
> > I haven't found any problems with EQ points, but if there is something
> > wrong, it could also be due to my changes.
> 
> Maybe I was just confused about the EQ points, I had been looking at 
> it for too long.
> 
> TTFN
> Martyn
> 
> > Dan
> > 
> >>
> >> | From Gale Andrews <ga...@au...> 
> >> | Thu, 27 Aug 2009 09:39:46 +0100
> >> | Subject: [Audacity-devel] GSoC delay => release delay?
> >>> | From Martyn Shaw <mar...@go...> 
> >>> | Thu, 27 Aug 2009 01:00:38 +0100
> >>> | Subject: [Audacity-devel] GSoC delay => release delay?
> >>>> Gale Andrews wrote:
> >>>>> ... I had actually done a rc1 so FWIW for testing: 
> >>>>> http://www.gaclrecords.org.uk/audacity-win-unicode-1.3.9rc1.exe
> >>>> I uninstalled all previous versions and deleted C:\Documents and 
> >>>> Settings\Martyn\Application Data\Audacity before trying this.
> >>>>
> >>>> I see Generate -> Noise not doing anything.  And moving envelope 
> >>>> points in Draw mode of EQ is broken.  Did a fresh checkout and tried again
> >>>>
> >>>> (...wait 10 minutes or more ...)
> >>>>
> >>>> still broken.
> >>>>
> >>>> Updated my normal working version (Unicode Debug) and got Noise not 
> >>>> doing anything but EQ OK.  Could easily be just confused.
> >>>>
> >>>> TTFN
> >>>> Martyn
> >>> Frankly I've been finding the behaviour so erratic recently I don't
> >>> really know whether I'm seeing real bugs or "ones that come and 
> >>> go". 
> >>>
> >>> I can launch Audacity 1.3.9 Unicode Release (just rebuilt into
> >>> empty build folder as always, but not from fresh CVS checkout),
> >>> and Generate >Tone (default 30 seconds) is fine. 
> >>>
> >>> Last night I was playing in 1.3.9rc1 with this scenario:
> >>>
> >>>    1.  Generate 30 seconds Chirp
> >>>    2. Tracks > Add New > Audio Track
> >>>    3. Generate DTMF of 30 seconds
> >>>    4. Apply Truncate Silence (max silence = 10) to DTMF
> >>>    5. No truncation occurs
> >>>    6. Does not depend on vertical position of tracks or linking. 
> >>>    7. Remove Chirp track and try Truncate Silence again
> >>>    8. Truncation works
> >>>    9. Then duplicate DTMF, select it and try and generate Noise into it
> >>>   10  Nothing happens 
> >>>
> >>> Now tonight in 1.3.9 Unicode Release the noise generation at step 9
> >>> works, but the truncation at step 5 still does not. I can't see anything
> >>> relevant to Noise Generation could have changed in the code since rc1.
> >>>
> >>> What exact Noise Generation operations have you done and are you 
> >>> using arrow keys to navigate or clicking? That distinction makes no
> >>> difference here though. I'm inclined to think we can't hold up 1.3.9 for
> >>> "come and go" bugs, after all there a number of them in there already.
> >>> Releasing might produce a scenario that will always reproduce and 
> >>> lead us to a fix. 
> >>>
> >>> EQ points dragging in Draw Curves mode is OK for me in 1.3.9rc1 
> >>> (i.e. exactly the same build as you tried) and tonight in 1.3.9. I'm
> >>> on Windows XP SP2, compatibility mode is off. 
> >>>
> >>>  
> >>>
> >>>
> >>> Gale 
> >>>
> >>  
> >>
> >>
> >> ------------------------------------------------------------------------------
> >> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
> >> trial. Simplify your report design, integration and deployment - and focus on 
> >> what you do best, core application coding. Discover what's new with 
> >> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> >> _______________________________________________
> >> audacity-devel mailing list
> >> aud...@li...
> >> https://lists.sourceforge.net/lists/listinfo/audacity-devel
> >>
> > 
> > ------------------------------------------------------------------------------
> > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
> > trial. Simplify your report design, integration and deployment - and focus on 
> > what you do best, core application coding. Discover what's new with 
> > Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> > _______________________________________________
> > audacity-devel mailing list
> > aud...@li...
> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
> > 
> 
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
> trial. Simplify your report design, integration and deployment - and focus on 
> what you do best, core application coding. Discover what's new with 
> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>