Re: [Audacity-devel] MixerBoard -> HEAD

[Vaughan J. <va...@au...>]

Martyn Shaw wrote:
> Vaughan
>
> I've had a look at MixerTrackCluster::UpdateMeter, and I think I see 
> the problem, not sure of the best way to fix it:
>
>     // 50ms is TrackPanel's timer interval.
>     // But be more recent here, just the last 10%.
>     const double kTimerInterval = 0.0005;
>
> but 0.0005 is 0.5ms, just 22 samples.  Then you split this into 500 
> Frames and so many frames have no samples in them.
>
>   
Thanks. I'd already found that was the problem (and it was actually 
intentional), as I just wrote. Then I spent a bunch of time testing 
various values for the number of frames.

> I have tried 50ms and 50 Frames, with much better success but it's a 
> bit sluggish, particularly when the signal suddenly gets smaller.
>
> I'm also seeing UpdateMeter not being called every 50ms, nearly always 
> less frequently.  If you don't meter all the audio since the last call 
> you may miss peaks.
>   
Thanks for checking on the actual frequency of calls. I'd thought of 
that but hadn't gotten around to it yet. I was seeing dropouts when my 
machine made a significant disk access, so that's probably why. I'll 
make it keep track of the t1 from the previous call.

Thanks!

- Vaughan


> TTFN
> Martyn
>
> Vaughan Johnson wrote:
>   
>> Thanks for the feedback on the MixerBoard, Richard and Gale. Please 
>> check what I've just committed. I think this fixes the MixerBoard meter 
>> update issues:
>>
>> * Now using GetMinMax and GetRMS correctly. (Misunderstood analogy to 
>> old GetWaveDisplay when I ported.)
>>
>> * Clipping no longer over-reported. (I don't think you mentioned it, but 
>> it wrongly showed clipping almost immediately.)
>>
>> * Display is now post-fade/pan rather than pre-fade/pan. This is based 
>> on a runtime flag, but can be made a pref if needed. I agree 
>> post-fade/pan is far more useful, so it's the default.
>>
>> * Mono tracks now show both channels, but from same mono source, 
>> affected by gain and pan.
>>
>>
>> - Vaughan
>>
>>
>> ------------------------------------------------------------------------------
>> Enter the BlackBerry Developer Challenge  
>> This is your chance to win up to $100,000 in prizes! For a limited time, 
>> vendors submitting new applications to BlackBerry App World(TM) will have
>> the opportunity to enter the BlackBerry Developer Challenge. See full prize  
>> details at: http://p.sf.net/sfu/Challenge
>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
>>     
>
> ------------------------------------------------------------------------------
> Enter the BlackBerry Developer Challenge  
> This is your chance to win up to $100,000 in prizes! For a limited time, 
> vendors submitting new applications to BlackBerry App World(TM) will have
> the opportunity to enter the BlackBerry Developer Challenge. See full prize  
> details at: http://p.sf.net/sfu/Challenge
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
>