Re: [Audacity-devel] Visual Studio

[Leland <le...@au...>]

Gale Andrews wrote:
> | From Brian Mayer <bma...@ho...> 
> | Sun, 5 Jul 2009 20:44:11 -0400
> | Subject: [Audacity-devel] Visual Studio
>> P4 
>> Memory leaks: 
>>
>> Effect::CountWaveTracks Reported by LL. 
>>
>> Gale, I've combed over the code and the only issue
>> I could find was lack of class destructors.  Without a memory leak tool,
>> I can't confirm it was leaking or improved, but works fine amplifying
>> six selected wav files.  Stepping through the debugger, it hits the ne
>> destructors.
>>
>>
>> I've attached the patch file for Track.h.
> 
> Thanks, Brian. Please send any patches to the list for comments,
> which I've now done with this one. For a memory leak tool,
> I think Leland (LL) has used Visual Leak Detector, free from:
> http://www.codeproject.com/KB/applications/visualleakdetector.aspx
>  
The patch is fine and I'm keen on the idea of having virtual destructors
for every class, but am about as lazy in doing it as everyone else it seems.

However, I believe the CountWaveTracks() problem was resolved with:

http://audacity.cvs.sourceforge.net/viewvc/audacity/audacity-src/src/effects/Effect.cpp?view=log#rev1.68

Leland