Re: [Audacity-devel] Draw tool not fully functioning and a question

[Vaughan J. <va...@au...>]

Wow, foot in mouth. That method has seen a lot of changes, so fixing the 
1.2.x version is really not worthwhile.

Running it in debug mode, I ran across a runtime check failure where it 
was assigning an uninitialized newLevel to mDrawingLastDragSampleValue, 
so I think changes were made to normal drawing mode that affected 
smoothing mode, but nobody saw the bug until now. Initializing that 
newLevel solves the failure, but doesn't fix drawing. Anybody who worked 
on that code more recently want to take a shot at it?

- Vaughan


Vaughan Johnson wrote:
> Hi, Greg! I hope you're doing well. I suggest working on the 1.3.x 
> code, and although we're in feature freeze, bug fixes are welcome.
>
> I wonder if it's actually in the drawing code, though. I think lots 
> more has changed regarding key modifiers than in the drawing code. But 
> I don't know how much of that drawing code has been touched. If I can 
> get CVS to cooperate later, I'll take a look.
>
> - Vaughan
>
>
> Greg Mekkes wrote:
>> I'm currently using 1.2.X, but compiled 1.3.7 to see where things
>> have progressed to - very impressive.  Came across the draw tool
>> not doing everything it should in 1.3.7.  Left click draw and CTL
>> left click to move a single point work fine, but ALT left click
>> does not do a ting.  The can of spraypaint icon appears, but the
>> smoothing functionality does not kick in at all.
>>
>> And one question.  It's been a long time since doing development
>> work on 1.2.X for me.  There is a feature I'd love to have in
>> 1.3.X, which Dominic tells me was in 1.0 early on.  It would not
>> be worth the effort to put it in 1.2.X, but that is the source
>> code I am familiar with.  I sense that this would not be the best
>> time to bring up a new feature request - should I just hold off
>> on bringing anything up right now or what would be the best timing?
>> In a nutshell - it's the grouping ability that 1.0 had, call it a
>> combining that can be uncombined.
>>
>> Thanks for your time,
>>
>> Greg Mekkes
>>
>>
>>   
>