Re: [Audacity-devel] [GSoC] Potential student introduction & [Patch] for TimeTextCtrl digit focusing

[Dan H. <da...@go...>]

On Thu, Mar 19, 2009 at 07:45:39PM +0100, Markus Meyer wrote:
> Dan Horgan schrieb:
>>    if (length <= 0.0)
>>       length = sDefaultGenerateLen;
>>
>> at the beginning of their Effect::Process() method. This is presumably
>> because the actual processing code may fail if the length is not
>> positive.
>
> I do not consider changing this long-standing behaviour a good idea. I  
> like it when e.g. Generate Tone creates 30 seconds of tone when nothing  
> is selected.
>
>
> Markus

Certainly, anybody deliberately setting the duration to zero probably
knows what they are doing, and perhaps it should be left that way if
that is how people are used to it. On the other hand, it seems illogical
to have it do other than what it says it is going to do, and it is
surely inconsistent to have different behaviour for DTMF from the other
generators. Bear in mind that even with the patch, the control is still
initially set to 30 seconds, so for quickly generating a tone it is not
necessary to adjust anything.

It is not for me to make such usability decisions; this is just how it
seems from a relative outsider's perspective.

Thanks,
Dan