Re: [Audacity-devel] Should or shouldn't...Support CTRL on the Mac?

[Richard A. <ri...@au...>]

On Sat, 2009-01-03 at 00:52 -0600, Leland wrote:
> > That sounds like a very useful patch.  I bet wxMac would be willing to 
> > apply it If there is a way to get the config file to be backwards 
> > compatible - and if it isn't so they might be willing to sort that part 
> > out. 
> > 
> > Definitely worthwhile.
> > 
> I think so too, but it would mean that you and Mark would need to patch 
> your local copies of wxWidgets with the attached.  This that's going to 
> be a big deal?  (it goes against 2.8.9)
Could it be set up so that there is a function call the application can
make to wx (or even an optional parameter to the relevant constructor)
to turn off the CMD / CTRL mapping? Other existing programs would not
make the call / pass the parameter, and so get the current behaviour, we
do and so get what we want. Other developers can then be encouraged to
add support and the call in the future (if upstream thinks it's a good
idea).

I realise this makes the implementation rather more complex, but it does
make it easier to integrate. On the other hand if upstream are intending
to break source compatibility in the near future anyway (wx 3.0?) then
they may not care.

> Also, I've made it to where Audacity detects whether the patch has been 
> applied using weak references and acts like it did before if it isn't. 
> Otherwise, if it has then it allows the CMD/CTRL separation.
> 
> However, the more I think about that, the more I don't like it.  I'm 
> starting to think that the build of Audacity should fail if the patch 
> isn't applied.  That way it would raise a flag that something else needs 
> to take place before the builder can get a correctly build Audacity.
I agree - Whilst doing different things when features are and aren't
available is very clever, I'm not convinced it's a good idea in this
case. I'm also worried about what might happen if Audacity was built one
way, then tried to run with a set of dynamically linked wx libraries
built the other ...

> The build error would be an undefined symbol (Audacity_Ctrl_Patch) and 
> when the user searched the source for it, a comment could direct them to 
> the patch file in audacity/mac.  (there's already a couple of old ones 
> there...should probably delete those one day...)

Definitely clean the old patches out. You could even do something with
#ifndef Audacity_Ctrl_Patch #error "You need a patched copy of wxMac" to
present your message directly in the compiler output at the offending
point.

Richard