Re: [Audacity-devel] Problems building with wxWidgets 2.8.6

[Milan B. <mba...@ya...>]

--- Richard Ash <ri...@au...> wrote:
> the bottom. The solution is to apply the patch
> listed on that page:
> audacity-1.3.4-nolibfailure.patch

Works fine. Thanks.

> > ../lib-src/allegro/mfmidi.h:22: warning: 'class
> > Midifile_reader' has virtual functions but
> non-virtual
> > destructor
> 
> We'd consider a patch :) although given that this is
> an external library
> rather than part of audacity's code it might take
> longer to be applied
> because it needs to go to the upstream Allegro
> maintainers. It's also worked fine for years.

That error does not crash applications or anything
like that, but, AFAIK C++, it creates memory leaks.
Anyway, the change to be done is minimal, just declare
a virtual destructor to Midifile_reader class.

If you still want a patch, I can create it if you
would accept one made against 1.3.4 (I wouldn't want
fetch the entire CVS tree just for this - and I use
Audacity very occasionally, so this minor memory leak
doesn't bother me that much).

Thanks,

Milan Babuskov
http://www.flamerobin.org



      ____________________________________________________________________________________
You rock. That's why Blockbuster's offering you one month of Blockbuster Total Access, No Cost.  
http://tc.deals.yahoo.com/tc/blockbuster/text5.com