Re: [Audacity-devel] [audacity-devel] Fix for build with current wxWidgets library

[Richard A. <ri...@au...>]

On Mon, 2008-02-18 at 13:45 -0700, jue...@so... wrote:
> Hi,
> I tried to compile audacity 1.3.4 from CVS with wxWidgets 2.8.7/GTK under 
> Ubuntu Feisty.
> That failed with various 'deprecated..'-warnings from wxWidgets library.
> Examining the changelog of that library, revealed replacements for the 
> deprecated wxWidgets methods
> ( Inside --> Contains,
>  GetStyle --> GetWindowStyle,
>  SetBestFittingSize --> SetInitialSize,...).
> After applying the changes in various source files, audacity built 
> completely. 
> 
> The attached file is a unified patch against CVS_HEAD with all changes. 

Thanks for the patch. It applies cleanly and builds on Linux with wxGTK
2.6.4, which is good. Looking at the patch, there is one bit I don't
understand the reasoning behind:

--- ./audacity/src/Envelope.cpp 2008-02-11 00:38:20.000000000 +0100
+++ ../audacity/src/Envelope.cpp    2008-02-11 00:42:12.000000000 +0100
@@ -534,7 +534,7 @@
                           float zoomMin, float zoomMax, float eMin,
float eMax)
 {

-   if (event.ButtonDown())
+   if (event.ButtonDown() && mButton == wxMOUSE_BTN_NONE)
       return HandleMouseButtonDown( event, r, h, pps,dB,
                                     zoomMin, zoomMax, eMin, eMax);

Other than this I'm happy to apply the patch into CVS unless anyone else
objects.

Richard