Re: [Audacity-devel] about memory leaks

[James C. <cr...@in...>]

Andreas Micheler wrote:
> I just realized there seem to be a few memory leaks in Audacity.
> There's not really much memory debugging code. Why?

There is not a good reason.  It would be nice to have no memory leaks at 
all.

Is it possible to make the definition that goes into the .cpp file a bit 
shorter?  E.g just adding one line such as:

MEMORY_ALLOC_DEBUGGING( __FILE__ )

where MEMORY_ALLOC_DEBUGGING is a macro that has already been defined in 
a common include file?  I'd be fine with this going into every .cpp file 
in the main audacity directory that uses the 'new' operator.  We don't 
get coverage of new/delete in libraries we use this way, but it is at 
least a start to clearing the leaks.

As to making the changes that fix the memory leaks, if the change is not 
blindingly obvious once the leak is found we do need to discuss it 
on-list.   If a memory leak fix is going into 1.3.5 we need to be very 
confident that it is a true fix and not causing some problem elsewhere.


--James.


> I.e. using in configwin.h

> #ifdef _DEBUG
>     #ifdef _MSC_VER
>         #include <crtdbg.h>
>     #endif
> #endif

> and in any .cpp file after the headers:

> #ifdef _DEBUG
>     #ifdef _MSC_VER
>         #undef THIS_FILE
>         static char*THIS_FILE= __FILE__;
>         #define new new(_NORMAL_BLOCK, THIS_FILE, __LINE__)
>     #endif
> #endif