[Audacity-devel] Log sweep in tone gen

[Martyn S. <mar...@go...>]

Hi there

Andreas Micheler wrote:
...
>> The 'logarithmic' part of ToneGen worked fine, although we may have 
>> some work to to on the width of the boxes on the dialog.
> The following looks a bit better:
> 
> void ToneGenDialog::PopulateOrExchangeExtended( ShuttleGui & S )
> {
...
>    S.StartMultiColumn(2, wxCENTER);
>    {
>       S.TieChoice(_("Interpolation"), interpolation,  interpolations);
>       S.AddFixedText(_("Length"), false);
...

Yes, much better.  It looks good to go to me here but I'm not sure 
what we are doing on the release schedule thing (I mean after the 
upcoming release) with regards adding new stuff, so I'll hold on to it 
for now.  I think the log spectrum thing needs to go in at the same time.

A couple of other things:
I removed interpolationNames[interpolation] from GetEffectDescription 
since it isn't in use, as far as I can tell.

Please use 3 spaces instead of a tab - it's kind of a coding standard, 
see http://www.audacityteam.org/wiki/index.php?title=CodingStandards

I wonder why this never had a way of using it before?

> One question: Why does the ShuttleGuiBase::AddChoice set a size hint so big?
> Why not use -1 (default size) also for the width size hint?
> Suggestion: ShuttleGui.cpp, line 338:
>    pChoice->SetSizeHints( -1 /*was: 180*/,-1);// Use -1 for 'default
> size' - Platform specific.

I don't know, but somebody else might.

TTFN
Martyn