Re: [Audacity-devel] Patch submitted for your approval...

[Jimmy J. <ecl...@gm...>]

Yep thats it, thanks.

Jimmy

On Jul 1, 2007, at 3:57 AM, James Crook wrote:

> Jimmy:
>
> Just checking - This addresses this item from the checklist:
>
> "Provide 'Unrecognised Audio File Format' dialog with help-link button
> for more detail."
>
> Correct?
>
> I've added your patch to the patch tracker.  I'll have a more detailed
> look at the patch shortly.  It should be in CVS within the next few  
> days.
>
> --James.
>
>
>
> Jimmy Johnson wrote:
>> Hey All,
>>
>>     So I created a patch to give the import error dialog a help  
>> button...
>>
>> 1) It adds 2 files ErrorDialog.cpp and ErrorDialog.h to the project.
>> 2) Modifies Project.cpp to use the new class.
>> 3) Modifies the makefile.in to compile in the new source files.
>>
>>     This is the first time I have attempted to use "patch" it  
>> seems to
>> work okay with my computer.  Let me know if you guys have  
>> problems! One
>> thing I did have problems with it getting the layout to look good,  
>> I'm
>> not sure if this is just a problem with Mac OS or if its universal  
>> but I
>> couldn't get the buttons to layout correctly.  Maybe I'm doing  
>> something
>> wrong, but I looked at the entire project and it seemed to be that
>> unless a call was made directly to a Mac OS X dialog that most all  
>> the
>> windows had the characteristic of not looking so great.
>>
>> Thanks again for all your help in getting me started in Open Source.
>
>> Jimmy
>
>> On Jun 21, 2007, at 3:15 AM, Dominic Mazzoni wrote:
>
>>> On Jun 18, 2007, at 2:11 PM, Jimmy Johnson wrote:
>>>> So, I have added some of the functionality that was requested  
>>>> for the
>>>> next release of Audacity.
>>>>
>>>> I  have some other questions:
>>>>
>>>> 1)  Can I just upload my changes to CVS?
>>>
>>> I'm not sure if someone gave you a direct answer to this question,
>>> but the usual approach is that you mail a patch to the list the  
>>> first
>>> few times.  We'll probably give you a few suggestions.  If we're
>>> generally happy with the quality of your code, we'll grant you CVS
>>> write access.  After that you're welcome to check in code to CVS
>>> whenever you want, and just email the list so we know what you're up
>>> to.  Discuss major changes with everyone first, of course.
>
>
> ---------------------------------------------------------------------- 
> ---
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Audacity-devel mailing list
> Aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel