Re: [Audacity-devel] audacity 1.3.2b ftp patch
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Richard A. <ri...@au...> - 2007-03-30 20:14:33
|
On Fri, 2007-03-30 at 12:23 -0400, JP wrote: > Submitted for your approval is a patch for the ftp client in Audacity. This > fixes case issues when the ftp server has any capitals in directory names, > or if the file to be uploaded has any capitals in it. If either of those two > conditions exist the previous version of the client returns an error: > > 553 /path/filename.mp3: No such file or directory". > > in this case if either or both "path" or "filename.mp3" have any caps in > them the error message returns them without caps, due to the .MakeLower() > switch in the wxString class. > The patch removes all 7 instances of .MakeLower() which may be a bit > overkill but I have compiled and tested it against today's CVS of ver 1.3.2b Ah - some is actually (trying to) use FTP. This has been a bit of a cinderelerra feature, as it was contributed from outside the development team, and has never really been anyone's priority. The first thing I found is that is seems to only do active mode ftp, i.e. no passive FTP support, which makes it quite hard to test behind a firewall that doesn't support active FTP. Anyway, I installed a local FTP server, and it works OK with the default linux FTP client. When I try to use the current (unpatched) audacity ftp, I can connect to the server, and get a directory listing, but when I try to upload a file it tries to use the full local path as the upload file name, which fails, and then hangs. With the patch applied, it hangs before I can get a directory listing after connecting. It did work once, but as soon as I did something it froze again. If I click disconnect, then the FTP server disconects, but audacity is left frozen afterwards. So, all in all it's not that the patch is necessarily broken, but it doesn't fix it either, so I can't really test whether the patch does as advertised. Richard |