Re: [Audacity-devel] DTMF tone generator

[<Mar...@ao...>]

Salvo
 
Markus has a good point here, and made it very gently.  I think  that 
developers should try and not leave problems for people on other  platforms to fix, 
although I have done so on many occasions.
 
I've always found these flags and things difficult and only having one  
platform to develop on means that differences between platforms (and there are  
bound to be some) are difficult to track down.  Leland helped me (a lot!)  in the 
past with this.
 
The ShuttleGUI system that James set up appears to be a higher level of  
abstraction that gets over some of these problems, making life easier.   However I 
have not tried to write anything with it yet (I should!) (and probably  you 
too!).
 
I think that using something like
      int temp=49;    //this  bit needs fixing
S.StartStatic( _("Duty  Cycle"),1);
{
S.StartMultiColumn(2,  wxEXPAND);
S.SetStretchyCol(1);
S.TieSlider( _("duty cycle:"), temp,  100);
S.EndMultiColumn();
}
instead of
       S.SetStyle(wxSL_HORIZONTAL);
mDtmfDutyS =  S.Id(ID_DTMF_DUTYCYCLE_SLIDER).AddSlider(wxT(""), dDutyCycle,  
DUTY_MAX);
mDtmfDutyS->SetRange(DUTY_MIN,  DUTY_MAX);
would make the problem easier to solve as once it is right in one  effect 
(for all platforms), it would be right in all of them.  (I modified  this 
slightly from the "OGG Export Setup" in preferences as it had a  slider.)
 
I see that 'sliders' can only have values from 0 to some int, rather  than an 
arbitrary range, but that could be fixed, similarly with decimal places,  I 
guess.
 
I get the feeling that the code would be somewhat shorter if one of us did  
this.  Shall I have a look at converting the interface into using just  
ShuttleGUI or do you want to?  I think eventually all the effects will use  it, if 
people get around to it!
 
TTFN
Martyn
 
In a message dated 04/01/2007 21:57:25 GMT Standard Time,  
ven...@ya... writes:
Hi Markus,
glad to hear it is working on  linux and you like it :-)
Unfortunately, I am quite new on the wxWidgets, so  I have
no idea what could be reason for the problem you describe.
I  thought the sliders should be fairly the same everywhere,
but please, if you  find a fix for it on linux, I will be
happy to re-test it in windows, which  is the platform where
I develop/test.

cheers,
.salvo


---  Markus Meyer <me...@me...> ha scritto:

> Hi Salvo
> Hi  Martyn
> 
> Mar...@ao... schrieb:
> > I have added  this to CVS with the minor changes below. 
> I hope  this meets  
> > with you approval and that I've got the vcproj file
>  right.  Can  anyone verify?  
> > Also on other  platforms?
> >   
> the DTMF tone generator is funny, I  like it very much!
> 
> Just one small remark: the slider on Linux  has a width of
> like 2 pixels
> or so, so I can't really use it  with the mouse to change
> values ;)
> Clicking into the slider and  using the cursor keys works,
> though. Before
> I dig into the code  to fix this, do you think what could
> be the cause?
> Are we just  missing some small wxEXPAND | wxALL or
> something like this
> in a  sizer?
> 
> 
> Markus
>