Re: [Audacity-devel] Previews added, button orders changed

[Vaughan J. <vjo...@co...>]

Anthony Airon Oetzmann wrote:

>...
>The fx.
>
>I think the button order is great! The VST fx don't have that yet btw.
>
Glad you like it. Changed it for VST, too. In fact, I think I've gotten 
them all now.

Hey, Dominic, it seems for the VST GUI dialogs, Preview is the default 
button. The code sets it to be the OK button, and I added a SetFocus() 
for the OK button, but it's still happening. Anything obvious to you 
about why that's happening?

>
>More fx notes:
>The preview on the "Change Tempo" doesn't do anything yet.
>
Fixed. Change Pitch had the same bug and I fixed that, too.


>
>"Change Pitch" and "Change Speed" could use some alias filtering. The
>filter frequency (dunno which order of filtering in this hicut filter)
>should be what it is when simple resampling is applied. A switchable lowcut
>would be bad either(rumble). Right now the aliasing is quite audible if I'm
>not mistaken.
>
Tony, I think the answer to this is that's what we're getting from the 
SoundTouch and SRC libraries. Dominic, is it reasonable to try to 
automatically improve the results?


>
>The FFT Filter has a linear scale. A logarythmic display of the graph would
>be the way to go here.
>
>
>Big wishes(we all have 'em):
>Change the selection whilst keeping the fx dialog open will let the fx work
>on that selection, not the one that existed when the fx dialog popped open.
>This takes the burden 
>off the user to open the fx dialog again and again.
>
Sounds like a good idea to me. Dominic, I see that wxWindows allows 
modeless dialogs. Is there a good reason not to do that (in 1.2.1)?

>
>Presets. (hehe)
>
Is this something that's been discussed before? What kinds of presets do 
you want? For all effects?

Thanks for your testing & comments, Tony. I'll put up a fresh build this 
weekend.

-Vaughan