Re: [Audacity-devel] Noise Removal now has Preview

[Dominic M. <do...@mi...>]

Vaughan Johnson wrote:
> Noise Removal now has Preview.
> 
> Affected files: src/effects/NoiseRemoval.*
> 
> I've got several more of these to do, but I'm thinking the <Preview 
> (spacer) Cancel OK> order is better, so... Everybody please take a look 
> at the Equalization dialog and if you object, let me know soon. It's 
> drudge work, but not too hard in most cases, to change it, but easier to 
> just do it as I'm adding Preview to the remaining ones.

I like OK in the bottom right.  The only concern I have is whether this
is inconsistent with some of the stock wxWindows dialogs we're using.
The only one I could find off the top of my head was "Save changes
before closing?" which has the order:

   [Yes]  No  Cancel

...but then again, this dialog violates the UI standards for everybody
except Microsoft anyway.  The buttons should be:

   Cancel          Don't Save   [Save]

If this is the only inconsistent one, then I definitely think we should
switch all effects over to OK in the bottom-right.  But if there are
more wxWindows dialogs that come up with a different style, that might
be a reason to reconsider.  Anyone know of any more?

Anyway, Vaughan, thanks very much for doing the drudge work!

- Dominic

> Thanks,
> Vaughan
> 
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: VM Ware
> With VMware you can run multiple operating systems on a single machine.
> WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines at the
> same time. Free trial click here: http://www.vmware.com/wl/offer/345/0
> _______________________________________________
> Audacity-devel mailing list
> Aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel