Re: [Audacity-devel] the Edit-Silence bug strikes back

[Dominic M. <do...@mi...>]

Daniel James wrote:
>>Do you think
>>that you probably had a selection go past the end of a track when
>>you called Silence the time it crashed?
> 
> It was actually right at the beginning of a track, which might be 
> related (past the beginning somehow?) I haven't seen this crash 
> happen since.

That could have done it.

OK, here's the simplest possible patch for 1.1.3: In Sequence.cpp,
modify line 829 in Sequence::Set

old:

          if (silenceBlock) {

new:

          if (0) {

(in other words, make sure it never takes that first branch).

I'm working on checking in a much better fix in CVS, but it's
too tricky to add it to 1.1.3.

Thanks again for the detailed debugging - it made it easy for
me to track this down.

> We did a lot of recording with four input channels last night, and 
> Audacity was stable for tracks of twenty minutes or more. Select 
> eight input channels and it messed up quite quickly, anything from a 
> few seconds to two minutes in. 

By messed up, do you mean it dropped samples?

> My plan is to use ecasound as a comparison for multitrack behaviour. 
> Once I've got that working with eight inputs recording to eight 
> separate files, we'll have something to compare Audacity against. I'm 
> pretty sure the hardware is up to the job, as the machine is fast and 
> well optimised.

Sounds good!  It'll be great to hear how Audacity stacks up.

- Dominic

> Cheers
> 
> Daniel
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: ObjectStore.
> If flattening out C++ or Java code to make your application fit in a
> relational database is painful, don't do it! Check out ObjectStore.
> Now part of Progress Software. http://www.objectstore.net/sourceforge
> _______________________________________________
> Audacity-devel mailing list
> Aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel