audacity-devel — Discussion among Audacity developers

Re: [Audacity-devel] "Perfect" MP3 fails to import

[James C. <jam...@gm...>]

With that mp3 file we reach this point in layer3.c, with cachesz == 20 and
bits_left == -22

  if (cachesz + bits_left < 0)
    return MAD_ERROR_BADHUFFDATA;  /* big_values overrun */


There's a patch here that addresses length issues and changes that code:
https://fossies.org/linux/avidemux/avidemux_plugins/ADM_audioDecoders/ADM_ad_mad/patches/length-check.patch

   635 +     if (cachesz - fakebits < 1)  636 +       return
MAD_ERROR_BADHUFFDATA;  637       xrptr[1] = MASK1BIT(bitcache,
cachesz--) ?  638         -requantized : requantized;  639     }  640
@@ -1155,9 +1221,6 @@ enum mad_error III_huffdecode(struct mad  641
  }  642    }  643    644 -  if (cachesz + bits_left < 0)  645 -
return MAD_ERROR_BADHUFFDATA;  /* big_values overrun */  646 -  647


The patch looks pretty extensive.

    From: Kurt Roeckx <ku...@ro...>
    Date: Sun, 28 Jan 2018 19:26:36 +0100
    Subject: Check the size before reading with mad_bit_read

    There are various cases where it attempts to read past the end of the
buffer
    using mad_bit_read(). Most functions didn't even know the size of the
buffer
    they were reading from.

We are using libmad 0.15.1b.
Debian have  0.15.2b-9 with these fixes from 2018 in.

This would need careful review.  Probably worth contacting Kurt Roeckx too,
to confirm we're understanding things correctly, and say thank you.

--James.




On Thu, 15 Apr 2021 at 15:48, Steve Fiddle <ste...@gm...> wrote:

>
>
> On Thu, 15 Apr 2021 at 15:41, James Crook <jam...@gm...> wrote:
>
>> Your first message never made it to this list (I just checked the
>> archive).
>> What's the link for the mp3?
>>
>
> You can get it here:
> https://drive.google.com/file/d/1qCPXtsBfFII2NwsSVMZY9k-Lx6sbhlS8/view?usp=sharing
>
> Steve
>
>
>>
>> On Thu, 15 Apr 2021 at 15:35, Steve Fiddle <ste...@gm...>
>> wrote:
>>
>>> Good detective work James.
>>>
>>> Any ideas about the MP3 file (first post of this thread)? Given your
>>> explanation of the OGG problem, I assume that it is a different issue.
>>>
>>> I'm thinking that it is probably an Audacity bug because the file
>>> appears to be a valid MP3 file. On the other hand, if the MP3 is malformed
>>> (in some way that I've not been able to detect), then it's rather more open
>>> to opinion whether or not it is an Audacity bug, or a bug in the
>>> application that created it.
>>>
>>> Steve
>>>
>>> On Thu, 15 Apr 2021 at 13:43, James Crook <jam...@gm...>
>>> wrote:
>>>
>>>> Logged as: https://bugzilla.audacityteam.org/show_bug.cgi?id=2748
>>>>
>>>>
>>>> On Thu, 15 Apr 2021 at 13:27, James Crook <jam...@gm...>
>>>> wrote:
>>>>
>>>>> It's the same infinite loop as JUCE had:
>>>>>
>>>>>
>>>>> https://forum.juce.com/t/ogg-vorbis-file-puts-juce-oggreader-in-infinite-loop/41148
>>>>>
>>>>> So will be fixed if we upgrade to 1.3.7 or later.
>>>>>
>>>>> On Thu, 15 Apr 2021 at 13:00, James Crook <jam...@gm...>
>>>>> wrote:
>>>>>
>>>>>> On both 3.0.2 and 2.4.2 it's stuck in library file, vorbisfile.c
>>>>>>
>>>>>> static int _fseek64_wrap(FILE *f,ogg_int64_t off,int whence){
>>>>>>   if(f==NULL)return(-1);
>>>>>>   return fseek(f,off,whence);
>>>>>> }
>>>>>>
>>>>>> 'off' and 'whence' are both zero ( SEEK_SET ==0, SEEK_CUR==1,
>>>>>> SEEK_END==2).  We're compiled 32 bit on windows.  Anyone know if it hangs
>>>>>> on mac/linux (compiled 64 bit) too?
>>>>>>
>>>>>> --James.
>>>>>>
>>>>>>
>>>>>> On Thu, 15 Apr 2021 at 12:31, James Crook <jam...@gm...>
>>>>>> wrote:
>>>>>>
>>>>>>> Confirmed freezes for me on Windows.
>>>>>>>
>>>>>>> On Thu, 15 Apr 2021 at 12:20, Steve Fiddle <ste...@gm...>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> And by "coincidence" (?), a problem reported importing this ogg
>>>>>>>> file:
>>>>>>>>
>>>>>>>> https://upload.wikimedia.org/wikipedia/commons/0/0f/Claude_Debussy_-_Premi%C3%A8re_Arabesque_-_Patrizia_Prati.ogg
>>>>>>>>
>>>>>>>> As with the MP3 file, it can be imported if you select the
>>>>>>>> "FFmpeg-compatible files" filter, but in this case, using Audacity's native
>>>>>>>> OGG importer causes Audacity to freeze on both Windows and Linux (not
>>>>>>>> tested on macOS).
>>>>>>>>
>>>>>>>> I don't like coincidences as they may be indicating a deeper
>>>>>>>> problem.
>>>>>>>>
>>>>>>>> Steve
>>>>>>>>
>>>>>>>> On Thu, 15 Apr 2021 at 12:01, Steve Fiddle <
>>>>>>>> ste...@gm...> wrote:
>>>>>>>>
>>>>>>>>> I've tested the attached file with multiple tools in Linux and it
>>>>>>>>> appears to be perfectly formed, yet Audacity still complains that it is
>>>>>>>>> malformed and refuses to import it.
>>>>>>>>>
>>>>>>>>> Steve
>>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> audacity-devel mailing list
>>>>>>>> aud...@li...
>>>>>>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>>>>>>
>>>>>>> _______________________________________________
>>>> audacity-devel mailing list
>>>> aud...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>>
>>> _______________________________________________
>>> audacity-devel mailing list
>>> aud...@li...
>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>
>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Re: [Audacity-devel] "Perfect" MP3 fails to import

[Steve F. <ste...@gm...>]

On Thu, 15 Apr 2021 at 15:41, James Crook <jam...@gm...> wrote:

> Your first message never made it to this list (I just checked the archive).
> What's the link for the mp3?
>

You can get it here:
https://drive.google.com/file/d/1qCPXtsBfFII2NwsSVMZY9k-Lx6sbhlS8/view?usp=sharing

Steve


>
> On Thu, 15 Apr 2021 at 15:35, Steve Fiddle <ste...@gm...>
> wrote:
>
>> Good detective work James.
>>
>> Any ideas about the MP3 file (first post of this thread)? Given your
>> explanation of the OGG problem, I assume that it is a different issue.
>>
>> I'm thinking that it is probably an Audacity bug because the file appears
>> to be a valid MP3 file. On the other hand, if the MP3 is malformed (in some
>> way that I've not been able to detect), then it's rather more open to
>> opinion whether or not it is an Audacity bug, or a bug in the application
>> that created it.
>>
>> Steve
>>
>> On Thu, 15 Apr 2021 at 13:43, James Crook <jam...@gm...>
>> wrote:
>>
>>> Logged as: https://bugzilla.audacityteam.org/show_bug.cgi?id=2748
>>>
>>>
>>> On Thu, 15 Apr 2021 at 13:27, James Crook <jam...@gm...>
>>> wrote:
>>>
>>>> It's the same infinite loop as JUCE had:
>>>>
>>>>
>>>> https://forum.juce.com/t/ogg-vorbis-file-puts-juce-oggreader-in-infinite-loop/41148
>>>>
>>>> So will be fixed if we upgrade to 1.3.7 or later.
>>>>
>>>> On Thu, 15 Apr 2021 at 13:00, James Crook <jam...@gm...>
>>>> wrote:
>>>>
>>>>> On both 3.0.2 and 2.4.2 it's stuck in library file, vorbisfile.c
>>>>>
>>>>> static int _fseek64_wrap(FILE *f,ogg_int64_t off,int whence){
>>>>>   if(f==NULL)return(-1);
>>>>>   return fseek(f,off,whence);
>>>>> }
>>>>>
>>>>> 'off' and 'whence' are both zero ( SEEK_SET ==0, SEEK_CUR==1,
>>>>> SEEK_END==2).  We're compiled 32 bit on windows.  Anyone know if it hangs
>>>>> on mac/linux (compiled 64 bit) too?
>>>>>
>>>>> --James.
>>>>>
>>>>>
>>>>> On Thu, 15 Apr 2021 at 12:31, James Crook <jam...@gm...>
>>>>> wrote:
>>>>>
>>>>>> Confirmed freezes for me on Windows.
>>>>>>
>>>>>> On Thu, 15 Apr 2021 at 12:20, Steve Fiddle <ste...@gm...>
>>>>>> wrote:
>>>>>>
>>>>>>> And by "coincidence" (?), a problem reported importing this ogg file:
>>>>>>>
>>>>>>> https://upload.wikimedia.org/wikipedia/commons/0/0f/Claude_Debussy_-_Premi%C3%A8re_Arabesque_-_Patrizia_Prati.ogg
>>>>>>>
>>>>>>> As with the MP3 file, it can be imported if you select the
>>>>>>> "FFmpeg-compatible files" filter, but in this case, using Audacity's native
>>>>>>> OGG importer causes Audacity to freeze on both Windows and Linux (not
>>>>>>> tested on macOS).
>>>>>>>
>>>>>>> I don't like coincidences as they may be indicating a deeper problem.
>>>>>>>
>>>>>>> Steve
>>>>>>>
>>>>>>> On Thu, 15 Apr 2021 at 12:01, Steve Fiddle <ste...@gm...>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> I've tested the attached file with multiple tools in Linux and it
>>>>>>>> appears to be perfectly formed, yet Audacity still complains that it is
>>>>>>>> malformed and refuses to import it.
>>>>>>>>
>>>>>>>> Steve
>>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> audacity-devel mailing list
>>>>>>> aud...@li...
>>>>>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>>>>>
>>>>>> _______________________________________________
>>> audacity-devel mailing list
>>> aud...@li...
>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>
>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Re: [Audacity-devel] "Perfect" MP3 fails to import

[James C. <jam...@gm...>]

Your first message never made it to this list (I just checked the archive).
What's the link for the mp3?

On Thu, 15 Apr 2021 at 15:35, Steve Fiddle <ste...@gm...> wrote:

> Good detective work James.
>
> Any ideas about the MP3 file (first post of this thread)? Given your
> explanation of the OGG problem, I assume that it is a different issue.
>
> I'm thinking that it is probably an Audacity bug because the file appears
> to be a valid MP3 file. On the other hand, if the MP3 is malformed (in some
> way that I've not been able to detect), then it's rather more open to
> opinion whether or not it is an Audacity bug, or a bug in the application
> that created it.
>
> Steve
>
> On Thu, 15 Apr 2021 at 13:43, James Crook <jam...@gm...> wrote:
>
>> Logged as: https://bugzilla.audacityteam.org/show_bug.cgi?id=2748
>>
>>
>> On Thu, 15 Apr 2021 at 13:27, James Crook <jam...@gm...>
>> wrote:
>>
>>> It's the same infinite loop as JUCE had:
>>>
>>>
>>> https://forum.juce.com/t/ogg-vorbis-file-puts-juce-oggreader-in-infinite-loop/41148
>>>
>>> So will be fixed if we upgrade to 1.3.7 or later.
>>>
>>> On Thu, 15 Apr 2021 at 13:00, James Crook <jam...@gm...>
>>> wrote:
>>>
>>>> On both 3.0.2 and 2.4.2 it's stuck in library file, vorbisfile.c
>>>>
>>>> static int _fseek64_wrap(FILE *f,ogg_int64_t off,int whence){
>>>>   if(f==NULL)return(-1);
>>>>   return fseek(f,off,whence);
>>>> }
>>>>
>>>> 'off' and 'whence' are both zero ( SEEK_SET ==0, SEEK_CUR==1,
>>>> SEEK_END==2).  We're compiled 32 bit on windows.  Anyone know if it hangs
>>>> on mac/linux (compiled 64 bit) too?
>>>>
>>>> --James.
>>>>
>>>>
>>>> On Thu, 15 Apr 2021 at 12:31, James Crook <jam...@gm...>
>>>> wrote:
>>>>
>>>>> Confirmed freezes for me on Windows.
>>>>>
>>>>> On Thu, 15 Apr 2021 at 12:20, Steve Fiddle <ste...@gm...>
>>>>> wrote:
>>>>>
>>>>>> And by "coincidence" (?), a problem reported importing this ogg file:
>>>>>>
>>>>>> https://upload.wikimedia.org/wikipedia/commons/0/0f/Claude_Debussy_-_Premi%C3%A8re_Arabesque_-_Patrizia_Prati.ogg
>>>>>>
>>>>>> As with the MP3 file, it can be imported if you select the
>>>>>> "FFmpeg-compatible files" filter, but in this case, using Audacity's native
>>>>>> OGG importer causes Audacity to freeze on both Windows and Linux (not
>>>>>> tested on macOS).
>>>>>>
>>>>>> I don't like coincidences as they may be indicating a deeper problem.
>>>>>>
>>>>>> Steve
>>>>>>
>>>>>> On Thu, 15 Apr 2021 at 12:01, Steve Fiddle <ste...@gm...>
>>>>>> wrote:
>>>>>>
>>>>>>> I've tested the attached file with multiple tools in Linux and it
>>>>>>> appears to be perfectly formed, yet Audacity still complains that it is
>>>>>>> malformed and refuses to import it.
>>>>>>>
>>>>>>> Steve
>>>>>>>
>>>>>> _______________________________________________
>>>>>> audacity-devel mailing list
>>>>>> aud...@li...
>>>>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>>>>
>>>>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Re: [Audacity-devel] "Perfect" MP3 fails to import

[Steve F. <ste...@gm...>]

Good detective work James.

Any ideas about the MP3 file (first post of this thread)? Given your
explanation of the OGG problem, I assume that it is a different issue.

I'm thinking that it is probably an Audacity bug because the file appears
to be a valid MP3 file. On the other hand, if the MP3 is malformed (in some
way that I've not been able to detect), then it's rather more open to
opinion whether or not it is an Audacity bug, or a bug in the application
that created it.

Steve

On Thu, 15 Apr 2021 at 13:43, James Crook <jam...@gm...> wrote:

> Logged as: https://bugzilla.audacityteam.org/show_bug.cgi?id=2748
>
>
> On Thu, 15 Apr 2021 at 13:27, James Crook <jam...@gm...> wrote:
>
>> It's the same infinite loop as JUCE had:
>>
>>
>> https://forum.juce.com/t/ogg-vorbis-file-puts-juce-oggreader-in-infinite-loop/41148
>>
>> So will be fixed if we upgrade to 1.3.7 or later.
>>
>> On Thu, 15 Apr 2021 at 13:00, James Crook <jam...@gm...>
>> wrote:
>>
>>> On both 3.0.2 and 2.4.2 it's stuck in library file, vorbisfile.c
>>>
>>> static int _fseek64_wrap(FILE *f,ogg_int64_t off,int whence){
>>>   if(f==NULL)return(-1);
>>>   return fseek(f,off,whence);
>>> }
>>>
>>> 'off' and 'whence' are both zero ( SEEK_SET ==0, SEEK_CUR==1,
>>> SEEK_END==2).  We're compiled 32 bit on windows.  Anyone know if it hangs
>>> on mac/linux (compiled 64 bit) too?
>>>
>>> --James.
>>>
>>>
>>> On Thu, 15 Apr 2021 at 12:31, James Crook <jam...@gm...>
>>> wrote:
>>>
>>>> Confirmed freezes for me on Windows.
>>>>
>>>> On Thu, 15 Apr 2021 at 12:20, Steve Fiddle <ste...@gm...>
>>>> wrote:
>>>>
>>>>> And by "coincidence" (?), a problem reported importing this ogg file:
>>>>>
>>>>> https://upload.wikimedia.org/wikipedia/commons/0/0f/Claude_Debussy_-_Premi%C3%A8re_Arabesque_-_Patrizia_Prati.ogg
>>>>>
>>>>> As with the MP3 file, it can be imported if you select the
>>>>> "FFmpeg-compatible files" filter, but in this case, using Audacity's native
>>>>> OGG importer causes Audacity to freeze on both Windows and Linux (not
>>>>> tested on macOS).
>>>>>
>>>>> I don't like coincidences as they may be indicating a deeper problem.
>>>>>
>>>>> Steve
>>>>>
>>>>> On Thu, 15 Apr 2021 at 12:01, Steve Fiddle <ste...@gm...>
>>>>> wrote:
>>>>>
>>>>>> I've tested the attached file with multiple tools in Linux and it
>>>>>> appears to be perfectly formed, yet Audacity still complains that it is
>>>>>> malformed and refuses to import it.
>>>>>>
>>>>>> Steve
>>>>>>
>>>>> _______________________________________________
>>>>> audacity-devel mailing list
>>>>> aud...@li...
>>>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>>>
>>>> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Re: [Audacity-devel] "Perfect" MP3 fails to import

[James C. <jam...@gm...>]

Logged as: https://bugzilla.audacityteam.org/show_bug.cgi?id=2748


On Thu, 15 Apr 2021 at 13:27, James Crook <jam...@gm...> wrote:

> It's the same infinite loop as JUCE had:
>
>
> https://forum.juce.com/t/ogg-vorbis-file-puts-juce-oggreader-in-infinite-loop/41148
>
> So will be fixed if we upgrade to 1.3.7 or later.
>
> On Thu, 15 Apr 2021 at 13:00, James Crook <jam...@gm...> wrote:
>
>> On both 3.0.2 and 2.4.2 it's stuck in library file, vorbisfile.c
>>
>> static int _fseek64_wrap(FILE *f,ogg_int64_t off,int whence){
>>   if(f==NULL)return(-1);
>>   return fseek(f,off,whence);
>> }
>>
>> 'off' and 'whence' are both zero ( SEEK_SET ==0, SEEK_CUR==1,
>> SEEK_END==2).  We're compiled 32 bit on windows.  Anyone know if it hangs
>> on mac/linux (compiled 64 bit) too?
>>
>> --James.
>>
>>
>> On Thu, 15 Apr 2021 at 12:31, James Crook <jam...@gm...>
>> wrote:
>>
>>> Confirmed freezes for me on Windows.
>>>
>>> On Thu, 15 Apr 2021 at 12:20, Steve Fiddle <ste...@gm...>
>>> wrote:
>>>
>>>> And by "coincidence" (?), a problem reported importing this ogg file:
>>>>
>>>> https://upload.wikimedia.org/wikipedia/commons/0/0f/Claude_Debussy_-_Premi%C3%A8re_Arabesque_-_Patrizia_Prati.ogg
>>>>
>>>> As with the MP3 file, it can be imported if you select the
>>>> "FFmpeg-compatible files" filter, but in this case, using Audacity's native
>>>> OGG importer causes Audacity to freeze on both Windows and Linux (not
>>>> tested on macOS).
>>>>
>>>> I don't like coincidences as they may be indicating a deeper problem.
>>>>
>>>> Steve
>>>>
>>>> On Thu, 15 Apr 2021 at 12:01, Steve Fiddle <ste...@gm...>
>>>> wrote:
>>>>
>>>>> I've tested the attached file with multiple tools in Linux and it
>>>>> appears to be perfectly formed, yet Audacity still complains that it is
>>>>> malformed and refuses to import it.
>>>>>
>>>>> Steve
>>>>>
>>>> _______________________________________________
>>>> audacity-devel mailing list
>>>> aud...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>>
>>>

Re: [Audacity-devel] "Perfect" MP3 fails to import

[James C. <jam...@gm...>]

It's the same infinite loop as JUCE had:

https://forum.juce.com/t/ogg-vorbis-file-puts-juce-oggreader-in-infinite-loop/41148

So will be fixed if we upgrade to 1.3.7 or later.

On Thu, 15 Apr 2021 at 13:00, James Crook <jam...@gm...> wrote:

> On both 3.0.2 and 2.4.2 it's stuck in library file, vorbisfile.c
>
> static int _fseek64_wrap(FILE *f,ogg_int64_t off,int whence){
>   if(f==NULL)return(-1);
>   return fseek(f,off,whence);
> }
>
> 'off' and 'whence' are both zero ( SEEK_SET ==0, SEEK_CUR==1,
> SEEK_END==2).  We're compiled 32 bit on windows.  Anyone know if it hangs
> on mac/linux (compiled 64 bit) too?
>
> --James.
>
>
> On Thu, 15 Apr 2021 at 12:31, James Crook <jam...@gm...> wrote:
>
>> Confirmed freezes for me on Windows.
>>
>> On Thu, 15 Apr 2021 at 12:20, Steve Fiddle <ste...@gm...>
>> wrote:
>>
>>> And by "coincidence" (?), a problem reported importing this ogg file:
>>>
>>> https://upload.wikimedia.org/wikipedia/commons/0/0f/Claude_Debussy_-_Premi%C3%A8re_Arabesque_-_Patrizia_Prati.ogg
>>>
>>> As with the MP3 file, it can be imported if you select the
>>> "FFmpeg-compatible files" filter, but in this case, using Audacity's native
>>> OGG importer causes Audacity to freeze on both Windows and Linux (not
>>> tested on macOS).
>>>
>>> I don't like coincidences as they may be indicating a deeper problem.
>>>
>>> Steve
>>>
>>> On Thu, 15 Apr 2021 at 12:01, Steve Fiddle <ste...@gm...>
>>> wrote:
>>>
>>>> I've tested the attached file with multiple tools in Linux and it
>>>> appears to be perfectly formed, yet Audacity still complains that it is
>>>> malformed and refuses to import it.
>>>>
>>>> Steve
>>>>
>>> _______________________________________________
>>> audacity-devel mailing list
>>> aud...@li...
>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>
>>

Re: [Audacity-devel] "Perfect" MP3 fails to import

[James C. <jam...@gm...>]

On both 3.0.2 and 2.4.2 it's stuck in library file, vorbisfile.c

static int _fseek64_wrap(FILE *f,ogg_int64_t off,int whence){
  if(f==NULL)return(-1);
  return fseek(f,off,whence);
}

'off' and 'whence' are both zero ( SEEK_SET ==0, SEEK_CUR==1,
SEEK_END==2).  We're compiled 32 bit on windows.  Anyone know if it hangs
on mac/linux (compiled 64 bit) too?

--James.


On Thu, 15 Apr 2021 at 12:31, James Crook <jam...@gm...> wrote:

> Confirmed freezes for me on Windows.
>
> On Thu, 15 Apr 2021 at 12:20, Steve Fiddle <ste...@gm...>
> wrote:
>
>> And by "coincidence" (?), a problem reported importing this ogg file:
>>
>> https://upload.wikimedia.org/wikipedia/commons/0/0f/Claude_Debussy_-_Premi%C3%A8re_Arabesque_-_Patrizia_Prati.ogg
>>
>> As with the MP3 file, it can be imported if you select the
>> "FFmpeg-compatible files" filter, but in this case, using Audacity's native
>> OGG importer causes Audacity to freeze on both Windows and Linux (not
>> tested on macOS).
>>
>> I don't like coincidences as they may be indicating a deeper problem.
>>
>> Steve
>>
>> On Thu, 15 Apr 2021 at 12:01, Steve Fiddle <ste...@gm...>
>> wrote:
>>
>>> I've tested the attached file with multiple tools in Linux and it
>>> appears to be perfectly formed, yet Audacity still complains that it is
>>> malformed and refuses to import it.
>>>
>>> Steve
>>>
>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
>

Re: [Audacity-devel] "Perfect" MP3 fails to import

[James C. <jam...@gm...>]

Confirmed freezes for me on Windows.

On Thu, 15 Apr 2021 at 12:20, Steve Fiddle <ste...@gm...> wrote:

> And by "coincidence" (?), a problem reported importing this ogg file:
>
> https://upload.wikimedia.org/wikipedia/commons/0/0f/Claude_Debussy_-_Premi%C3%A8re_Arabesque_-_Patrizia_Prati.ogg
>
> As with the MP3 file, it can be imported if you select the
> "FFmpeg-compatible files" filter, but in this case, using Audacity's native
> OGG importer causes Audacity to freeze on both Windows and Linux (not
> tested on macOS).
>
> I don't like coincidences as they may be indicating a deeper problem.
>
> Steve
>
> On Thu, 15 Apr 2021 at 12:01, Steve Fiddle <ste...@gm...>
> wrote:
>
>> I've tested the attached file with multiple tools in Linux and it appears
>> to be perfectly formed, yet Audacity still complains that it is malformed
>> and refuses to import it.
>>
>> Steve
>>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Re: [Audacity-devel] "Perfect" MP3 fails to import

[Steve F. <ste...@gm...>]

And by "coincidence" (?), a problem reported importing this ogg file:
https://upload.wikimedia.org/wikipedia/commons/0/0f/Claude_Debussy_-_Premi%C3%A8re_Arabesque_-_Patrizia_Prati.ogg

As with the MP3 file, it can be imported if you select the
"FFmpeg-compatible files" filter, but in this case, using Audacity's native
OGG importer causes Audacity to freeze on both Windows and Linux (not
tested on macOS).

I don't like coincidences as they may be indicating a deeper problem.

Steve

On Thu, 15 Apr 2021 at 12:01, Steve Fiddle <ste...@gm...> wrote:

> I've tested the attached file with multiple tools in Linux and it appears
> to be perfectly formed, yet Audacity still complains that it is malformed
> and refuses to import it.
>
> Steve
>

Re: [Audacity-devel] Audacity 3.0.1 RC02 (for testing only)

[Peter S. <pet...@gm...>]

I have been testing RC02 on Win and Mac - and all seems good

1) Downloads/installs/runs OK
2) basic record and play OK
3) all EGATS present and correct
4) Manual present and correct with EXE and DMG - (properly) missing on ZIP
5) testing during bug tests - dark corners like Macros and LOF files
6) Speed tests
7) long duration recordings - just let it run for a bit

all seems OK

No 2700 observed

Peter.



On Wed, Apr 14, 2021 at 12:48 PM James Crook <jam...@gm...>
wrote:

> I mean 3.0.2 RC02 :-)
>
> On Wed, 14 Apr 2021 at 10:51, James Crook <jam...@gm...> wrote:
>
>> RC02 is now up on fosshub:
>> https://www.fosshub.com/Audacity-devel.html
>>
>> This has the fix for slow closing.
>>
>> We have a number of P2s logged now, but the good things in 3.0.1 that
>> should get out to users outweigh the currently known P2s.
>>
>> --James.
>>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Re: [Audacity-devel] Compilation fails on 3.0.0 if ffmpeg disabled

[James C. <jam...@gm...>]

It looks fine and more understandable and compiles fine for me on Windows
(MSVC 2017).
--James.

On Wed, 14 Apr 2021 at 22:32, Jack L. <xxj...@gm...> wrote:

> Got another compile error trying to compile with llvm 11.0.1. This fixes
> it, can you confirm if this is the right fix?
>
> On Wed, Apr 14, 2021 at 5:39 AM Peter Sampson <
> pet...@gm...> wrote:
>
>>
>>
>> On Wed, Apr 14, 2021 at 1:29 PM Jack L. <xxj...@gm...> wrote:
>>
>>> 2742 is fixed with the latest Leland fix.
>>>
>>
>> Thanks for that report - I've closed the bug on the basis of your testing.
>>
>> Many thanks for that - much appreciated   😎
>>
>> Peter.
>>
>>
>>
>>> On Tue, Apr 13, 2021 at 2:50 AM James Crook <jam...@gm...>
>>> wrote:
>>> >
>>> > 2742 combines two reports from Jack, and I think, yes is QUICKFIXED,
>>> but please wait for Jack to confirm so.  The miracle of it compileth may
>>> not be the full story of 2742.
>>> >
>>> > --James.
>>> >
>>> > On Tue, 13 Apr 2021 at 10:21, Peter Sampson <
>>> pet...@gm...> wrote:
>>> >>
>>> >>
>>> >>
>>> >> On Tue, Apr 13, 2021 at 6:27 AM Jack L. <xxj...@gm...> wrote:
>>> >>>
>>> >>> It compileths with ffmpeg on or off, miracle!
>>> >>
>>> >>
>>> >> @James:
>>> >>
>>> >> Does that mean that this bug is RESOLVED QUICKFIXED ?
>>> >> Bug 2742 - FreeBSD Compilation issues
>>> >>
>>> >> Peter.
>>> >>
>>> >>
>>> >>>
>>> >>> On Mon, Apr 12, 2021 at 9:04 PM Leland <ll...@ho...> wrote:
>>> >>> >
>>> >>> > Okay Jack, pull down the updates and trying building again.
>>> >>> >
>>> >>> > > -----Original Message-----
>>> >>> > > From: Jack L. <xxj...@gm...>
>>> >>> > > Sent: Monday, April 12, 2021 8:46 PM
>>> >>> > > To: Audacity-Devel list <aud...@li...>
>>> >>> > > Subject: Re: [Audacity-devel] Compilation fails on 3.0.0 if
>>> ffmpeg
>>> >>> > disabled
>>> >>> > >
>>> >>> > > Was trying to make a patch when I realized that the problem is
>>> not as
>>> >>> > simple
>>> >>> > > as originally thought. In the case if we disable ffmpeg
>>> >>> > >
>>> >>> > > src/FFmpeg.h only #include <errno.h> if we are #if
>>> defined(USE_FFMPEG) but
>>> >>> > > we should be #include <errno.h> regardless for
>>> src/widgets/FileConfig.cpp
>>> >>> > >
>>> >>> > > In src/import/Import.cpp, we are calling ffmpeg functions but
>>> they aren't
>>> >>> > > available since everything in FFmpeg.h is wrapped around an #if
>>> >>> > > defined(USE_FFMPEG)
>>> >>> > >
>>> >>> > > Thoughts?
>>> >>> > >
>>> >>> > > On Mon, Apr 12, 2021 at 3:53 PM James Crook <
>>> jam...@gm...>
>>> >>> > > wrote:
>>> >>> > > >
>>> >>> > > > Then put git and github on your learning list for a future
>>> date, and
>>> >>> > just
>>> >>> > > propose patches instead.
>>> >>> > > > We have some traditional people here who still understand
>>> patches :-)
>>> >>> > > >
>>> >>> > > > --James.
>>> >>> > > >
>>> >>> > > > On Mon, 12 Apr 2021 at 20:18, Jack L. <xxj...@gm...>
>>> wrote:
>>> >>> > > >>
>>> >>> > > >> How do i do that? New to git
>>> >>> > > >>
>>> >>> > > >> On Mon, Apr 12, 2021 at 7:58 AM James Crook
>>> >>> > > <jam...@gm...> wrote:
>>> >>> > > >> >
>>> >>> > > >> > So - We WILL be doing an RC02 for other reasons.
>>> >>> > > >> >
>>> >>> > > >> > Jack could you make a pull request for the two compilation
>>> issues for
>>> >>> > > FreeBSD, and that way we can get them into RC02?
>>> >>> > > >> >
>>> >>> > > >> > --James.
>>> >>> > > >> >
>>> >>> > > >> > On Mon, 12 Apr 2021 at 11:33, James Crook <
>>> jam...@gm...>
>>> >>> > > wrote:
>>> >>> > > >> >>
>>> >>> > > >> >> Thanks.
>>> >>> > > >> >>
>>> >>> > > >> >> I've added a bugzilla entry
>>> >>> > > https://bugzilla.audacityteam.org/show_bug.cgi?id=2742, P2, and
>>> we can fix
>>> >>> > > these as soon as we lift code freeze for 3.0.2 (or if we have to
>>> do
>>> >>> > another RC
>>> >>> > > for other reasons).
>>> >>> > > >> >>
>>> >>> > > >> >> --James.
>>> >>> > > >> >>
>>> >>> > > >> >>
>>> >>> > > >> >>
>>> >>> > > >> >> On Mon, 12 Apr 2021 at 05:49, Jack L. <
>>> xxj...@gm...> wrote:
>>> >>> > > >> >>>
>>> >>> > > >> >>> Looks like if compiling with
>>> >>> > > >> >>>
>>> >>> > > >> >>>  -Daudacity_use_ffmpeg:STRING=off
>>> >>> > > >> >>>
>>> >>> > > >> >>> results in a compilation failure.
>>> >>> > > >> >>>
>>> >>> > > >> >>>
>>> >>> > > >> >>> [1/142] cd
>>> >>> > > >> >>>
>>> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.0
>>> >>> > > >> >>> && /usr/local/bin/cmake -D GIT=/usr/local/bin/git -D
>>> >>> > > >> >>>
>>> _PRVDIR=/backup/obj/usr/ports/audio/audacity3/work/.build/src/pri
>>> >>> > > >> >>> vate -P
>>> >>> > > >> >>>
>>> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.0/
>>> >>> > > >> >>> cmake-proxies/cmake-modules/Version.cmake
>>> >>> > > >> >>> [2/142] /usr/bin/c++ -DAudacity_EXPORTS
>>> -DBUILDING_AUDACITY
>>> >>> > > >> >>> -DCMAKE -DHAVE_LRINT -DHAVE_LRINTF -DHAVE_MLOCK
>>> >>> > > >> >>> -DWXINTL_NO_GETTEXT_MACRO -DWXUSINGDLL -
>>> >>> > > D_FILE_OFFSET_BITS=64
>>> >>> > > >> >>> -D_THREAD_SAFE -D__WXGTK__ -Isrc/private
>>> >>> > > >> >>>
>>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> >>> > > >> >>> 0/include
>>> >>> > > >> >>>
>>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> >>> > > >> >>> 0/src
>>> >>> > > >> >>> -I/usr/local/lib/wx/include/gtk3-unicode-3.1
>>> >>> > > >> >>> -I/usr/local/include/wx-3.1
>>> >>> > > >> >>>
>>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> >>> > > >> >>> 0/lib-src/lame
>>> >>> > > >> >>>
>>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> >>> > > >> >>> 0/lib-src/portsmf/include
>>> >>> > > >> >>>
>>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> >>> > > >> >>> 0/lib-src/libnyquist
>>> >>> > > >> >>>
>>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> >>> > > >> >>> 0/lib-src/portmixer/include
>>> >>> > > >> >>>
>>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> >>> > > >> >>> 0/lib-src/libsbsms/include -isystem /usr/local/include
>>> -isystem
>>> >>> > > >> >>> /usr/local/include/opus -isystem
>>> /usr/local/include/soundtouch
>>> >>> > > >> >>> -isystem /usr/local/include/glib-2.0 -isystem
>>> >>> > > >> >>> /usr/local/lib/glib-2.0/include -isystem
>>> >>> > > >> >>> /usr/local/include/gtk-3.0 -isystem
>>> /usr/local/include/pango-1.0
>>> >>> > > >> >>> -isystem /usr/local/include/fribidi -isystem
>>> >>> > > >> >>> /usr/local/include/cairo -isystem
>>> /usr/local/include/pixman-1
>>> >>> > > >> >>> -isystem
>>> >>> > > >> >>> /usr/local/include/freetype2 -isystem
>>> /usr/local/include/libdrm
>>> >>> > > >> >>> -isystem /usr/local/include/libpng16 -isystem
>>> >>> > > >> >>> /usr/local/include/harfbuzz -isystem
>>> >>> > > >> >>> /usr/local/include/gdk-pixbuf-2.0 -isystem
>>> >>> > > >> >>> /usr/local/include/gio-unix-2.0 -isystem
>>> >>> > > >> >>> /usr/local/include/libepoll-shim -isystem
>>> >>> > > >> >>> /usr/local/include/atk-1.0 -isystem
>>> >>> > > >> >>> /usr/local/include/at-spi2-atk/2.0 -isystem
>>> >>> > > >> >>> /usr/local/include/dbus-1.0 -isystem
>>> >>> > > >> >>> /usr/local/lib/dbus-1.0/include -isystem
>>> >>> > > >> >>> /usr/local/include/at-spi-2.0 -O2 -pipe -march=westmere
>>> >>> > > >> >>> -fstack-protector-strong -fno-strict-aliasing -O2 -pipe
>>> >>> > > >> >>> -march=westmere -fstack-protector-strong
>>> -fno-strict-aliasing
>>> >>> > > >> >>> -Wno-underaligned-exception-object -Werror=return-type
>>> >>> > > >> >>> -Werror=dangling-else -Werror=return-stack-address
>>> -D_THREAD_SAFE
>>> >>> > > >> >>> -pthread -std=gnu++14 -MD -MT
>>> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o -MF
>>> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o.d -o
>>> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o -c
>>> >>> > > >> >>>
>>> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.0/
>>> >>> > > >> >>> src/import/Import.cpp
>>> >>> > > >> >>> FAILED: src/CMakeFiles/Audacity.dir/import/Import.cpp.o
>>> >>> > > >> >>> /usr/bin/c++ -DAudacity_EXPORTS -DBUILDING_AUDACITY
>>> -DCMAKE
>>> >>> > > >> >>> -DHAVE_LRINT -DHAVE_LRINTF -DHAVE_MLOCK -
>>> >>> > > DWXINTL_NO_GETTEXT_MACRO
>>> >>> > > >> >>> -DWXUSINGDLL -D_FILE_OFFSET_BITS=64 -D_THREAD_SAFE -
>>> >>> > > D__WXGTK__
>>> >>> > > >> >>> -Isrc/private
>>> >>> > > >> >>>
>>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> >>> > > >> >>> 0/include
>>> >>> > > >> >>>
>>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> >>> > > >> >>> 0/src
>>> >>> > > >> >>> -I/usr/local/lib/wx/include/gtk3-unicode-3.1
>>> >>> > > >> >>> -I/usr/local/include/wx-3.1
>>> >>> > > >> >>>
>>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> >>> > > >> >>> 0/lib-src/lame
>>> >>> > > >> >>>
>>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> >>> > > >> >>> 0/lib-src/portsmf/include
>>> >>> > > >> >>>
>>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> >>> > > >> >>> 0/lib-src/libnyquist
>>> >>> > > >> >>>
>>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> >>> > > >> >>> 0/lib-src/portmixer/include
>>> >>> > > >> >>>
>>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> >>> > > >> >>> 0/lib-src/libsbsms/include -isystem /usr/local/include
>>> -isystem
>>> >>> > > >> >>> /usr/local/include/opus -isystem
>>> /usr/local/include/soundtouch
>>> >>> > > >> >>> -isystem /usr/local/include/glib-2.0 -isystem
>>> >>> > > >> >>> /usr/local/lib/glib-2.0/include -isystem
>>> >>> > > >> >>> /usr/local/include/gtk-3.0 -isystem
>>> /usr/local/include/pango-1.0
>>> >>> > > >> >>> -isystem /usr/local/include/fribidi -isystem
>>> >>> > > >> >>> /usr/local/include/cairo -isystem
>>> /usr/local/include/pixman-1
>>> >>> > > >> >>> -isystem
>>> >>> > > >> >>> /usr/local/include/freetype2 -isystem
>>> /usr/local/include/libdrm
>>> >>> > > >> >>> -isystem /usr/local/include/libpng16 -isystem
>>> >>> > > >> >>> /usr/local/include/harfbuzz -isystem
>>> >>> > > >> >>> /usr/local/include/gdk-pixbuf-2.0 -isystem
>>> >>> > > >> >>> /usr/local/include/gio-unix-2.0 -isystem
>>> >>> > > >> >>> /usr/local/include/libepoll-shim -isystem
>>> >>> > > >> >>> /usr/local/include/atk-1.0 -isystem
>>> >>> > > >> >>> /usr/local/include/at-spi2-atk/2.0 -isystem
>>> >>> > > >> >>> /usr/local/include/dbus-1.0 -isystem
>>> >>> > > >> >>> /usr/local/lib/dbus-1.0/include -isystem
>>> >>> > > >> >>> /usr/local/include/at-spi-2.0 -O2 -pipe -march=westmere
>>> >>> > > >> >>> -fstack-protector-strong -fno-strict-aliasing -O2 -pipe
>>> >>> > > >> >>> -march=westmere -fstack-protector-strong
>>> -fno-strict-aliasing
>>> >>> > > >> >>> -Wno-underaligned-exception-object -Werror=return-type
>>> >>> > > >> >>> -Werror=dangling-else -Werror=return-stack-address
>>> -D_THREAD_SAFE
>>> >>> > > >> >>> -pthread -std=gnu++14 -MD -MT
>>> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o -MF
>>> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o.d -o
>>> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o -c
>>> >>> > > >> >>>
>>> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.0/
>>> >>> > > >> >>> src/import/Import.cpp
>>> >>> > > >> >>>
>>> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-
>>> >>> > > 3.0.0/src/import/Import.cpp:806:20:
>>> >>> > > >> >>> error: use of undeclared identifier 'FFmpegLibsInst'
>>> >>> > > >> >>>                   !FFmpegLibsInst()
>>> >>> > > >> >>>                    ^
>>> >>> > > >> >>> 1 error generated.
>>> >>> > > >> >>> ninja: build stopped: subcommand failed.
>>> >>> > > >> >>> *** Error code 1
>>> >>> > > >> >>>
>>> >>> > > >> >>> Stop.
>>> >>> > > >> >>>
>>> >>> > > >> >>>
>>> >>> > > >> >>> _______________________________________________
>>> >>> > > >> >>> audacity-devel mailing list
>>> >>> > > >> >>> aud...@li...
>>> >>> > > >> >>>
>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>> >>> > > >> >
>>> >>> > > >> > _______________________________________________
>>> >>> > > >> > audacity-devel mailing list
>>> >>> > > >> > aud...@li...
>>> >>> > > >> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>> >>> > > >>
>>> >>> > > >>
>>> >>> > > >> _______________________________________________
>>> >>> > > >> audacity-devel mailing list
>>> >>> > > >> aud...@li...
>>> >>> > > >> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>> >>> > > >
>>> >>> > > > _______________________________________________
>>> >>> > > > audacity-devel mailing list
>>> >>> > > > aud...@li...
>>> >>> > > > https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>> >>> > >
>>> >>> > >
>>> >>> > > _______________________________________________
>>> >>> > > audacity-devel mailing list
>>> >>> > > aud...@li...
>>> >>> > > https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>> >>> >
>>> >>> >
>>> >>> >
>>> >>> > _______________________________________________
>>> >>> > audacity-devel mailing list
>>> >>> > aud...@li...
>>> >>> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>> >>>
>>> >>>
>>> >>> _______________________________________________
>>> >>> audacity-devel mailing list
>>> >>> aud...@li...
>>> >>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>> >>
>>> >> _______________________________________________
>>> >> audacity-devel mailing list
>>> >> aud...@li...
>>> >> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>> >
>>> > _______________________________________________
>>> > audacity-devel mailing list
>>> > aud...@li...
>>> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>
>>>
>>> _______________________________________________
>>> audacity-devel mailing list
>>> aud...@li...
>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>
>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Re: [Audacity-devel] Compilation fails on 3.0.0 if ffmpeg disabled

[Jack L. <xxj...@gm...>]

Got another compile error trying to compile with llvm 11.0.1. This fixes
it, can you confirm if this is the right fix?

On Wed, Apr 14, 2021 at 5:39 AM Peter Sampson <
pet...@gm...> wrote:

>
>
> On Wed, Apr 14, 2021 at 1:29 PM Jack L. <xxj...@gm...> wrote:
>
>> 2742 is fixed with the latest Leland fix.
>>
>
> Thanks for that report - I've closed the bug on the basis of your testing.
>
> Many thanks for that - much appreciated   😎
>
> Peter.
>
>
>
>> On Tue, Apr 13, 2021 at 2:50 AM James Crook <jam...@gm...>
>> wrote:
>> >
>> > 2742 combines two reports from Jack, and I think, yes is QUICKFIXED,
>> but please wait for Jack to confirm so.  The miracle of it compileth may
>> not be the full story of 2742.
>> >
>> > --James.
>> >
>> > On Tue, 13 Apr 2021 at 10:21, Peter Sampson <
>> pet...@gm...> wrote:
>> >>
>> >>
>> >>
>> >> On Tue, Apr 13, 2021 at 6:27 AM Jack L. <xxj...@gm...> wrote:
>> >>>
>> >>> It compileths with ffmpeg on or off, miracle!
>> >>
>> >>
>> >> @James:
>> >>
>> >> Does that mean that this bug is RESOLVED QUICKFIXED ?
>> >> Bug 2742 - FreeBSD Compilation issues
>> >>
>> >> Peter.
>> >>
>> >>
>> >>>
>> >>> On Mon, Apr 12, 2021 at 9:04 PM Leland <ll...@ho...> wrote:
>> >>> >
>> >>> > Okay Jack, pull down the updates and trying building again.
>> >>> >
>> >>> > > -----Original Message-----
>> >>> > > From: Jack L. <xxj...@gm...>
>> >>> > > Sent: Monday, April 12, 2021 8:46 PM
>> >>> > > To: Audacity-Devel list <aud...@li...>
>> >>> > > Subject: Re: [Audacity-devel] Compilation fails on 3.0.0 if ffmpeg
>> >>> > disabled
>> >>> > >
>> >>> > > Was trying to make a patch when I realized that the problem is
>> not as
>> >>> > simple
>> >>> > > as originally thought. In the case if we disable ffmpeg
>> >>> > >
>> >>> > > src/FFmpeg.h only #include <errno.h> if we are #if
>> defined(USE_FFMPEG) but
>> >>> > > we should be #include <errno.h> regardless for
>> src/widgets/FileConfig.cpp
>> >>> > >
>> >>> > > In src/import/Import.cpp, we are calling ffmpeg functions but
>> they aren't
>> >>> > > available since everything in FFmpeg.h is wrapped around an #if
>> >>> > > defined(USE_FFMPEG)
>> >>> > >
>> >>> > > Thoughts?
>> >>> > >
>> >>> > > On Mon, Apr 12, 2021 at 3:53 PM James Crook <
>> jam...@gm...>
>> >>> > > wrote:
>> >>> > > >
>> >>> > > > Then put git and github on your learning list for a future
>> date, and
>> >>> > just
>> >>> > > propose patches instead.
>> >>> > > > We have some traditional people here who still understand
>> patches :-)
>> >>> > > >
>> >>> > > > --James.
>> >>> > > >
>> >>> > > > On Mon, 12 Apr 2021 at 20:18, Jack L. <xxj...@gm...>
>> wrote:
>> >>> > > >>
>> >>> > > >> How do i do that? New to git
>> >>> > > >>
>> >>> > > >> On Mon, Apr 12, 2021 at 7:58 AM James Crook
>> >>> > > <jam...@gm...> wrote:
>> >>> > > >> >
>> >>> > > >> > So - We WILL be doing an RC02 for other reasons.
>> >>> > > >> >
>> >>> > > >> > Jack could you make a pull request for the two compilation
>> issues for
>> >>> > > FreeBSD, and that way we can get them into RC02?
>> >>> > > >> >
>> >>> > > >> > --James.
>> >>> > > >> >
>> >>> > > >> > On Mon, 12 Apr 2021 at 11:33, James Crook <
>> jam...@gm...>
>> >>> > > wrote:
>> >>> > > >> >>
>> >>> > > >> >> Thanks.
>> >>> > > >> >>
>> >>> > > >> >> I've added a bugzilla entry
>> >>> > > https://bugzilla.audacityteam.org/show_bug.cgi?id=2742, P2, and
>> we can fix
>> >>> > > these as soon as we lift code freeze for 3.0.2 (or if we have to
>> do
>> >>> > another RC
>> >>> > > for other reasons).
>> >>> > > >> >>
>> >>> > > >> >> --James.
>> >>> > > >> >>
>> >>> > > >> >>
>> >>> > > >> >>
>> >>> > > >> >> On Mon, 12 Apr 2021 at 05:49, Jack L. <xxj...@gm...>
>> wrote:
>> >>> > > >> >>>
>> >>> > > >> >>> Looks like if compiling with
>> >>> > > >> >>>
>> >>> > > >> >>>  -Daudacity_use_ffmpeg:STRING=off
>> >>> > > >> >>>
>> >>> > > >> >>> results in a compilation failure.
>> >>> > > >> >>>
>> >>> > > >> >>>
>> >>> > > >> >>> [1/142] cd
>> >>> > > >> >>>
>> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.0
>> >>> > > >> >>> && /usr/local/bin/cmake -D GIT=/usr/local/bin/git -D
>> >>> > > >> >>>
>> _PRVDIR=/backup/obj/usr/ports/audio/audacity3/work/.build/src/pri
>> >>> > > >> >>> vate -P
>> >>> > > >> >>>
>> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.0/
>> >>> > > >> >>> cmake-proxies/cmake-modules/Version.cmake
>> >>> > > >> >>> [2/142] /usr/bin/c++ -DAudacity_EXPORTS -DBUILDING_AUDACITY
>> >>> > > >> >>> -DCMAKE -DHAVE_LRINT -DHAVE_LRINTF -DHAVE_MLOCK
>> >>> > > >> >>> -DWXINTL_NO_GETTEXT_MACRO -DWXUSINGDLL -
>> >>> > > D_FILE_OFFSET_BITS=64
>> >>> > > >> >>> -D_THREAD_SAFE -D__WXGTK__ -Isrc/private
>> >>> > > >> >>>
>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>> >>> > > >> >>> 0/include
>> >>> > > >> >>>
>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>> >>> > > >> >>> 0/src
>> >>> > > >> >>> -I/usr/local/lib/wx/include/gtk3-unicode-3.1
>> >>> > > >> >>> -I/usr/local/include/wx-3.1
>> >>> > > >> >>>
>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>> >>> > > >> >>> 0/lib-src/lame
>> >>> > > >> >>>
>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>> >>> > > >> >>> 0/lib-src/portsmf/include
>> >>> > > >> >>>
>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>> >>> > > >> >>> 0/lib-src/libnyquist
>> >>> > > >> >>>
>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>> >>> > > >> >>> 0/lib-src/portmixer/include
>> >>> > > >> >>>
>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>> >>> > > >> >>> 0/lib-src/libsbsms/include -isystem /usr/local/include
>> -isystem
>> >>> > > >> >>> /usr/local/include/opus -isystem
>> /usr/local/include/soundtouch
>> >>> > > >> >>> -isystem /usr/local/include/glib-2.0 -isystem
>> >>> > > >> >>> /usr/local/lib/glib-2.0/include -isystem
>> >>> > > >> >>> /usr/local/include/gtk-3.0 -isystem
>> /usr/local/include/pango-1.0
>> >>> > > >> >>> -isystem /usr/local/include/fribidi -isystem
>> >>> > > >> >>> /usr/local/include/cairo -isystem
>> /usr/local/include/pixman-1
>> >>> > > >> >>> -isystem
>> >>> > > >> >>> /usr/local/include/freetype2 -isystem
>> /usr/local/include/libdrm
>> >>> > > >> >>> -isystem /usr/local/include/libpng16 -isystem
>> >>> > > >> >>> /usr/local/include/harfbuzz -isystem
>> >>> > > >> >>> /usr/local/include/gdk-pixbuf-2.0 -isystem
>> >>> > > >> >>> /usr/local/include/gio-unix-2.0 -isystem
>> >>> > > >> >>> /usr/local/include/libepoll-shim -isystem
>> >>> > > >> >>> /usr/local/include/atk-1.0 -isystem
>> >>> > > >> >>> /usr/local/include/at-spi2-atk/2.0 -isystem
>> >>> > > >> >>> /usr/local/include/dbus-1.0 -isystem
>> >>> > > >> >>> /usr/local/lib/dbus-1.0/include -isystem
>> >>> > > >> >>> /usr/local/include/at-spi-2.0 -O2 -pipe -march=westmere
>> >>> > > >> >>> -fstack-protector-strong -fno-strict-aliasing -O2 -pipe
>> >>> > > >> >>> -march=westmere -fstack-protector-strong
>> -fno-strict-aliasing
>> >>> > > >> >>> -Wno-underaligned-exception-object -Werror=return-type
>> >>> > > >> >>> -Werror=dangling-else -Werror=return-stack-address
>> -D_THREAD_SAFE
>> >>> > > >> >>> -pthread -std=gnu++14 -MD -MT
>> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o -MF
>> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o.d -o
>> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o -c
>> >>> > > >> >>>
>> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.0/
>> >>> > > >> >>> src/import/Import.cpp
>> >>> > > >> >>> FAILED: src/CMakeFiles/Audacity.dir/import/Import.cpp.o
>> >>> > > >> >>> /usr/bin/c++ -DAudacity_EXPORTS -DBUILDING_AUDACITY -DCMAKE
>> >>> > > >> >>> -DHAVE_LRINT -DHAVE_LRINTF -DHAVE_MLOCK -
>> >>> > > DWXINTL_NO_GETTEXT_MACRO
>> >>> > > >> >>> -DWXUSINGDLL -D_FILE_OFFSET_BITS=64 -D_THREAD_SAFE -
>> >>> > > D__WXGTK__
>> >>> > > >> >>> -Isrc/private
>> >>> > > >> >>>
>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>> >>> > > >> >>> 0/include
>> >>> > > >> >>>
>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>> >>> > > >> >>> 0/src
>> >>> > > >> >>> -I/usr/local/lib/wx/include/gtk3-unicode-3.1
>> >>> > > >> >>> -I/usr/local/include/wx-3.1
>> >>> > > >> >>>
>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>> >>> > > >> >>> 0/lib-src/lame
>> >>> > > >> >>>
>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>> >>> > > >> >>> 0/lib-src/portsmf/include
>> >>> > > >> >>>
>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>> >>> > > >> >>> 0/lib-src/libnyquist
>> >>> > > >> >>>
>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>> >>> > > >> >>> 0/lib-src/portmixer/include
>> >>> > > >> >>>
>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>> >>> > > >> >>> 0/lib-src/libsbsms/include -isystem /usr/local/include
>> -isystem
>> >>> > > >> >>> /usr/local/include/opus -isystem
>> /usr/local/include/soundtouch
>> >>> > > >> >>> -isystem /usr/local/include/glib-2.0 -isystem
>> >>> > > >> >>> /usr/local/lib/glib-2.0/include -isystem
>> >>> > > >> >>> /usr/local/include/gtk-3.0 -isystem
>> /usr/local/include/pango-1.0
>> >>> > > >> >>> -isystem /usr/local/include/fribidi -isystem
>> >>> > > >> >>> /usr/local/include/cairo -isystem
>> /usr/local/include/pixman-1
>> >>> > > >> >>> -isystem
>> >>> > > >> >>> /usr/local/include/freetype2 -isystem
>> /usr/local/include/libdrm
>> >>> > > >> >>> -isystem /usr/local/include/libpng16 -isystem
>> >>> > > >> >>> /usr/local/include/harfbuzz -isystem
>> >>> > > >> >>> /usr/local/include/gdk-pixbuf-2.0 -isystem
>> >>> > > >> >>> /usr/local/include/gio-unix-2.0 -isystem
>> >>> > > >> >>> /usr/local/include/libepoll-shim -isystem
>> >>> > > >> >>> /usr/local/include/atk-1.0 -isystem
>> >>> > > >> >>> /usr/local/include/at-spi2-atk/2.0 -isystem
>> >>> > > >> >>> /usr/local/include/dbus-1.0 -isystem
>> >>> > > >> >>> /usr/local/lib/dbus-1.0/include -isystem
>> >>> > > >> >>> /usr/local/include/at-spi-2.0 -O2 -pipe -march=westmere
>> >>> > > >> >>> -fstack-protector-strong -fno-strict-aliasing -O2 -pipe
>> >>> > > >> >>> -march=westmere -fstack-protector-strong
>> -fno-strict-aliasing
>> >>> > > >> >>> -Wno-underaligned-exception-object -Werror=return-type
>> >>> > > >> >>> -Werror=dangling-else -Werror=return-stack-address
>> -D_THREAD_SAFE
>> >>> > > >> >>> -pthread -std=gnu++14 -MD -MT
>> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o -MF
>> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o.d -o
>> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o -c
>> >>> > > >> >>>
>> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.0/
>> >>> > > >> >>> src/import/Import.cpp
>> >>> > > >> >>> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-
>> >>> > > 3.0.0/src/import/Import.cpp:806:20:
>> >>> > > >> >>> error: use of undeclared identifier 'FFmpegLibsInst'
>> >>> > > >> >>>                   !FFmpegLibsInst()
>> >>> > > >> >>>                    ^
>> >>> > > >> >>> 1 error generated.
>> >>> > > >> >>> ninja: build stopped: subcommand failed.
>> >>> > > >> >>> *** Error code 1
>> >>> > > >> >>>
>> >>> > > >> >>> Stop.
>> >>> > > >> >>>
>> >>> > > >> >>>
>> >>> > > >> >>> _______________________________________________
>> >>> > > >> >>> audacity-devel mailing list
>> >>> > > >> >>> aud...@li...
>> >>> > > >> >>>
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>> >>> > > >> >
>> >>> > > >> > _______________________________________________
>> >>> > > >> > audacity-devel mailing list
>> >>> > > >> > aud...@li...
>> >>> > > >> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
>> >>> > > >>
>> >>> > > >>
>> >>> > > >> _______________________________________________
>> >>> > > >> audacity-devel mailing list
>> >>> > > >> aud...@li...
>> >>> > > >> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>> >>> > > >
>> >>> > > > _______________________________________________
>> >>> > > > audacity-devel mailing list
>> >>> > > > aud...@li...
>> >>> > > > https://lists.sourceforge.net/lists/listinfo/audacity-devel
>> >>> > >
>> >>> > >
>> >>> > > _______________________________________________
>> >>> > > audacity-devel mailing list
>> >>> > > aud...@li...
>> >>> > > https://lists.sourceforge.net/lists/listinfo/audacity-devel
>> >>> >
>> >>> >
>> >>> >
>> >>> > _______________________________________________
>> >>> > audacity-devel mailing list
>> >>> > aud...@li...
>> >>> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
>> >>>
>> >>>
>> >>> _______________________________________________
>> >>> audacity-devel mailing list
>> >>> aud...@li...
>> >>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>> >>
>> >> _______________________________________________
>> >> audacity-devel mailing list
>> >> aud...@li...
>> >> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>> >
>> > _______________________________________________
>> > audacity-devel mailing list
>> > aud...@li...
>> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
>>
>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Re: [Audacity-devel] How to locate a commit?

[John C. <jc...@gm...>]

Well, that just shows how often I use sync-lock. 😉

Can they be switched ?

On Tue, Apr 13, 2021 at 10:15 AM Peter Sampson <
pet...@gm...> wrote:

>
>
> On Tue, Apr 13, 2021 at 12:27 PM John Colket <jc...@gm...> wrote:
>
>> Peter,
>>
>>   Before you do, also add "Move (or extend) the Select button over to the
>> right."
>>
>
> You can't do that John - because that little square to the right is the
> real-estate
> for the Sync-Lock icon.
>
> [image: image.png]
>
>
> Peter.
>
>
>
>> - John
>>
>> On Tue, Apr 13, 2021 at 6:56 AM John Colket <jc...@gm...> wrote:
>>
>>> Thanks Poke,
>>>
>>>    That is what I was looking for....
>>>
>>> - John
>>>
>>> On Mon, Apr 12, 2021 at 3:02 PM Pokechu22 <
>>> pok...@gm...> wrote:
>>>
>>>> The fastest way to locate a commit is to use git bisect, as it
>>>> requires you to check a logarithmic number of commits (so for 1000 commits,
>>>> you only need to check 10 or so of them).  It can be a bit complicated to
>>>> get started with, but https://git-scm.com/docs/git-bisect-lk2009 is a
>>>> pretty helpful guide.
>>>>
>>>> --Poke
>>>>
>>>> On Mon, Apr 12, 2021 at 11:55 AM John Colket <jc...@gm...> wrote:
>>>>
>>>>> James,
>>>>>
>>>>> I would like to say that I'm glad you asked that question ☺ - but
>>>>> actually I'm not. 😉
>>>>>
>>>>> Well anyway, since you asked, some users have ended up unknowingly
>>>>> screwing up their project by accidentally bumping the track and/or pan
>>>>> controls whilst editing their projects.  So I have been looking into this.
>>>>>
>>>>> Peter has written up a proposal to address this issue.  I am sure you
>>>>> are aware of it.  See here:
>>>>> https://wiki.audacityteam.org/wiki/Proposal_Locking_and/or_Hiding_Pan_and_Gain_sliders
>>>>>
>>>>> Personally, I believe most of the suggestions are overkill, with the
>>>>> exceptions of the Visual Cues; I have written up my own thoughts on the
>>>>> adjoining Discussion page for that proposal.
>>>>>
>>>>> But here is what I was trying to look into.  There was a very, very
>>>>> subtle change between 2.4.2, and 3.0.0, that perhaps has gone unnoticed.
>>>>> That is when the cursor is drawn off of the Pan slider in a downward
>>>>> direction, that the highlight on its control remains. This in my view is a
>>>>> regression on 2.4.2, makes the visual cues just a little bit poorer, and
>>>>> makes the whole issue just a teensy bit harder to tackle.
>>>>>
>>>>> - John
>>>>>
>>>>> On Mon, Apr 12, 2021 at 12:40 PM James Crook <jam...@gm...>
>>>>> wrote:
>>>>>
>>>>>> If the artifacts are expired, you only have FossHub old audacity,
>>>>>> https://www.fosshub.com/Audacity-devel-old.html for prebuilts.  So
>>>>>> you're back to building them yourself - if they were not changes around
>>>>>> release candidate time.
>>>>>>
>>>>>> Which behaviour change are you hoping to track down?
>>>>>>
>>>>>> --James.
>>>>>>
>>>>>> On Mon, 12 Apr 2021 at 17:05, John Colket <jc...@gm...> wrote:
>>>>>>
>>>>>>> James,
>>>>>>>
>>>>>>> I would like to search for an unknown commit that changed a certain
>>>>>>> behavior between 2.4.2 and 3.0.0.  So the Artifacts are by now
>>>>>>> well-expired.  Is there any way to travel in the "way back machine" so I
>>>>>>> can do a binary search ?
>>>>>>>
>>>>>>> - John
>>>>>>>
>>>>>> _______________________________________________
>>>>> audacity-devel mailing list
>>>>> aud...@li...
>>>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>>>
>>>> _______________________________________________
>>>> audacity-devel mailing list
>>>> aud...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>>
>>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Re: [Audacity-devel] How to locate a commit?

[John C. <jc...@gm...>]

So the proposal would be that the locations of these two buttons be
switched. Would the Audacity community still survive ?

And we really need to move this discussion elsewhere, before we get
booted. 😉

- John

On Tue, Apr 13, 2021 at 11:21 AM Peter Sampson <
pet...@gm...> wrote:

>
>
> On Tue, Apr 13, 2021 at 4:13 PM John Colket <jc...@gm...> wrote:
>
>> Well, that just shows how often I use sync-lock. 😉
>>
>>
> I used it a LOT when transcribing my vinyl - to keep the labels in the
> label track
> in sync with edits I made in the audio track - very useful it was.
>
>
> Can they be switched ?
>>
>
> I'm not sure what you mean but I'm guessing no anyway 😉
>
> Peter.
>
>
>
>> On Tue, Apr 13, 2021 at 10:15 AM Peter Sampson <
>> pet...@gm...> wrote:
>>
>>>
>>>
>>> On Tue, Apr 13, 2021 at 12:27 PM John Colket <jc...@gm...> wrote:
>>>
>>>> Peter,
>>>>
>>>>   Before you do, also add "Move (or extend) the Select button over to
>>>> the right."
>>>>
>>>
>>> You can't do that John - because that little square to the right is the
>>> real-estate
>>> for the Sync-Lock icon.
>>>
>>> [image: image.png]
>>>
>>>
>>> Peter.
>>>
>>>
>>>
>>>> - John
>>>>
>>>> On Tue, Apr 13, 2021 at 6:56 AM John Colket <jc...@gm...> wrote:
>>>>
>>>>> Thanks Poke,
>>>>>
>>>>>    That is what I was looking for....
>>>>>
>>>>> - John
>>>>>
>>>>> On Mon, Apr 12, 2021 at 3:02 PM Pokechu22 <
>>>>> pok...@gm...> wrote:
>>>>>
>>>>>> The fastest way to locate a commit is to use git bisect, as it
>>>>>> requires you to check a logarithmic number of commits (so for 1000 commits,
>>>>>> you only need to check 10 or so of them).  It can be a bit complicated to
>>>>>> get started with, but https://git-scm.com/docs/git-bisect-lk2009 is
>>>>>> a pretty helpful guide.
>>>>>>
>>>>>> --Poke
>>>>>>
>>>>>> On Mon, Apr 12, 2021 at 11:55 AM John Colket <jc...@gm...>
>>>>>> wrote:
>>>>>>
>>>>>>> James,
>>>>>>>
>>>>>>> I would like to say that I'm glad you asked that question ☺ - but
>>>>>>> actually I'm not. 😉
>>>>>>>
>>>>>>> Well anyway, since you asked, some users have ended up unknowingly
>>>>>>> screwing up their project by accidentally bumping the track and/or pan
>>>>>>> controls whilst editing their projects.  So I have been looking into this.
>>>>>>>
>>>>>>> Peter has written up a proposal to address this issue.  I am sure
>>>>>>> you are aware of it.  See here:
>>>>>>> https://wiki.audacityteam.org/wiki/Proposal_Locking_and/or_Hiding_Pan_and_Gain_sliders
>>>>>>>
>>>>>>> Personally, I believe most of the suggestions are overkill, with the
>>>>>>> exceptions of the Visual Cues; I have written up my own thoughts on the
>>>>>>> adjoining Discussion page for that proposal.
>>>>>>>
>>>>>>> But here is what I was trying to look into.  There was a very, very
>>>>>>> subtle change between 2.4.2, and 3.0.0, that perhaps has gone unnoticed.
>>>>>>> That is when the cursor is drawn off of the Pan slider in a downward
>>>>>>> direction, that the highlight on its control remains. This in my view is a
>>>>>>> regression on 2.4.2, makes the visual cues just a little bit poorer, and
>>>>>>> makes the whole issue just a teensy bit harder to tackle.
>>>>>>>
>>>>>>> - John
>>>>>>>
>>>>>>> On Mon, Apr 12, 2021 at 12:40 PM James Crook <
>>>>>>> jam...@gm...> wrote:
>>>>>>>
>>>>>>>> If the artifacts are expired, you only have FossHub old audacity,
>>>>>>>> https://www.fosshub.com/Audacity-devel-old.html for prebuilts.  So
>>>>>>>> you're back to building them yourself - if they were not changes around
>>>>>>>> release candidate time.
>>>>>>>>
>>>>>>>> Which behaviour change are you hoping to track down?
>>>>>>>>
>>>>>>>> --James.
>>>>>>>>
>>>>>>>> On Mon, 12 Apr 2021 at 17:05, John Colket <jc...@gm...>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> James,
>>>>>>>>>
>>>>>>>>> I would like to search for an unknown commit that changed a
>>>>>>>>> certain behavior between 2.4.2 and 3.0.0.  So the Artifacts are by now
>>>>>>>>> well-expired.  Is there any way to travel in the "way back machine" so I
>>>>>>>>> can do a binary search ?
>>>>>>>>>
>>>>>>>>> - John
>>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>> audacity-devel mailing list
>>>>>>> aud...@li...
>>>>>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>>>>>
>>>>>> _______________________________________________
>>>>>> audacity-devel mailing list
>>>>>> aud...@li...
>>>>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>>>>
>>>>> _______________________________________________
>>>> audacity-devel mailing list
>>>> aud...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>>
>>> _______________________________________________
>>> audacity-devel mailing list
>>> aud...@li...
>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>
>>

Re: [Audacity-devel] How to locate a commit?

[Peter S. <pet...@gm...>]

On Tue, Apr 13, 2021 at 4:13 PM John Colket <jc...@gm...> wrote:

> Well, that just shows how often I use sync-lock. 😉
>
>
I used it a LOT when transcribing my vinyl - to keep the labels in the
label track
in sync with edits I made in the audio track - very useful it was.


Can they be switched ?
>

I'm not sure what you mean but I'm guessing no anyway 😉

Peter.



> On Tue, Apr 13, 2021 at 10:15 AM Peter Sampson <
> pet...@gm...> wrote:
>
>>
>>
>> On Tue, Apr 13, 2021 at 12:27 PM John Colket <jc...@gm...> wrote:
>>
>>> Peter,
>>>
>>>   Before you do, also add "Move (or extend) the Select button over to
>>> the right."
>>>
>>
>> You can't do that John - because that little square to the right is the
>> real-estate
>> for the Sync-Lock icon.
>>
>> [image: image.png]
>>
>>
>> Peter.
>>
>>
>>
>>> - John
>>>
>>> On Tue, Apr 13, 2021 at 6:56 AM John Colket <jc...@gm...> wrote:
>>>
>>>> Thanks Poke,
>>>>
>>>>    That is what I was looking for....
>>>>
>>>> - John
>>>>
>>>> On Mon, Apr 12, 2021 at 3:02 PM Pokechu22 <
>>>> pok...@gm...> wrote:
>>>>
>>>>> The fastest way to locate a commit is to use git bisect, as it
>>>>> requires you to check a logarithmic number of commits (so for 1000 commits,
>>>>> you only need to check 10 or so of them).  It can be a bit complicated to
>>>>> get started with, but https://git-scm.com/docs/git-bisect-lk2009 is a
>>>>> pretty helpful guide.
>>>>>
>>>>> --Poke
>>>>>
>>>>> On Mon, Apr 12, 2021 at 11:55 AM John Colket <jc...@gm...>
>>>>> wrote:
>>>>>
>>>>>> James,
>>>>>>
>>>>>> I would like to say that I'm glad you asked that question ☺ - but
>>>>>> actually I'm not. 😉
>>>>>>
>>>>>> Well anyway, since you asked, some users have ended up unknowingly
>>>>>> screwing up their project by accidentally bumping the track and/or pan
>>>>>> controls whilst editing their projects.  So I have been looking into this.
>>>>>>
>>>>>> Peter has written up a proposal to address this issue.  I am sure you
>>>>>> are aware of it.  See here:
>>>>>> https://wiki.audacityteam.org/wiki/Proposal_Locking_and/or_Hiding_Pan_and_Gain_sliders
>>>>>>
>>>>>> Personally, I believe most of the suggestions are overkill, with the
>>>>>> exceptions of the Visual Cues; I have written up my own thoughts on the
>>>>>> adjoining Discussion page for that proposal.
>>>>>>
>>>>>> But here is what I was trying to look into.  There was a very, very
>>>>>> subtle change between 2.4.2, and 3.0.0, that perhaps has gone unnoticed.
>>>>>> That is when the cursor is drawn off of the Pan slider in a downward
>>>>>> direction, that the highlight on its control remains. This in my view is a
>>>>>> regression on 2.4.2, makes the visual cues just a little bit poorer, and
>>>>>> makes the whole issue just a teensy bit harder to tackle.
>>>>>>
>>>>>> - John
>>>>>>
>>>>>> On Mon, Apr 12, 2021 at 12:40 PM James Crook <jam...@gm...>
>>>>>> wrote:
>>>>>>
>>>>>>> If the artifacts are expired, you only have FossHub old audacity,
>>>>>>> https://www.fosshub.com/Audacity-devel-old.html for prebuilts.  So
>>>>>>> you're back to building them yourself - if they were not changes around
>>>>>>> release candidate time.
>>>>>>>
>>>>>>> Which behaviour change are you hoping to track down?
>>>>>>>
>>>>>>> --James.
>>>>>>>
>>>>>>> On Mon, 12 Apr 2021 at 17:05, John Colket <jc...@gm...> wrote:
>>>>>>>
>>>>>>>> James,
>>>>>>>>
>>>>>>>> I would like to search for an unknown commit that changed a certain
>>>>>>>> behavior between 2.4.2 and 3.0.0.  So the Artifacts are by now
>>>>>>>> well-expired.  Is there any way to travel in the "way back machine" so I
>>>>>>>> can do a binary search ?
>>>>>>>>
>>>>>>>> - John
>>>>>>>>
>>>>>>> _______________________________________________
>>>>>> audacity-devel mailing list
>>>>>> aud...@li...
>>>>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>>>>
>>>>> _______________________________________________
>>>>> audacity-devel mailing list
>>>>> aud...@li...
>>>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>>>
>>>> _______________________________________________
>>> audacity-devel mailing list
>>> aud...@li...
>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>
>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
>

Re: [Audacity-devel] Compilation fails on 3.0.0 if ffmpeg disabled

[Peter S. <pet...@gm...>]

On Wed, Apr 14, 2021 at 1:29 PM Jack L. <xxj...@gm...> wrote:

> 2742 is fixed with the latest Leland fix.
>

Thanks for that report - I've closed the bug on the basis of your testing.

Many thanks for that - much appreciated   😎

Peter.



> On Tue, Apr 13, 2021 at 2:50 AM James Crook <jam...@gm...>
> wrote:
> >
> > 2742 combines two reports from Jack, and I think, yes is QUICKFIXED, but
> please wait for Jack to confirm so.  The miracle of it compileth may not be
> the full story of 2742.
> >
> > --James.
> >
> > On Tue, 13 Apr 2021 at 10:21, Peter Sampson <
> pet...@gm...> wrote:
> >>
> >>
> >>
> >> On Tue, Apr 13, 2021 at 6:27 AM Jack L. <xxj...@gm...> wrote:
> >>>
> >>> It compileths with ffmpeg on or off, miracle!
> >>
> >>
> >> @James:
> >>
> >> Does that mean that this bug is RESOLVED QUICKFIXED ?
> >> Bug 2742 - FreeBSD Compilation issues
> >>
> >> Peter.
> >>
> >>
> >>>
> >>> On Mon, Apr 12, 2021 at 9:04 PM Leland <ll...@ho...> wrote:
> >>> >
> >>> > Okay Jack, pull down the updates and trying building again.
> >>> >
> >>> > > -----Original Message-----
> >>> > > From: Jack L. <xxj...@gm...>
> >>> > > Sent: Monday, April 12, 2021 8:46 PM
> >>> > > To: Audacity-Devel list <aud...@li...>
> >>> > > Subject: Re: [Audacity-devel] Compilation fails on 3.0.0 if ffmpeg
> >>> > disabled
> >>> > >
> >>> > > Was trying to make a patch when I realized that the problem is not
> as
> >>> > simple
> >>> > > as originally thought. In the case if we disable ffmpeg
> >>> > >
> >>> > > src/FFmpeg.h only #include <errno.h> if we are #if
> defined(USE_FFMPEG) but
> >>> > > we should be #include <errno.h> regardless for
> src/widgets/FileConfig.cpp
> >>> > >
> >>> > > In src/import/Import.cpp, we are calling ffmpeg functions but they
> aren't
> >>> > > available since everything in FFmpeg.h is wrapped around an #if
> >>> > > defined(USE_FFMPEG)
> >>> > >
> >>> > > Thoughts?
> >>> > >
> >>> > > On Mon, Apr 12, 2021 at 3:53 PM James Crook <
> jam...@gm...>
> >>> > > wrote:
> >>> > > >
> >>> > > > Then put git and github on your learning list for a future date,
> and
> >>> > just
> >>> > > propose patches instead.
> >>> > > > We have some traditional people here who still understand
> patches :-)
> >>> > > >
> >>> > > > --James.
> >>> > > >
> >>> > > > On Mon, 12 Apr 2021 at 20:18, Jack L. <xxj...@gm...>
> wrote:
> >>> > > >>
> >>> > > >> How do i do that? New to git
> >>> > > >>
> >>> > > >> On Mon, Apr 12, 2021 at 7:58 AM James Crook
> >>> > > <jam...@gm...> wrote:
> >>> > > >> >
> >>> > > >> > So - We WILL be doing an RC02 for other reasons.
> >>> > > >> >
> >>> > > >> > Jack could you make a pull request for the two compilation
> issues for
> >>> > > FreeBSD, and that way we can get them into RC02?
> >>> > > >> >
> >>> > > >> > --James.
> >>> > > >> >
> >>> > > >> > On Mon, 12 Apr 2021 at 11:33, James Crook <
> jam...@gm...>
> >>> > > wrote:
> >>> > > >> >>
> >>> > > >> >> Thanks.
> >>> > > >> >>
> >>> > > >> >> I've added a bugzilla entry
> >>> > > https://bugzilla.audacityteam.org/show_bug.cgi?id=2742, P2, and
> we can fix
> >>> > > these as soon as we lift code freeze for 3.0.2 (or if we have to do
> >>> > another RC
> >>> > > for other reasons).
> >>> > > >> >>
> >>> > > >> >> --James.
> >>> > > >> >>
> >>> > > >> >>
> >>> > > >> >>
> >>> > > >> >> On Mon, 12 Apr 2021 at 05:49, Jack L. <xxj...@gm...>
> wrote:
> >>> > > >> >>>
> >>> > > >> >>> Looks like if compiling with
> >>> > > >> >>>
> >>> > > >> >>>  -Daudacity_use_ffmpeg:STRING=off
> >>> > > >> >>>
> >>> > > >> >>> results in a compilation failure.
> >>> > > >> >>>
> >>> > > >> >>>
> >>> > > >> >>> [1/142] cd
> >>> > > >> >>>
> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.0
> >>> > > >> >>> && /usr/local/bin/cmake -D GIT=/usr/local/bin/git -D
> >>> > > >> >>>
> _PRVDIR=/backup/obj/usr/ports/audio/audacity3/work/.build/src/pri
> >>> > > >> >>> vate -P
> >>> > > >> >>>
> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.0/
> >>> > > >> >>> cmake-proxies/cmake-modules/Version.cmake
> >>> > > >> >>> [2/142] /usr/bin/c++ -DAudacity_EXPORTS -DBUILDING_AUDACITY
> >>> > > >> >>> -DCMAKE -DHAVE_LRINT -DHAVE_LRINTF -DHAVE_MLOCK
> >>> > > >> >>> -DWXINTL_NO_GETTEXT_MACRO -DWXUSINGDLL -
> >>> > > D_FILE_OFFSET_BITS=64
> >>> > > >> >>> -D_THREAD_SAFE -D__WXGTK__ -Isrc/private
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/include
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/src
> >>> > > >> >>> -I/usr/local/lib/wx/include/gtk3-unicode-3.1
> >>> > > >> >>> -I/usr/local/include/wx-3.1
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/lib-src/lame
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/lib-src/portsmf/include
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/lib-src/libnyquist
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/lib-src/portmixer/include
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/lib-src/libsbsms/include -isystem /usr/local/include
> -isystem
> >>> > > >> >>> /usr/local/include/opus -isystem
> /usr/local/include/soundtouch
> >>> > > >> >>> -isystem /usr/local/include/glib-2.0 -isystem
> >>> > > >> >>> /usr/local/lib/glib-2.0/include -isystem
> >>> > > >> >>> /usr/local/include/gtk-3.0 -isystem
> /usr/local/include/pango-1.0
> >>> > > >> >>> -isystem /usr/local/include/fribidi -isystem
> >>> > > >> >>> /usr/local/include/cairo -isystem
> /usr/local/include/pixman-1
> >>> > > >> >>> -isystem
> >>> > > >> >>> /usr/local/include/freetype2 -isystem
> /usr/local/include/libdrm
> >>> > > >> >>> -isystem /usr/local/include/libpng16 -isystem
> >>> > > >> >>> /usr/local/include/harfbuzz -isystem
> >>> > > >> >>> /usr/local/include/gdk-pixbuf-2.0 -isystem
> >>> > > >> >>> /usr/local/include/gio-unix-2.0 -isystem
> >>> > > >> >>> /usr/local/include/libepoll-shim -isystem
> >>> > > >> >>> /usr/local/include/atk-1.0 -isystem
> >>> > > >> >>> /usr/local/include/at-spi2-atk/2.0 -isystem
> >>> > > >> >>> /usr/local/include/dbus-1.0 -isystem
> >>> > > >> >>> /usr/local/lib/dbus-1.0/include -isystem
> >>> > > >> >>> /usr/local/include/at-spi-2.0 -O2 -pipe -march=westmere
> >>> > > >> >>> -fstack-protector-strong -fno-strict-aliasing -O2 -pipe
> >>> > > >> >>> -march=westmere -fstack-protector-strong
> -fno-strict-aliasing
> >>> > > >> >>> -Wno-underaligned-exception-object -Werror=return-type
> >>> > > >> >>> -Werror=dangling-else -Werror=return-stack-address
> -D_THREAD_SAFE
> >>> > > >> >>> -pthread -std=gnu++14 -MD -MT
> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o -MF
> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o.d -o
> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o -c
> >>> > > >> >>>
> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.0/
> >>> > > >> >>> src/import/Import.cpp
> >>> > > >> >>> FAILED: src/CMakeFiles/Audacity.dir/import/Import.cpp.o
> >>> > > >> >>> /usr/bin/c++ -DAudacity_EXPORTS -DBUILDING_AUDACITY -DCMAKE
> >>> > > >> >>> -DHAVE_LRINT -DHAVE_LRINTF -DHAVE_MLOCK -
> >>> > > DWXINTL_NO_GETTEXT_MACRO
> >>> > > >> >>> -DWXUSINGDLL -D_FILE_OFFSET_BITS=64 -D_THREAD_SAFE -
> >>> > > D__WXGTK__
> >>> > > >> >>> -Isrc/private
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/include
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/src
> >>> > > >> >>> -I/usr/local/lib/wx/include/gtk3-unicode-3.1
> >>> > > >> >>> -I/usr/local/include/wx-3.1
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/lib-src/lame
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/lib-src/portsmf/include
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/lib-src/libnyquist
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/lib-src/portmixer/include
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/lib-src/libsbsms/include -isystem /usr/local/include
> -isystem
> >>> > > >> >>> /usr/local/include/opus -isystem
> /usr/local/include/soundtouch
> >>> > > >> >>> -isystem /usr/local/include/glib-2.0 -isystem
> >>> > > >> >>> /usr/local/lib/glib-2.0/include -isystem
> >>> > > >> >>> /usr/local/include/gtk-3.0 -isystem
> /usr/local/include/pango-1.0
> >>> > > >> >>> -isystem /usr/local/include/fribidi -isystem
> >>> > > >> >>> /usr/local/include/cairo -isystem
> /usr/local/include/pixman-1
> >>> > > >> >>> -isystem
> >>> > > >> >>> /usr/local/include/freetype2 -isystem
> /usr/local/include/libdrm
> >>> > > >> >>> -isystem /usr/local/include/libpng16 -isystem
> >>> > > >> >>> /usr/local/include/harfbuzz -isystem
> >>> > > >> >>> /usr/local/include/gdk-pixbuf-2.0 -isystem
> >>> > > >> >>> /usr/local/include/gio-unix-2.0 -isystem
> >>> > > >> >>> /usr/local/include/libepoll-shim -isystem
> >>> > > >> >>> /usr/local/include/atk-1.0 -isystem
> >>> > > >> >>> /usr/local/include/at-spi2-atk/2.0 -isystem
> >>> > > >> >>> /usr/local/include/dbus-1.0 -isystem
> >>> > > >> >>> /usr/local/lib/dbus-1.0/include -isystem
> >>> > > >> >>> /usr/local/include/at-spi-2.0 -O2 -pipe -march=westmere
> >>> > > >> >>> -fstack-protector-strong -fno-strict-aliasing -O2 -pipe
> >>> > > >> >>> -march=westmere -fstack-protector-strong
> -fno-strict-aliasing
> >>> > > >> >>> -Wno-underaligned-exception-object -Werror=return-type
> >>> > > >> >>> -Werror=dangling-else -Werror=return-stack-address
> -D_THREAD_SAFE
> >>> > > >> >>> -pthread -std=gnu++14 -MD -MT
> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o -MF
> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o.d -o
> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o -c
> >>> > > >> >>>
> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.0/
> >>> > > >> >>> src/import/Import.cpp
> >>> > > >> >>> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-
> >>> > > 3.0.0/src/import/Import.cpp:806:20:
> >>> > > >> >>> error: use of undeclared identifier 'FFmpegLibsInst'
> >>> > > >> >>>                   !FFmpegLibsInst()
> >>> > > >> >>>                    ^
> >>> > > >> >>> 1 error generated.
> >>> > > >> >>> ninja: build stopped: subcommand failed.
> >>> > > >> >>> *** Error code 1
> >>> > > >> >>>
> >>> > > >> >>> Stop.
> >>> > > >> >>>
> >>> > > >> >>>
> >>> > > >> >>> _______________________________________________
> >>> > > >> >>> audacity-devel mailing list
> >>> > > >> >>> aud...@li...
> >>> > > >> >>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
> >>> > > >> >
> >>> > > >> > _______________________________________________
> >>> > > >> > audacity-devel mailing list
> >>> > > >> > aud...@li...
> >>> > > >> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
> >>> > > >>
> >>> > > >>
> >>> > > >> _______________________________________________
> >>> > > >> audacity-devel mailing list
> >>> > > >> aud...@li...
> >>> > > >> https://lists.sourceforge.net/lists/listinfo/audacity-devel
> >>> > > >
> >>> > > > _______________________________________________
> >>> > > > audacity-devel mailing list
> >>> > > > aud...@li...
> >>> > > > https://lists.sourceforge.net/lists/listinfo/audacity-devel
> >>> > >
> >>> > >
> >>> > > _______________________________________________
> >>> > > audacity-devel mailing list
> >>> > > aud...@li...
> >>> > > https://lists.sourceforge.net/lists/listinfo/audacity-devel
> >>> >
> >>> >
> >>> >
> >>> > _______________________________________________
> >>> > audacity-devel mailing list
> >>> > aud...@li...
> >>> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
> >>>
> >>>
> >>> _______________________________________________
> >>> audacity-devel mailing list
> >>> aud...@li...
> >>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
> >>
> >> _______________________________________________
> >> audacity-devel mailing list
> >> aud...@li...
> >> https://lists.sourceforge.net/lists/listinfo/audacity-devel
> >
> > _______________________________________________
> > audacity-devel mailing list
> > aud...@li...
> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Re: [Audacity-devel] Compilation fails on 3.0.0 if ffmpeg disabled

[Jack L. <xxj...@gm...>]

2742 is fixed with the latest Leland fix.

On Tue, Apr 13, 2021 at 2:50 AM James Crook <jam...@gm...> wrote:
>
> 2742 combines two reports from Jack, and I think, yes is QUICKFIXED, but please wait for Jack to confirm so.  The miracle of it compileth may not be the full story of 2742.
>
> --James.
>
> On Tue, 13 Apr 2021 at 10:21, Peter Sampson <pet...@gm...> wrote:
>>
>>
>>
>> On Tue, Apr 13, 2021 at 6:27 AM Jack L. <xxj...@gm...> wrote:
>>>
>>> It compileths with ffmpeg on or off, miracle!
>>
>>
>> @James:
>>
>> Does that mean that this bug is RESOLVED QUICKFIXED ?
>> Bug 2742 - FreeBSD Compilation issues
>>
>> Peter.
>>
>>
>>>
>>> On Mon, Apr 12, 2021 at 9:04 PM Leland <ll...@ho...> wrote:
>>> >
>>> > Okay Jack, pull down the updates and trying building again.
>>> >
>>> > > -----Original Message-----
>>> > > From: Jack L. <xxj...@gm...>
>>> > > Sent: Monday, April 12, 2021 8:46 PM
>>> > > To: Audacity-Devel list <aud...@li...>
>>> > > Subject: Re: [Audacity-devel] Compilation fails on 3.0.0 if ffmpeg
>>> > disabled
>>> > >
>>> > > Was trying to make a patch when I realized that the problem is not as
>>> > simple
>>> > > as originally thought. In the case if we disable ffmpeg
>>> > >
>>> > > src/FFmpeg.h only #include <errno.h> if we are #if defined(USE_FFMPEG) but
>>> > > we should be #include <errno.h> regardless for src/widgets/FileConfig.cpp
>>> > >
>>> > > In src/import/Import.cpp, we are calling ffmpeg functions but they aren't
>>> > > available since everything in FFmpeg.h is wrapped around an #if
>>> > > defined(USE_FFMPEG)
>>> > >
>>> > > Thoughts?
>>> > >
>>> > > On Mon, Apr 12, 2021 at 3:53 PM James Crook <jam...@gm...>
>>> > > wrote:
>>> > > >
>>> > > > Then put git and github on your learning list for a future date, and
>>> > just
>>> > > propose patches instead.
>>> > > > We have some traditional people here who still understand patches :-)
>>> > > >
>>> > > > --James.
>>> > > >
>>> > > > On Mon, 12 Apr 2021 at 20:18, Jack L. <xxj...@gm...> wrote:
>>> > > >>
>>> > > >> How do i do that? New to git
>>> > > >>
>>> > > >> On Mon, Apr 12, 2021 at 7:58 AM James Crook
>>> > > <jam...@gm...> wrote:
>>> > > >> >
>>> > > >> > So - We WILL be doing an RC02 for other reasons.
>>> > > >> >
>>> > > >> > Jack could you make a pull request for the two compilation issues for
>>> > > FreeBSD, and that way we can get them into RC02?
>>> > > >> >
>>> > > >> > --James.
>>> > > >> >
>>> > > >> > On Mon, 12 Apr 2021 at 11:33, James Crook <jam...@gm...>
>>> > > wrote:
>>> > > >> >>
>>> > > >> >> Thanks.
>>> > > >> >>
>>> > > >> >> I've added a bugzilla entry
>>> > > https://bugzilla.audacityteam.org/show_bug.cgi?id=2742, P2, and we can fix
>>> > > these as soon as we lift code freeze for 3.0.2 (or if we have to do
>>> > another RC
>>> > > for other reasons).
>>> > > >> >>
>>> > > >> >> --James.
>>> > > >> >>
>>> > > >> >>
>>> > > >> >>
>>> > > >> >> On Mon, 12 Apr 2021 at 05:49, Jack L. <xxj...@gm...> wrote:
>>> > > >> >>>
>>> > > >> >>> Looks like if compiling with
>>> > > >> >>>
>>> > > >> >>>  -Daudacity_use_ffmpeg:STRING=off
>>> > > >> >>>
>>> > > >> >>> results in a compilation failure.
>>> > > >> >>>
>>> > > >> >>>
>>> > > >> >>> [1/142] cd
>>> > > >> >>> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.0
>>> > > >> >>> && /usr/local/bin/cmake -D GIT=/usr/local/bin/git -D
>>> > > >> >>> _PRVDIR=/backup/obj/usr/ports/audio/audacity3/work/.build/src/pri
>>> > > >> >>> vate -P
>>> > > >> >>> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.0/
>>> > > >> >>> cmake-proxies/cmake-modules/Version.cmake
>>> > > >> >>> [2/142] /usr/bin/c++ -DAudacity_EXPORTS -DBUILDING_AUDACITY
>>> > > >> >>> -DCMAKE -DHAVE_LRINT -DHAVE_LRINTF -DHAVE_MLOCK
>>> > > >> >>> -DWXINTL_NO_GETTEXT_MACRO -DWXUSINGDLL -
>>> > > D_FILE_OFFSET_BITS=64
>>> > > >> >>> -D_THREAD_SAFE -D__WXGTK__ -Isrc/private
>>> > > >> >>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> > > >> >>> 0/include
>>> > > >> >>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> > > >> >>> 0/src
>>> > > >> >>> -I/usr/local/lib/wx/include/gtk3-unicode-3.1
>>> > > >> >>> -I/usr/local/include/wx-3.1
>>> > > >> >>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> > > >> >>> 0/lib-src/lame
>>> > > >> >>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> > > >> >>> 0/lib-src/portsmf/include
>>> > > >> >>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> > > >> >>> 0/lib-src/libnyquist
>>> > > >> >>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> > > >> >>> 0/lib-src/portmixer/include
>>> > > >> >>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> > > >> >>> 0/lib-src/libsbsms/include -isystem /usr/local/include -isystem
>>> > > >> >>> /usr/local/include/opus -isystem /usr/local/include/soundtouch
>>> > > >> >>> -isystem /usr/local/include/glib-2.0 -isystem
>>> > > >> >>> /usr/local/lib/glib-2.0/include -isystem
>>> > > >> >>> /usr/local/include/gtk-3.0 -isystem /usr/local/include/pango-1.0
>>> > > >> >>> -isystem /usr/local/include/fribidi -isystem
>>> > > >> >>> /usr/local/include/cairo -isystem /usr/local/include/pixman-1
>>> > > >> >>> -isystem
>>> > > >> >>> /usr/local/include/freetype2 -isystem /usr/local/include/libdrm
>>> > > >> >>> -isystem /usr/local/include/libpng16 -isystem
>>> > > >> >>> /usr/local/include/harfbuzz -isystem
>>> > > >> >>> /usr/local/include/gdk-pixbuf-2.0 -isystem
>>> > > >> >>> /usr/local/include/gio-unix-2.0 -isystem
>>> > > >> >>> /usr/local/include/libepoll-shim -isystem
>>> > > >> >>> /usr/local/include/atk-1.0 -isystem
>>> > > >> >>> /usr/local/include/at-spi2-atk/2.0 -isystem
>>> > > >> >>> /usr/local/include/dbus-1.0 -isystem
>>> > > >> >>> /usr/local/lib/dbus-1.0/include -isystem
>>> > > >> >>> /usr/local/include/at-spi-2.0 -O2 -pipe -march=westmere
>>> > > >> >>> -fstack-protector-strong -fno-strict-aliasing -O2 -pipe
>>> > > >> >>> -march=westmere -fstack-protector-strong -fno-strict-aliasing
>>> > > >> >>> -Wno-underaligned-exception-object -Werror=return-type
>>> > > >> >>> -Werror=dangling-else -Werror=return-stack-address -D_THREAD_SAFE
>>> > > >> >>> -pthread -std=gnu++14 -MD -MT
>>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o -MF
>>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o.d -o
>>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o -c
>>> > > >> >>> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.0/
>>> > > >> >>> src/import/Import.cpp
>>> > > >> >>> FAILED: src/CMakeFiles/Audacity.dir/import/Import.cpp.o
>>> > > >> >>> /usr/bin/c++ -DAudacity_EXPORTS -DBUILDING_AUDACITY -DCMAKE
>>> > > >> >>> -DHAVE_LRINT -DHAVE_LRINTF -DHAVE_MLOCK -
>>> > > DWXINTL_NO_GETTEXT_MACRO
>>> > > >> >>> -DWXUSINGDLL -D_FILE_OFFSET_BITS=64 -D_THREAD_SAFE -
>>> > > D__WXGTK__
>>> > > >> >>> -Isrc/private
>>> > > >> >>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> > > >> >>> 0/include
>>> > > >> >>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> > > >> >>> 0/src
>>> > > >> >>> -I/usr/local/lib/wx/include/gtk3-unicode-3.1
>>> > > >> >>> -I/usr/local/include/wx-3.1
>>> > > >> >>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> > > >> >>> 0/lib-src/lame
>>> > > >> >>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> > > >> >>> 0/lib-src/portsmf/include
>>> > > >> >>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> > > >> >>> 0/lib-src/libnyquist
>>> > > >> >>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> > > >> >>> 0/lib-src/portmixer/include
>>> > > >> >>> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
>>> > > >> >>> 0/lib-src/libsbsms/include -isystem /usr/local/include -isystem
>>> > > >> >>> /usr/local/include/opus -isystem /usr/local/include/soundtouch
>>> > > >> >>> -isystem /usr/local/include/glib-2.0 -isystem
>>> > > >> >>> /usr/local/lib/glib-2.0/include -isystem
>>> > > >> >>> /usr/local/include/gtk-3.0 -isystem /usr/local/include/pango-1.0
>>> > > >> >>> -isystem /usr/local/include/fribidi -isystem
>>> > > >> >>> /usr/local/include/cairo -isystem /usr/local/include/pixman-1
>>> > > >> >>> -isystem
>>> > > >> >>> /usr/local/include/freetype2 -isystem /usr/local/include/libdrm
>>> > > >> >>> -isystem /usr/local/include/libpng16 -isystem
>>> > > >> >>> /usr/local/include/harfbuzz -isystem
>>> > > >> >>> /usr/local/include/gdk-pixbuf-2.0 -isystem
>>> > > >> >>> /usr/local/include/gio-unix-2.0 -isystem
>>> > > >> >>> /usr/local/include/libepoll-shim -isystem
>>> > > >> >>> /usr/local/include/atk-1.0 -isystem
>>> > > >> >>> /usr/local/include/at-spi2-atk/2.0 -isystem
>>> > > >> >>> /usr/local/include/dbus-1.0 -isystem
>>> > > >> >>> /usr/local/lib/dbus-1.0/include -isystem
>>> > > >> >>> /usr/local/include/at-spi-2.0 -O2 -pipe -march=westmere
>>> > > >> >>> -fstack-protector-strong -fno-strict-aliasing -O2 -pipe
>>> > > >> >>> -march=westmere -fstack-protector-strong -fno-strict-aliasing
>>> > > >> >>> -Wno-underaligned-exception-object -Werror=return-type
>>> > > >> >>> -Werror=dangling-else -Werror=return-stack-address -D_THREAD_SAFE
>>> > > >> >>> -pthread -std=gnu++14 -MD -MT
>>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o -MF
>>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o.d -o
>>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o -c
>>> > > >> >>> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.0/
>>> > > >> >>> src/import/Import.cpp
>>> > > >> >>> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-
>>> > > 3.0.0/src/import/Import.cpp:806:20:
>>> > > >> >>> error: use of undeclared identifier 'FFmpegLibsInst'
>>> > > >> >>>                   !FFmpegLibsInst()
>>> > > >> >>>                    ^
>>> > > >> >>> 1 error generated.
>>> > > >> >>> ninja: build stopped: subcommand failed.
>>> > > >> >>> *** Error code 1
>>> > > >> >>>
>>> > > >> >>> Stop.
>>> > > >> >>>
>>> > > >> >>>
>>> > > >> >>> _______________________________________________
>>> > > >> >>> audacity-devel mailing list
>>> > > >> >>> aud...@li...
>>> > > >> >>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>> > > >> >
>>> > > >> > _______________________________________________
>>> > > >> > audacity-devel mailing list
>>> > > >> > aud...@li...
>>> > > >> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>> > > >>
>>> > > >>
>>> > > >> _______________________________________________
>>> > > >> audacity-devel mailing list
>>> > > >> aud...@li...
>>> > > >> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>> > > >
>>> > > > _______________________________________________
>>> > > > audacity-devel mailing list
>>> > > > aud...@li...
>>> > > > https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>> > >
>>> > >
>>> > > _______________________________________________
>>> > > audacity-devel mailing list
>>> > > aud...@li...
>>> > > https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>> >
>>> >
>>> >
>>> > _______________________________________________
>>> > audacity-devel mailing list
>>> > aud...@li...
>>> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>
>>>
>>> _______________________________________________
>>> audacity-devel mailing list
>>> aud...@li...
>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel

Re: [Audacity-devel] How to locate a commit?

[John C. <jc...@gm...>]

[Back on topic]

Poke,

  Thanks again for your post.  I was able to locate the commit in question
without too much difficulty.  I did not know that a clone contained that
much rich commit history. ☺

  Anyway, for those that are following the post, the commit of interest was
the fix for "Bug 2617 - Audacity not responding after switching to Envelope
tool", which makes perfect sense to me - I had noticed a lot more painting
and refreshing going on than I would have ever thought.  And I had been
looking at this code trying to understand it - but I did skip over the part
commented by the bug, and I'll have a closer look to see what is going on.

  Regardless, again, thanks for your help. ☺

- John

On Mon, Apr 12, 2021 at 3:02 PM Pokechu22 <
pok...@gm...> wrote:

> The fastest way to locate a commit is to use git bisect, as it requires
> you to check a logarithmic number of commits (so for 1000 commits, you only
> need to check 10 or so of them).  It can be a bit complicated to get
> started with, but https://git-scm.com/docs/git-bisect-lk2009 is a pretty
> helpful guide.
>
> --Poke
>
> On Mon, Apr 12, 2021 at 11:55 AM John Colket <jc...@gm...> wrote:
>
>> James,
>>
>> I would like to say that I'm glad you asked that question ☺ - but
>> actually I'm not. 😉
>>
>> Well anyway, since you asked, some users have ended up unknowingly
>> screwing up their project by accidentally bumping the track and/or pan
>> controls whilst editing their projects.  So I have been looking into this.
>>
>> Peter has written up a proposal to address this issue.  I am sure you are
>> aware of it.  See here:
>> https://wiki.audacityteam.org/wiki/Proposal_Locking_and/or_Hiding_Pan_and_Gain_sliders
>>
>> Personally, I believe most of the suggestions are overkill, with the
>> exceptions of the Visual Cues; I have written up my own thoughts on the
>> adjoining Discussion page for that proposal.
>>
>> But here is what I was trying to look into.  There was a very, very
>> subtle change between 2.4.2, and 3.0.0, that perhaps has gone unnoticed.
>> That is when the cursor is drawn off of the Pan slider in a downward
>> direction, that the highlight on its control remains. This in my view is a
>> regression on 2.4.2, makes the visual cues just a little bit poorer, and
>> makes the whole issue just a teensy bit harder to tackle.
>>
>> - John
>>
>> On Mon, Apr 12, 2021 at 12:40 PM James Crook <jam...@gm...>
>> wrote:
>>
>>> If the artifacts are expired, you only have FossHub old audacity,
>>> https://www.fosshub.com/Audacity-devel-old.html for prebuilts.  So
>>> you're back to building them yourself - if they were not changes around
>>> release candidate time.
>>>
>>> Which behaviour change are you hoping to track down?
>>>
>>> --James.
>>>
>>> On Mon, 12 Apr 2021 at 17:05, John Colket <jc...@gm...> wrote:
>>>
>>>> James,
>>>>
>>>> I would like to search for an unknown commit that changed a certain
>>>> behavior between 2.4.2 and 3.0.0.  So the Artifacts are by now
>>>> well-expired.  Is there any way to travel in the "way back machine" so I
>>>> can do a binary search ?
>>>>
>>>> - John
>>>>
>>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

[Audacity-devel] Audacity Google Summer of Code

[James C. <jam...@gm...>]

Audacity is taking part in Google Summer of Code this year.
https://summerofcode.withgoogle.com/

In "Google Summer of Code" students make proposals for projects to work on
during the summer.  Audacity provides mentors to guide.  Google coordinates
and provides a small stipend.  Earlier this year we posted our project
ideas here: https://wiki.audacityteam.org/wiki/GSoC_Ideas_2021

We're experienced with Google Summer of Code having mentored 7 students in
2008 and 2009.  The GSoC format has changed for 2021, with a shorter 175 hr
project spread over ten weeks.  We have enough potential mentors for it
this year, plus it should be less demanding on mentor time with the shorter
duration, and we thought we'd try the new format out.

The response has been just phenomenal.  We had 256 students (well, almost
exactly - it was 258 at the high water mark) in our GSoC Discord to discuss
possible projects and to get up to speed on compiling Audacity.  From this
we got 89 actual completed final proposals submitted yesterday, the
deadline for submissions.  In those 89 pdfs there are some absolutely dire
proposals, spammy proposals; students who didn't read the instructions;
students who just cut and pasted text and thought that would do.  There are
also some gems.

Deciding between these top proposals and narrowing it down to just two is
going to be really tricky.  We're balancing how good/innovative for the
project the proposals are, and how convinced we are by the proposal that
the students will be able to get good results in the time.

What next?

Student projects that are going ahead will be announced in mid May.  Once
that happens, we're planning to encourage more communication from the
students about work in progress this year than we had in 2008 and 2009.  In
2008 and 2009 we just had project pages on our wiki, which probably few
people saw.  The ideas we are considering will make a big difference for
the better for Audacity, if they come through.  We're looking forward to
sharing more about GSoC as GSoC progresses.

--James.

[Audacity-devel] Audacity 3.0.1 RC02 (for testing only)

[James C. <jam...@gm...>]

RC02 is now up on fosshub:
https://www.fosshub.com/Audacity-devel.html

This has the fix for slow closing.

We have a number of P2s logged now, but the good things in 3.0.1 that
should get out to users outweigh the currently known P2s.

--James.

Re: [Audacity-devel] Audacity 3.0.1 RC02 (for testing only)

[James C. <jam...@gm...>]

I mean 3.0.2 RC02 :-)

On Wed, 14 Apr 2021 at 10:51, James Crook <jam...@gm...> wrote:

> RC02 is now up on fosshub:
> https://www.fosshub.com/Audacity-devel.html
>
> This has the fix for slow closing.
>
> We have a number of P2s logged now, but the good things in 3.0.1 that
> should get out to users outweigh the currently known P2s.
>
> --James.
>

Re: [Audacity-devel] How to locate a commit?

[Peter S. <pet...@gm...>]

On Tue, Apr 13, 2021 at 12:27 PM John Colket <jc...@gm...> wrote:

> Peter,
>
>   Before you do, also add "Move (or extend) the Select button over to the
> right."
>

You can't do that John - because that little square to the right is the
real-estate
for the Sync-Lock icon.

[image: image.png]


Peter.



> - John
>
> On Tue, Apr 13, 2021 at 6:56 AM John Colket <jc...@gm...> wrote:
>
>> Thanks Poke,
>>
>>    That is what I was looking for....
>>
>> - John
>>
>> On Mon, Apr 12, 2021 at 3:02 PM Pokechu22 <
>> pok...@gm...> wrote:
>>
>>> The fastest way to locate a commit is to use git bisect, as it requires
>>> you to check a logarithmic number of commits (so for 1000 commits, you only
>>> need to check 10 or so of them).  It can be a bit complicated to get
>>> started with, but https://git-scm.com/docs/git-bisect-lk2009 is a
>>> pretty helpful guide.
>>>
>>> --Poke
>>>
>>> On Mon, Apr 12, 2021 at 11:55 AM John Colket <jc...@gm...> wrote:
>>>
>>>> James,
>>>>
>>>> I would like to say that I'm glad you asked that question ☺ - but
>>>> actually I'm not. 😉
>>>>
>>>> Well anyway, since you asked, some users have ended up unknowingly
>>>> screwing up their project by accidentally bumping the track and/or pan
>>>> controls whilst editing their projects.  So I have been looking into this.
>>>>
>>>> Peter has written up a proposal to address this issue.  I am sure you
>>>> are aware of it.  See here:
>>>> https://wiki.audacityteam.org/wiki/Proposal_Locking_and/or_Hiding_Pan_and_Gain_sliders
>>>>
>>>> Personally, I believe most of the suggestions are overkill, with the
>>>> exceptions of the Visual Cues; I have written up my own thoughts on the
>>>> adjoining Discussion page for that proposal.
>>>>
>>>> But here is what I was trying to look into.  There was a very, very
>>>> subtle change between 2.4.2, and 3.0.0, that perhaps has gone unnoticed.
>>>> That is when the cursor is drawn off of the Pan slider in a downward
>>>> direction, that the highlight on its control remains. This in my view is a
>>>> regression on 2.4.2, makes the visual cues just a little bit poorer, and
>>>> makes the whole issue just a teensy bit harder to tackle.
>>>>
>>>> - John
>>>>
>>>> On Mon, Apr 12, 2021 at 12:40 PM James Crook <jam...@gm...>
>>>> wrote:
>>>>
>>>>> If the artifacts are expired, you only have FossHub old audacity,
>>>>> https://www.fosshub.com/Audacity-devel-old.html for prebuilts.  So
>>>>> you're back to building them yourself - if they were not changes around
>>>>> release candidate time.
>>>>>
>>>>> Which behaviour change are you hoping to track down?
>>>>>
>>>>> --James.
>>>>>
>>>>> On Mon, 12 Apr 2021 at 17:05, John Colket <jc...@gm...> wrote:
>>>>>
>>>>>> James,
>>>>>>
>>>>>> I would like to search for an unknown commit that changed a certain
>>>>>> behavior between 2.4.2 and 3.0.0.  So the Artifacts are by now
>>>>>> well-expired.  Is there any way to travel in the "way back machine" so I
>>>>>> can do a binary search ?
>>>>>>
>>>>>> - John
>>>>>>
>>>>> _______________________________________________
>>>> audacity-devel mailing list
>>>> aud...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>>
>>> _______________________________________________
>>> audacity-devel mailing list
>>> aud...@li...
>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>
>> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Re: [Audacity-devel] [Audacity-quality] Imports slower on my Windows PC than on my Big Sur Mac

[Peter S. <pet...@gm...>]

On Tue, Apr 13, 2021 at 1:48 PM Steve Fiddle <ste...@gm...>
wrote:

>
>
> On Tue, 13 Apr 2021 at 13:22, Peter Sampson <
> pet...@gm...> wrote:
>
>> I'm totally baffled by the fact that Imports slower on my Windows PC than
>> on my Big Sur Mac
>> in some cases (WAV in particular) significantly so.
>>
>> This is a spin-off observation from the testing I did today for Bug #2745.
>> For that I made a Macro that does
>> a) 3 imports of a one-hour MP3 audio file
>> b) 3 imports of a one-hour WAV audio file
>> c) 3 imports of a one-hour AAC audio file
>> Copy of Win Macro attached
>>
>> On W10 (seconds)
>> MP3:   18.6   16.5    16.1
>> WAV:   44.5   21.7    25.1
>> AAC:   26.7   12.9    18.2
>>
>> On Mac (seconds)
>> MP3:   11.8   12.0    12.0
>> WAV:    4.8    5.0      5.2
>> AAC:    8.7    8.7      8.8
>>
>> 1) So we see WAV at an average 30 seconds on W10 versus 5 seconds on Mac
>> 2) We see AAC at an average 14 seconds on W10 versus 8.7 seconds on Mac
>> 3) We see MP3 at an average 17 seconds on W10 versus 12 seconds on Mac
>>
>> So:
>> a)  the Mac is consistently faster on the imports
>> b) but also note that while the Mac is pretty consistent,
>>     in contrast on Win the first export of a file-type seems to always be
>> the longest
>>
>> Both these machines are pretty similar in Spec:
>> Both are 2-7GZ 8GB RAM dual-core
>> Both have 256GB SSD ( Win has 60GB free, Mac has 90GB free)
>> Both are Intel processors - Win is i7 Mac is i5
>>
>> The only difference is that the Windows PC is my primary workhorse so
>> gets more work
>> Does this make the SSD more fragmented and thus slower?
>>
>
> Are you running 32-bit Audacity on 64-bit Windows?
> Perhaps there are inefficiencies in writing to the SQLite database due to
> the app being 32-bit on 64-bit hardware (?) If that's the case, then I'd
> expect a 64-bit build of Audacity to be closer to the performance that you
> see on macOS.
>

A very good call I'm thinking Steve ...

Shows the power of 64-bit Audacity on a 64-bit Win engine.

On W10 64-bit (seconds)
MP3:   12.1   12.4    12.1
WAV:   12.3   12.2    12.3

On W10 32-bit (seconds)
MP3:   18.6   16.5    16.1
WAV:   44.5   21.7    25.1

On Mac (seconds)
MP3:   11.8   12.0    12.0
WAV:    4.8    5.0      5.2

So with a 64-bit Win build we have
a) much better consistency MP3 cf. WAV
b) no first export slower
c) but Mac is still 3 times faster at importing WAV - somewhat surprisingly
d) but 12 seconds ti Import a one-hour stereo WAV would seem more than
acceptable to me.

What this *really* tells me is that awe really should not be denying our
Windows users
with 64-bit machines *(quite possibly the majority these days)* the speed
advantages
they could get with Windows 64-bit builds).

We really should be releasing 64-bit for Windows.

*And yes I know that then there's the problem with 32-bit plug-ins ...*

Peter.



> Steve
>
>
>>
>>
>> Fortunately most of our users will not notice this as most of then work
>> on just the one
>> platform so will not see X-platform timing differences.  Plus our timings
>> for 3.0.2, 3.0.0
>> and 2.4.3 are pretty consistently within good tolerance.
>>
>>
>> If anybody can cast any light on the mystery I'd be most grateful.
>>
>> Thanks,
>> Peter.
>> _______________________________________________
>> Audacity-quality mailing list
>> Aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>
>

Re: [Audacity-devel] [Audacity-quality] Imports slower on my Windows PC than on my Big Sur Mac

[Peter S. <pet...@gm...>]

BAD plan to have the Temp files on the HD and not the SSD

On W10 SM-HD (seconds) - Temp files on SM-HD
MP3:   73.2    25.3    30.1
WAV:  210.2   91.1    52.2
AAC:  125.7   92.9    82.5
But note my temp files and thus the project are on the SSD

On W10 SM-HD (seconds) - Temp files on SSD
MP3:   17.6   18.3    18.0
WAV:   17.1   12.5    15.5
AAC:   11.5   10.8    17.2
But note my temp files and thus the project are on the SSD

So MUCH slower - and thus my Temp files will be remaining on the SSD

Peter.



On Tue, Apr 13, 2021 at 2:03 PM Peter Sampson <
pet...@gm...> wrote:

>
>
> On Tue, Apr 13, 2021 at 1:48 PM Steve Fiddle <ste...@gm...>
> wrote:
>
>>
>>
>> On Tue, 13 Apr 2021 at 13:22, Peter Sampson <
>> pet...@gm...> wrote:
>>
>>> I'm totally baffled by the fact that Imports slower on my Windows PC
>>> than on my Big Sur Mac
>>> in some cases (WAV in particular) significantly so.
>>>
>>> This is a spin-off observation from the testing I did today for Bug
>>> #2745.
>>> For that I made a Macro that does
>>> a) 3 imports of a one-hour MP3 audio file
>>> b) 3 imports of a one-hour WAV audio file
>>> c) 3 imports of a one-hour AAC audio file
>>> Copy of Win Macro attached
>>>
>>> On W10 (seconds)
>>> MP3:   18.6   16.5    16.1
>>> WAV:   44.5   21.7    25.1
>>> AAC:   26.7   12.9    18.2
>>>
>>> On Mac (seconds)
>>> MP3:   11.8   12.0    12.0
>>> WAV:    4.8    5.0      5.2
>>> AAC:    8.7    8.7      8.8
>>>
>>> 1) So we see WAV at an average 30 seconds on W10 versus 5 seconds on Mac
>>> 2) We see AAC at an average 14 seconds on W10 versus 8.7 seconds on Mac
>>> 3) We see MP3 at an average 17 seconds on W10 versus 12 seconds on Mac
>>>
>>> So:
>>> a)  the Mac is consistently faster on the imports
>>> b) but also note that while the Mac is pretty consistent,
>>>     in contrast on Win the first export of a file-type seems to always
>>> be the longest
>>>
>>> Both these machines are pretty similar in Spec:
>>> Both are 2-7GZ 8GB RAM dual-core
>>> Both have 256GB SSD ( Win has 60GB free, Mac has 90GB free)
>>> Both are Intel processors - Win is i7 Mac is i5
>>>
>>> The only difference is that the Windows PC is my primary workhorse so
>>> gets more work
>>> Does this make the SSD more fragmented and thus slower?
>>>
>>
>> Are you running 32-bit Audacity on 64-bit Windows?
>>
>
> Yes of course I am running 32-bit Audacity on 64-bit Windows Home.
>
> 32-bit is what we supply and support - not 64-bit (well not yet anyway).
>
> Later I may try the 64-bit test build from Github - I will have to drop
> the AAC imports due to no 64-bit FFmpeg.
>
>
> Perhaps there are inefficiencies in writing to the SQLite database due to
>> the app being 32-bit on 64-bit hardware (?) If that's the case, then I'd
>> expect a 64-bit build of Audacity to be closer to the performance that you
>> see on macOS.
>>
>
> Interesting thought.
>
> Cheers,
> Peter.
>
>
>
>> Steve
>>
>>
>>>
>>>
>>> Fortunately most of our users will not notice this as most of then work
>>> on just the one
>>> platform so will not see X-platform timing differences.  Plus our
>>> timings for 3.0.2, 3.0.0
>>> and 2.4.3 are pretty consistently within good tolerance.
>>>
>>>
>>> If anybody can cast any light on the mystery I'd be most grateful.
>>>
>>> Thanks,
>>> Peter.
>>> _______________________________________________
>>> Audacity-quality mailing list
>>> Aud...@li...
>>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>>
>>

Re: [Audacity-devel] [Audacity-quality] Imports slower on my Windows PC than on my Big Sur Mac

[Peter S. <pet...@gm...>]

On Tue, Apr 13, 2021 at 1:48 PM Steve Fiddle <ste...@gm...>
wrote:

>
>
> On Tue, 13 Apr 2021 at 13:22, Peter Sampson <
> pet...@gm...> wrote:
>
>> I'm totally baffled by the fact that Imports slower on my Windows PC than
>> on my Big Sur Mac
>> in some cases (WAV in particular) significantly so.
>>
>> This is a spin-off observation from the testing I did today for Bug #2745.
>> For that I made a Macro that does
>> a) 3 imports of a one-hour MP3 audio file
>> b) 3 imports of a one-hour WAV audio file
>> c) 3 imports of a one-hour AAC audio file
>> Copy of Win Macro attached
>>
>> On W10 (seconds)
>> MP3:   18.6   16.5    16.1
>> WAV:   44.5   21.7    25.1
>> AAC:   26.7   12.9    18.2
>>
>> On Mac (seconds)
>> MP3:   11.8   12.0    12.0
>> WAV:    4.8    5.0      5.2
>> AAC:    8.7    8.7      8.8
>>
>> 1) So we see WAV at an average 30 seconds on W10 versus 5 seconds on Mac
>> 2) We see AAC at an average 14 seconds on W10 versus 8.7 seconds on Mac
>> 3) We see MP3 at an average 17 seconds on W10 versus 12 seconds on Mac
>>
>> So:
>> a)  the Mac is consistently faster on the imports
>> b) but also note that while the Mac is pretty consistent,
>>     in contrast on Win the first export of a file-type seems to always be
>> the longest
>>
>> Both these machines are pretty similar in Spec:
>> Both are 2-7GZ 8GB RAM dual-core
>> Both have 256GB SSD ( Win has 60GB free, Mac has 90GB free)
>> Both are Intel processors - Win is i7 Mac is i5
>>
>> The only difference is that the Windows PC is my primary workhorse so
>> gets more work
>> Does this make the SSD more fragmented and thus slower?
>>
>
> Are you running 32-bit Audacity on 64-bit Windows?
>

Yes of course I am running 32-bit Audacity on 64-bit Windows Home.

32-bit is what we supply and support - not 64-bit (well not yet anyway).

Later I may try the 64-bit test build from Github - I will have to drop the
AAC imports due to no 64-bit FFmpeg.


Perhaps there are inefficiencies in writing to the SQLite database due to
> the app being 32-bit on 64-bit hardware (?) If that's the case, then I'd
> expect a 64-bit build of Audacity to be closer to the performance that you
> see on macOS.
>

Interesting thought.

Cheers,
Peter.



> Steve
>
>
>>
>>
>> Fortunately most of our users will not notice this as most of then work
>> on just the one
>> platform so will not see X-platform timing differences.  Plus our timings
>> for 3.0.2, 3.0.0
>> and 2.4.3 are pretty consistently within good tolerance.
>>
>>
>> If anybody can cast any light on the mystery I'd be most grateful.
>>
>> Thanks,
>> Peter.
>> _______________________________________________
>> Audacity-quality mailing list
>> Aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>
>