[ZNC-commits] SF.net SVN: znc:[1617] trunk/modules/webadmin.cpp

[<ps...@us...>]

Revision: 1617
          http://znc.svn.sourceforge.net/znc/?rev=1617&view=rev
Author:   psychon
Date:     2009-09-07 18:33:02 +0000 (Mon, 07 Sep 2009)

Log Message:
-----------
webadmin: Increase buffer on HTTP sockets on the irc port

When webadmin "grabs" HTTP connections from the IRC port, it moves the
underlying connection to its own socket class and copies all of the settings
from the old socket to this new one.

One of the properties that is copied is the MaxBufferThreshold which is 1024 for
IRC sockets, but which should be 10240 webadmin sockets (CSocket::CSocket()).
This could theoretically cause bugs like the "blank page in firefox" reported by
kaiz0ku.

Anyway, this is hopefully fixed by setting the 10k MaxBufferThreshold again.

Modified Paths:
--------------
    trunk/modules/webadmin.cpp

Modified: trunk/modules/webadmin.cpp
===================================================================
--- trunk/modules/webadmin.cpp	2009-09-04 12:25:05 UTC (rev 1616)
+++ trunk/modules/webadmin.cpp	2009-09-07 18:33:02 UTC (rev 1617)
@@ -228,9 +228,11 @@
 				|| sLine.WildCmp("POST * HTTP/1.?")) {
 			CWebAdminSock* pSock = new CWebAdminSock(this);
 			CZNC::Get().GetManager().SwapSockByAddr(pSock, pClient);
-			// And don't forget to give it some sane name / timeout
+
+			// And don't forget to give it some sane settings again
 			pSock->SetSockName("WebAdmin::Client");
 			pSock->SetTimeout(120);
+			pSock->SetMaxBufferThreshold(10240);
 
 			// TODO can we somehow get rid of this?
 			pSock->ReadLine(sLine);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.