Re: [Xournal-devel] [xournal:bugs] Re: #156 Mac OS X gtk-quartz backend support

[Denis A. <au...@ma...>]

> in src/Makefile.am: remove the explicit -lX11 linking. It’s pointless as
> gtk+ will pull it in anyway if its compiled with X11 backend support
> (Linux and Mac OS X).

Ideally this should be true, but it appears that it hasn't been true on 
all Linux distributions at all points in time. It got added precisely 
because I started getting too many reports of linking errors due to 
missing -lX11. (Probably a bug, but when a major distribution has a this 
sort of bug it's easier to address it on my side than tell everyone 
their distribution is broken).

But I can always add an explicit check for the "linux" hosttype in 
configure.in to handle this case, as I agree that on non-linux platforms 
we shouldn't add it.  (If any more exotic OSes out there have the same 
issue, I'm sure their users can work it out themselves.)

> Including gdk/gdk.h pulls in gdkconfig.h which has the
> supported backend defined using macros like GDK_WINDOWING_X11,
> GDK_WINDOWING_QUARTZ, GDK_WINDOWING_WIN32 etc… Use these for your ifdefs
> blocks and you should be well on your way.

Great, thanks a lot for the idea -- I had completely forgotten about 
those macros. I'll use them for the X11-specific code (and any other 
place where a #ifndef WIN32 is really meant to stand for a #ifdef X11 -- 
some of them are really about the OS and its '\' path separators, so 
should stay in case someone compiles on an X11-based Win32 target [I'm 
told those exist]).

Thanks again,
Denis