Re: [Viking-devel] Tiles get deleted in offline mode

[Guilhem B. <gui...@gm...>]

2011/9/11 Robert Norris <rw_...@ho...>:
>
> ----------------------------------------
>> Date: Sun, 11 Sep 2011 08:51:49 +0200
>> From: gp...@mu...
>> To: vik...@li...
>> Subject: Re: [Viking-devel] Tiles get deleted in offline mode
>>
>> Hi,
>>
>> I just noticed, that this bug is back in latest git trunk.
>>
>> I already filed a bug report and it got resolved, but it seems
>> viking is now again deleting tiles if auto download map is enabled
>> and there is no connection to the internet.
>>
>> Can one of the superusers please reopen this bug
>> http://sourceforge.net/tracker/?func=detail&aid=3042692&group_id=83870&atid=570954
>>
>
> This took a while but I think I understand this now (limited by my git fu knowledge)....
>
> The offending line is in download.c at line 241:
>    g_remove ( fn ); /* couldn't create temporary. delete 0-byte file. */
>
> This was originally fixed by commit 4945e425d481ca7b9a4c6e00a8e11bff79d254a4 by Jocelyn back in 2010-09-13.
>
> *HOWEVER*, it appears that by the subsequent merging of the remote branch 'jocelyn/etag' on 2010-10-11 this somehow restores the offending line.
> [I don't quite understand how/why this line was restored but the second chunk of the patch is kept - I can't seem to track an exact commit where it actually changes!**]
>
> ** If anyone can find the exact reason / commit why this happened - please explain as I would like to understand.

git bissect drives me to commit b529dc9c00bbafad3671e76e719277d4deecddbc
Exploring history, I also conclude that it is the first commit where
the bug came back.
But I do not understand how, as git show do not display such a change.

-- 
Guilhem BONNEFILLE
-=- JID: gu...@im... MSN: gui...@ho...
-=- mailto:gui...@gm...
-=- http://nathguil.free.fr/