[UFRaw-Devel] off-by-one with --size

[Simon K. <si...@ne...>]

Hello!

I was hoping to use --size rather than calculating my own --shrink since
it does everything for me :) , but I noticed that with 20D images of raw
resolution 3522 x 2348, --size 880 actually emits 879 pixels and --size
881 actually emits 881 pixels.  D'oh!

If I hack ufraw_calculate_scale to return a lower scale factor, it works.
The problem seems to be that 3522 can't evenly divide by four, so the
rest of the calculations end up outputting 879 x 586 in this case, which
would be fine except that it ends up actually shrinking to 880 and then
resampling to 879, which makes the resulting image very soft.  --shrink 4
works and looks just fine, emitting 880 x 587.

I'm not entirely sure how this should be fixed...

For reference, if this sensor size is "odd", some examples can be fetched
from http://0x.ca/sim/tmp/cr2/ (img_2425.cr2 is a fun one with lots of
nasty colour artifacts from shrink values > 1). :)

Cheers,

Simon-