[TWiki-Dev] [SVN] HideyoImazu r25971 - twiki/trunk/core/lib/TWiki/UI

[<de...@de...>]

Author: HideyoImazu
Date: 2013-05-23 02:17:09 -0500 (Thu, 23 May 2013)
New Revision: 25971
Trac url: http://develop.twiki.org/trac/changeset/25971

Modified:
   twiki/trunk/core/lib/TWiki/UI/View.pm
Log:
Item7263: viewfile needs to quote a file name containg commas in the content-disposition header field

Modified: twiki/trunk/core/lib/TWiki/UI/View.pm
===================================================================
--- twiki/trunk/core/lib/TWiki/UI/View.pm	2013-05-23 06:08:50 UTC (rev 25970)
+++ twiki/trunk/core/lib/TWiki/UI/View.pm	2013-05-23 07:17:09 UTC (rev 25971)
@@ -588,7 +588,7 @@
 
     my $type = _suffixToMimeType( $session, $fileName );
     my $length =  length( $fileContent );
-    $fileName =~ s/,/%2c/g; # Item7263
+    $fileName = qq("$fileName") if ( $fileName !~ /^[-.\w]+$/ ); # Item7263
     my $dispo = 'inline;filename='.$fileName;
 
     $session->{response}->header(-type => $type, qq(Content-Disposition="$dispo") );