[Squirrel-sql-commits] sql12/plugins/oracle/src/net/sourceforge/squirrel_sql/plugins/oracle/tab Or
A Java SQL client for any JDBC compliant database
Brought to you by:
colbell,
gerdwagner
From: Rob M. <man...@us...> - 2008-11-29 15:02:28
|
Update of /cvsroot/squirrel-sql/sql12/plugins/oracle/src/net/sourceforge/squirrel_sql/plugins/oracle/tab In directory fdv4jf1.ch3.sourceforge.com:/tmp/cvs-serv5675/plugins/oracle/src/net/sourceforge/squirrel_sql/plugins/oracle/tab Modified Files: OracleSourceTab.java Log Message: close ResultSet in all cases when finished with it. Index: OracleSourceTab.java =================================================================== RCS file: /cvsroot/squirrel-sql/sql12/plugins/oracle/src/net/sourceforge/squirrel_sql/plugins/oracle/tab/OracleSourceTab.java,v retrieving revision 1.4 retrieving revision 1.5 diff -C2 -d -r1.4 -r1.5 *** OracleSourceTab.java 9 Jun 2007 12:56:14 -0000 1.4 --- OracleSourceTab.java 29 Nov 2008 15:02:25 -0000 1.5 *************** *** 37,40 **** --- 37,41 ---- import net.sourceforge.squirrel_sql.fw.sql.ISQLDatabaseMetaData; import net.sourceforge.squirrel_sql.fw.sql.ITableInfo; + import net.sourceforge.squirrel_sql.fw.sql.SQLUtilities; import net.sourceforge.squirrel_sql.fw.util.log.ILogger; import net.sourceforge.squirrel_sql.fw.util.log.LoggerController; *************** *** 91,97 **** _ta.setText(""); _ta.setWrapStyleWord(true); try { ! ResultSet rs = stmt.executeQuery(); StringBuffer buf = new StringBuffer(4096); while (rs.next()) --- 92,99 ---- _ta.setText(""); _ta.setWrapStyleWord(true); + ResultSet rs = null; try { ! rs = stmt.executeQuery(); StringBuffer buf = new StringBuffer(4096); while (rs.next()) *************** *** 139,142 **** --- 141,146 ---- s_log.error("Unexpected exception: "+ex.getMessage(), ex); session.showErrorMessage(ex); + } finally { + SQLUtilities.closeResultSet(rs); } |