[Squirrel-sql-commits] sql12/plugins/mssql/src/net/sourceforge/squirrel_sql/plugins/mssql/util Mss
A Java SQL client for any JDBC compliant database
Brought to you by:
colbell,
gerdwagner
From: Rob M. <man...@us...> - 2007-08-11 17:21:52
|
Update of /cvsroot/squirrel-sql/sql12/plugins/mssql/src/net/sourceforge/squirrel_sql/plugins/mssql/util In directory sc8-pr-cvs8.sourceforge.net:/tmp/cvs-serv29260/plugins/mssql/src/net/sourceforge/squirrel_sql/plugins/mssql/util Modified Files: MssqlIntrospector.java Log Message: Use valueOf instead of object constructors. Findbugs says it's more efficient. Some generic collection changes. Index: MssqlIntrospector.java =================================================================== RCS file: /cvsroot/squirrel-sql/sql12/plugins/mssql/src/net/sourceforge/squirrel_sql/plugins/mssql/util/MssqlIntrospector.java,v retrieving revision 1.6 retrieving revision 1.7 diff -C2 -d -r1.6 -r1.7 *** MssqlIntrospector.java 31 Jul 2007 01:04:18 -0000 1.6 --- MssqlIntrospector.java 11 Aug 2007 17:21:50 -0000 1.7 *************** *** 507,511 **** } ! protected static String generateCreateTableScript(IDatabaseObjectInfo oi, ISQLConnection conn, boolean withConstraints) throws java.sql.SQLException { Connection c = conn.getConnection(); --- 507,515 ---- } ! protected static String generateCreateTableScript(IDatabaseObjectInfo oi, ! ISQLConnection conn, ! boolean withConstraints) ! throws java.sql.SQLException ! { Connection c = conn.getConnection(); *************** *** 554,558 **** if (colType.equals("char") || colType.equals("varchar")) { buf.append("("); ! buf.append(new Integer(rs.getInt(4)).toString()); // length buf.append(") COLLATE "); buf.append(rs.getString(10)); // collation --- 558,562 ---- if (colType.equals("char") || colType.equals("varchar")) { buf.append("("); ! buf.append(rs.getInt(4)); // length buf.append(") COLLATE "); buf.append(rs.getString(10)); // collation |