[Squirrel-sql-commits] sql12/fw/src/net/sourceforge/squirrel_sql/fw/dialects SybaseDialect.java, 1.2, 1.3 Oracle9iDialect.java, 1.2, 1.3 PointbaseDialect.java, 1.2, 1.3

[Rob M. <man...@us...>]

Update of /cvsroot/squirrel-sql/sql12/fw/src/net/sourceforge/squirrel_sql/fw/dialects
In directory sc8-pr-cvs8.sourceforge.net:/tmp/cvs-serv22570/fw/src/net/sourceforge/squirrel_sql/fw/dialects

Modified Files:
	SybaseDialect.java Oracle9iDialect.java PointbaseDialect.java 
Log Message:
Updates to fix issues found with automated testing.

Index: PointbaseDialect.java
===================================================================
RCS file: /cvsroot/squirrel-sql/sql12/fw/src/net/sourceforge/squirrel_sql/fw/dialects/PointbaseDialect.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -d -r1.2 -r1.3
*** PointbaseDialect.java	22 Oct 2006 09:50:38 -0000	1.2
--- PointbaseDialect.java	30 Oct 2006 11:03:51 -0000	1.3
***************
*** 178,182 ****
       */
      public String[] getColumnAddSQL(String tableName, TableColumnInfo info) throws UnsupportedOperationException {
!         throw new UnsupportedOperationException("This database dialect doesn't support adding columns to tables");
      }
  
--- 178,184 ----
       */
      public String[] getColumnAddSQL(String tableName, TableColumnInfo info) throws UnsupportedOperationException {
!         return new String[] {
!             DialectUtils.getColumnAddSQL(tableName, info, this, true, false)
!         };
      }
  
***************
*** 213,217 ****
       */
      public boolean supportsDropColumn() {
-         // TODO: need to verify this
          return true;
      }
--- 215,218 ----
***************
*** 227,232 ****
       *         dropping columns. 
       */
!     public String getColumnDropSQL(String tableName, String columnName) {
!         // TODO: Need to verify this        
          return DialectUtils.getColumnDropSQL(tableName, columnName);
      }
--- 228,232 ----
       *         dropping columns. 
       */
!     public String getColumnDropSQL(String tableName, String columnName) {   
          return DialectUtils.getColumnDropSQL(tableName, columnName);
      }

Index: SybaseDialect.java
===================================================================
RCS file: /cvsroot/squirrel-sql/sql12/fw/src/net/sourceforge/squirrel_sql/fw/dialects/SybaseDialect.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -d -r1.2 -r1.3
*** SybaseDialect.java	22 Oct 2006 09:50:37 -0000	1.2
--- SybaseDialect.java	30 Oct 2006 11:03:51 -0000	1.3
***************
*** 210,214 ****
       */
      public boolean supportsDropColumn() {
-         // TODO: need to verify this
          return true;
      }
--- 210,213 ----
***************
*** 225,229 ****
       */
      public String getColumnDropSQL(String tableName, String columnName) {
-         // TODO: Need to verify this        
          return DialectUtils.getColumnDropSQL(tableName, columnName);
      }
--- 224,227 ----
***************
*** 242,247 ****
       */
      public String getTableDropSQL(String tableName, boolean cascadeConstraints){
!         // TODO: Need to verify this
!         return DialectUtils.getTableDropSQL(tableName, true, cascadeConstraints);
      }
      
--- 240,244 ----
       */
      public String getTableDropSQL(String tableName, boolean cascadeConstraints){
!         return DialectUtils.getTableDropSQL(tableName, false, cascadeConstraints);
      }
      

Index: Oracle9iDialect.java
===================================================================
RCS file: /cvsroot/squirrel-sql/sql12/fw/src/net/sourceforge/squirrel_sql/fw/dialects/Oracle9iDialect.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -d -r1.2 -r1.3
*** Oracle9iDialect.java	22 Oct 2006 09:50:39 -0000	1.2
--- Oracle9iDialect.java	30 Oct 2006 11:03:51 -0000	1.3
***************
*** 239,244 ****
       */
      public String getColumnDropSQL(String tableName, String columnName) {
!         // TODO: Need to verify this        
!         return DialectUtils.getColumnDropSQL(tableName, columnName);
      }
      
--- 239,248 ----
       */
      public String getColumnDropSQL(String tableName, String columnName) {
!         StringBuffer result = new StringBuffer();
!         result.append("ALTER TABLE ");
!         result.append(tableName);
!         result.append(" DROP COLUMN ");
!         result.append(columnName);
!         return result.toString();
      }
      
***************
*** 256,261 ****
       */
      public String getTableDropSQL(String tableName, boolean cascadeConstraints){
!         // TODO: Need to verify this
!         return DialectUtils.getTableDropSQL(tableName, true, cascadeConstraints);
      }
      
--- 260,271 ----
       */
      public String getTableDropSQL(String tableName, boolean cascadeConstraints){
!         StringBuffer result = new StringBuffer();
!         result.append("DROP TABLE ");
!         result.append(tableName);
!         
!         if (cascadeConstraints) {
!             result.append(" CASCADE CONSTRAINTS");
!         }
!         return result.toString();
      }