[Sipp-users] Re: Improperly terminated messages

[F. T. R. <tar...@ci...>]

> Hello,
> 
> I recently downloaded the 2004-06-28 snapshot to use the new -inf 
> feature but are running into problems.
> 
> It seems some changes went in to how CRLF is handled while sending 
> packets, and SIP messages that do not contain a body are not being 
> properly terminated any more.
> 
> As an example, the trace files 'olduac' and 'olduas' are from 0.4rc1 
> and the new ones are from 2004-06-28 build.  Notice that the ACK and 
> BYE messages from uac side are terminated differently and our server 
> is rejecting them as incomplete messages.
> 
> Thanks


A little bit of diff merging led me to this code that seems to be the problem.
I believe messages with no body should have a double CRLF at the end.

In call.cpp:  call::createSendingMessage

    // OJA remove all \r, \n but 1 at the end of a message to send 
    // TODO: check if this is OK to do it this way
    
    while ( (dest[strlen(dest)-1] == '\n') &&
            (dest[strlen(dest)-2] == '\r') &&
            (dest[strlen(dest)-3] == '\n') &&
            (dest[strlen(dest)-4] == '\r')) {
      dest[strlen(dest)-2] = 0;
    }