Re: [Ser2net-devel] [PATCH v4] Make signature configurable

[Yegor Y. <yeg...@go...>]

Thanks for reviewing and committing. Do you have any plans for the next release?

I have some more ideas for ser2net, but no time for now. So I'll
return later to implement them.

Have you tested ser2net with Python or Java RFC2217 libraries? As I
wrote in another thread I failed to connect via pyserial.

Yegor

On Wed, Jul 24, 2013 at 6:08 PM, Corey Minyard <cmi...@mv...> wrote:
> Sorry, got lost in the busy-ness.  It's committed now.  I made a few small
> changes, mostly to move the rfc2217_signature extern into an include file
> and to just assign it's value statically.  Thanks for this patch.
>
> -corey
>
>
> On 07/24/2013 01:02 AM, Yegor Yefremov wrote:
>>
>> Hi Corey,
>>
>> On Thu, Jul 11, 2013 at 10:14 AM,  <yeg...@go...> wrote:
>>>
>>> From: Yegor Yefremov <yeg...@go...>
>>>
>>> Add '-s' option to configure default signature, that can be
>>> requested via RFC2217 protocol (option 0).
>>>
>>> Add per port signature via SIGNATURE keyword.
>>>
>>> Cc: Corey Minyard <cmi...@mv...>
>>> Signed-off-by: Yegor Yefremov <yeg...@go...>
>>> ---
>>> Changes since v3: check signature size and document the new feature
>>> Changes since v2: make per port signature
>>> Changes since v1: replace 'controlport' with 'signature' in a comment
>>
>> is the patch ready for commit now?
>>
>> Yegor
>
>