Menu
▾
▴
[sdcc-devel] [ sdcc-Patches-2841820 ] Fix the broken support for --program-[pre][suf]fix
|
From: SourceForge.net <no...@so...> - 2009-08-21 12:15:49
|
Patches item #2841820, was opened at 2009-08-21 12:10 Message generated for change (Comment added) made by hjourdain You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300599&aid=2841820&group_id=599 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: hjourdain (hjourdain) Assigned to: Nobody/Anonymous (nobody) Summary: Fix the broken support for --program-[pre][suf]fix Initial Comment: This patch enables the use of --program-prefix, --program-suffix, and --program-transform-name. It was tested with a simple test program. It currently seems to have problems with pic, pic16 and z80 ports, but seems to be working with the others. I initially developed it for mcs51, and extended it to the other ports. I intend to check the issues with pic and z80 ports later, if needed. This patch is relative to the snapshot 20090817-5492. I did the modifications only for systems using makefile.in stuff, for Windows projects there is more work to do - feasible, though, I guess. To use this patch, once applied, I have to do: configure (with the processors you want) (using --program-prefix also, if needed) OPT_DISABLE_DEVICE_LIB=1 make make install make sdcc-device-lib make install If no program [pre][suf]fix is configured, then it should work like previously. ---------------------------------------------------------------------- Comment By: hjourdain (hjourdain) Date: 2009-08-21 14:15 Message: >From your explanation, I now understand that these changes are not quite well suited to the pic/pic16 targets, because they try to modify the name of the asm and link. If I understand well, these are external for pic/pic16, which I just didn't know... Sorry for that, but I never used pic/pic16 before, and as I told, I extended from mcs51... For z80, I have a problem with the "command line" part it seems... I didn't have time enough yet to solve it, as I'm going on holiday. I should be able to give it another shot in 2 weeks, if that's necessary. Or anyone else should be able to correct this, as I have a feeling it's just a small thing. Please advise me for the next steps you want me to take, if any. And yes, I totally agree with you about removing the hunks in src/pic* Herve ---------------------------------------------------------------------- Comment By: Raphael Neider (tecodev) Date: 2009-08-21 13:07 Message: Could you please elaborate on the problems with pic/pic16/z80 targets? Looking at the patch, I see that you apply the program-transformation to the assemblers and linkers to use as well. Though this seems to be reasonable for the sdcc-supplied tools (asx8051, aslink, as-z80, link-z80, as-gbz80, link-gbz80, as-hc08, link-hc08), that are also affected by the --program-transform= argument, that approach must fail for the pic/pic16 targets that use externally supplied assemblers and linkers (gputils' gpasm and gplink), whose names are not subject to sdcc's transformation. If required, one can use the --asm="" and --link="" options to override the names of the tools -- at least for the pic16 target. Unless I overlooked something, I'd recommend removing the hunks in src/pic and src/pic16 before accepting this patch. The rest looks fine to me, though I did not test it. Thank you for the contribution. Raphael ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300599&aid=2841820&group_id=599 |