[sdcc-devel] [ sdcc-Bugs-1967300 ] Peephole optimizer can't handle nested parenthesis

[SourceForge.net <no...@so...>]

Bugs item #1967300, was opened at 2008-05-19 20:06
Message generated for change (Comment added) made by maartenbrock
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100599&aid=1967300&group_id=599

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: peephole optimizer
>Group: fixed
Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Philipp Krause (spth)
Assigned to: Philipp Krause (spth)
Summary: Peephole optimizer can't handle nested parenthesis

Initial Comment:
The peephole optimizer can't handle nested parenthesis in function conditions. Example:

replace {
do %1
} by {
} if OperandsNotSame(%1 '(x)')

which should remove lines like
do this
do that
do (whatever)
but not
do (x)
won't work.

This bug has to be fixed so bug #1924707 can be fixed. The fix to #1924707 need '(de)' and '(bc)' as arguments to functions in the peephole optimizer.

The problem is in callFuncByName in SDCCpeeph.c: It assumes the arguments of a function are between the line's first ( and the first ) after that. We should allow nested () in between.

Philipp


----------------------------------------------------------------------

>Comment By: Maarten Brock (maartenbrock)
Date: 2008-05-19 22:18

Message:
Logged In: YES 
user_id=888171
Originator: NO

Please remember to also set the Group and Resolution when closing a bug
report.

----------------------------------------------------------------------

Comment By: Philipp Krause (spth)
Date: 2008-05-19 21:58

Message:
Logged In: YES 
user_id=564030
Originator: YES

Fixed in #5163.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100599&aid=1967300&group_id=599