[sdcc-devel] [ sdcc-Bugs-1804059 ] Missing "--" option in linker

[SourceForge.net <no...@so...>]

Bugs item #1804059, was opened at 2007-09-28 11:06
Message generated for change (Comment added) made by ttensi
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100599&aid=1804059&group_id=599

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: linker
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Thomas Tensi (ttensi)
Assigned to: Maarten Brock (maartenbrock)
Summary: Missing "--" option in linker

Initial Comment:
Dear all,


when checking the 2.7.0 version of the Z80/GBZ80 linker, I
found out that the "--" option has been removed from the
code, but not from the usage description. As far as I can
tell it also should occur in the other ports.

That option tells that the linker options have to be taken
from the command-line.  Without it the options either come
from stdin or from a link file.

Is this change intentional?  I know that this option does
not occur in the official linker documentation, but I assume
that some people use command-line linker options.

The code change happened to lk_getline() in lklex.c.  To
allow the command-line parameters the section

--BEGIN--
		fprintf(stdout, "ASlink >> ");

	if (sfp == NULL || fgets(ib, sizeof ib, sfp) == NULL) {
--END--

has to be changed to

--BEGIN--
		fprintf(stdout, "ASlink >> ");

#ifdef SDK
	if(cfp == NULL && filep != NULL && filep->f_type == F_CMD) {
		char **argv = (char **)filep->f_idp;
		if(argv[0] != NULL && strlen(argv[0]) < sizeof ib) {
			strcpy(ib, argv[0]);
			filep->f_idp = (char *)&argv[1];			
		} else {
			filep = NULL;
			return(0);
		}
	} else
#endif /* SDK */

	if (sfp == NULL || fgets(ib, sizeof ib, sfp) == NULL) {
--END--

or something consistent to the new routine design.

Otherwise the option should be removed from the usage help
and also not parsed in the main() routine.

Best regards,

Thomas

----------------------------------------------------------------------

>Comment By: Thomas Tensi (ttensi)
Date: 2007-10-22 16:29

Message:
Logged In: YES 
user_id=1141413
Originator: YES

Hi Maarten,


you can remove it for the sake of consistency.  I
can do fine with link files containing the
options.  But the mentioning in the usage info
and its parsing should be kicked out.


      Best regards

             Thomas

----------------------------------------------------------------------

Comment By: Thomas Tensi (ttensi)
Date: 2007-10-22 16:28

Message:
Logged In: YES 
user_id=1141413
Originator: YES

Hi Maarten,


you can remove it for the sake of consistency.  I
can do fine with link files containing the
options.  But the mentioning in the usage info
and its parsing should be kicked out.


      Best regards

             Thomas

----------------------------------------------------------------------

Comment By: Maarten Brock (maartenbrock)
Date: 2007-10-21 20:54

Message:
Logged In: YES 
user_id=888171
Originator: NO

Thomas,

If I would put it back in, would you actually use it?

Maarten

----------------------------------------------------------------------

Comment By: Thomas Tensi (ttensi)
Date: 2007-10-02 15:25

Message:
Logged In: YES 
user_id=1141413
Originator: YES

Hi Maarten,


thanks for the clarification!  I am fine with removing
the '--' option to be consistent with the other ports,
but then it should be removed from the usage info and
also not getting parsed in the main() routine.


            Best regards

                    Thomas



----------------------------------------------------------------------

Comment By: Maarten Brock (maartenbrock)
Date: 2007-09-29 11:28

Message:
Logged In: YES 
user_id=888171
Originator: NO

The other ports don't have the -- option. And it was also conditionally
compiled only with SDK defined which noone can explain to me what it is or
what it's for. So in order to merge all those linker files to reduce the
version hell I just removed it.

I'll see if I can put it back, but the #ifdef SDK will not return with it.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100599&aid=1804059&group_id=599