[sdcc-devel] [ sdcc-Bugs-1436552 ] --link option not obeyed and wrong linker script

[SourceForge.net <no...@so...>]

Bugs item #1436552, was opened at 2006-02-22 10:23
Message generated for change (Comment added) made by tecodev
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100599&aid=1436552&group_id=599

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: pic16 target
>Group: fixed
>Status: Closed
>Resolution: Accepted
Priority: 2
Submitted By: riedel (riedel_teco)
>Assigned to: Raphael Neider (tecodev)
Summary:  --link option not obeyed and wrong linker script

Initial Comment:
The following patch obeys the --link option and  
triggers the linker to chose the correct linker  
script if no .c-file is given.   
  
Index: src/pic16/main.c   
===================================================================   
RCS file: /cvsroot/sdcc/sdcc/src/pic16/main.c,v   
retrieving revision 1.65   
diff -u -r1.65 main.c   
--- src/pic16/main.c    3 Sep 2005 10:35:46 -0000         
1.65   
+++ src/pic16/main.c    22 Feb 2006 10:16:16 -0000   
@@ -639,6 +639,11 @@   
 char *msprintf(hTab *pvals, const char   
*pformat, ...);   
 int my_system(const char *cmd);   
   
+/* forward declarations */   
+extern const char *pic16_linkCmd[];   
+extern const char *pic16_asmCmd[];   
+extern set *asmOptionsSet;   
+   
 /* custom function to link objects */   
 static void _pic16_linkEdit(void)   
 {   
@@ -655,9 +660,9 @@   
         *   
         */   
   
-       sprintf(lfrm, "{linker} {incdirs} {lflags} -o   
{outfile} {user_ofile} {spec_ofiles} {ofiles}   
{libs}");   
+       sprintf(lfrm, "{linker} {incdirs} {lflags} -o   
{outfile} {user_ofile} {ofiles} {spec_ofiles}   
{libs}");   
   
-       shash_add(&linkValues, "linker", "gplink");   
+       shash_add(&linkValues, "linker",   
pic16_linkCmd[0]);   
   
        mergeSets(&tSet, libDirsSet);   
        mergeSets(&tSet, libPathsSet);   
@@ -707,10 +712,6 @@   
 }   
   
   
-/* forward declarations */   
-extern const char *pic16_linkCmd[];   
-extern const char *pic16_asmCmd[];   
-extern set *asmOptionsSet;   
   
 static void   
 _pic16_finaliseOptions (void)   
   

----------------------------------------------------------------------

>Comment By: Raphael Neider (tecodev)
Date: 2006-03-02 16:34

Message:
Logged In: YES 
user_id=1115835

Accepted in src/pic16/main.c 1.66, SDCC #1214.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100599&aid=1436552&group_id=599