From: SourceForge.net <no...@so...> - 2005-11-28 22:54:15
|
Patches item #1368001, was opened at 2005-11-28 08:46 Message generated for change (Settings changed) made by frief You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300599&aid=1368001&group_id=599 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed Resolution: Accepted Priority: 5 Submitted By: Weston T. Schmidt (schmidtw) Assigned to: Nobody/Anonymous (nobody) Summary: at89c51snd1c.h Header File For Inclusion Initial Comment: I wrote this file based on the documentation for this chip & examples of other people's files. I am currently using this for a project with this chip and SDCC. Please include this with SDCC if it is acceptable. Thanks, Weston Schmidt ---------------------------------------------------------------------- Comment By: Frieder Ferlemann (frief) Date: 2005-11-28 23:53 Message: Logged In: YES user_id=589052 Hi Wes, your file is included in SDCC 2.5.4 1177 without the line: __sfr __at (0xE0) A Please report back if that should cause any problems. ---------------------------------------------------------------------- Comment By: Weston T. Schmidt (schmidtw) Date: 2005-11-28 22:41 Message: Logged In: YES user_id=767003 Hi Frieder, I am not clear on the correct answer to your question. Uppon research into the 8051 instruction set, I found the following: PUSH direct where direct is the direct 8 bit memory address. Here is the document I looked at: http://www.atmel.com/dyn/resources/prod_documents/doc0509.pdf If you wish to remove that line & add it, go ahead. I'll get the latest & compile my project in an effort to ensure the definition is not needed. Thanks, Wes ---------------------------------------------------------------------- Comment By: Frieder Ferlemann (frief) Date: 2005-11-28 09:25 Message: Logged In: YES user_id=589052 Hi Weston, looks fine. One remark, the header defines __sfr __at (0xE0) ACC ; as well as: __sfr __at (0xE0) A Unless I'm missing something I think the later one can be dropped? The other at89*.h files also define it both ways but this pretends instructions the 8051 does not support (like: push A) Greetings, Frieder ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300599&aid=1368001&group_id=599 |