From: SourceForge.net <no...@so...> - 2005-11-19 17:05:28
|
Patches item #1144962, was opened at 2005-02-20 20:21 Message generated for change (Comment added) made by hsack You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300599&aid=1144962&group_id=599 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: None Priority: 5 Submitted By: Frieder Ferlemann (frief) Assigned to: Nobody/Anonymous (nobody) Summary: peepholes with labelRefCount for the mcs51 port Initial Comment: I'd like to post this peephole here in the hope it gets some testing prior to inclusion into SDCC. The appended peephole file keeps track of the changes in the reference counters for the labels. It makes use of the new peephole keyword labelRefCountChange (SDCC 2.4.8 >961). SDCC can thus f.e. remove an unneeded ret in the following code: void u( unsigned char c); void v( unsigned char c); void t( unsigned char c) { if( c ==35 ) u(65); else v(8); } ---------------------------------------------------------------------- Comment By: Hubert Sack (hsack) Date: 2005-11-19 18:05 Message: Logged In: YES user_id=1160854 within the hole "PEEPH.DEF" file every conditional call to "labelRefCountChange" is "if" missing! The peephole is applied but the function is not called. It must be "} if labelRefCountChange(%1 -1)". I think this syntax should produce an error message ---------------------------------------------------------------------- Comment By: Frieder Ferlemann (frief) Date: 2005-11-07 22:32 Message: Logged In: YES user_id=589052 this is in SDCC as of 2005-07-12 (and I should have remembered to close this patch then). Hubert, if I missed something, please resubmit. ---------------------------------------------------------------------- Comment By: Frieder Ferlemann (frief) Date: 2005-03-30 22:13 Message: Logged In: YES user_id=589052 Appending the patch Hubert sent to me. ---------------------------------------------------------------------- Comment By: Hubert Sack (hsack) Date: 2005-03-29 22:52 Message: Logged In: YES user_id=1160854 I added 2 more Peepholes for more effective code generated by the changes done by me in RFE 11 62 453 ---------------------------------------------------------------------- Comment By: Frieder Ferlemann (frief) Date: 2005-03-21 22:19 Message: Logged In: YES user_id=589052 Thank you for testing. Will commit some time after 2.5.0 is out. ---------------------------------------------------------------------- Comment By: Hubert Sack (hsack) Date: 2005-03-09 11:49 Message: Logged In: YES user_id=1160854 I tested the new peephole file and could not find any errors. But my sourcecode is small and easy, so I think somemore testing with more complex sourcecode is recommended. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300599&aid=1144962&group_id=599 |