[sdcc-devel] [ sdcc-Patches-1246774 ] Oki 80C154S register definition

[SourceForge.net <no...@so...>]

Patches item #1246774, was opened at 2005-07-28 15:30
Message generated for change (Comment added) made by simonsunnyboy
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300599&aid=1246774&group_id=599

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Matthias Arndt (simonsunnyboy)
Assigned to: Nobody/Anonymous (nobody)
Summary: Oki 80C154S register definition

Initial Comment:
Hello,

here is a complete register and chip definition header
file for SDCC for Oki MSM80C154S and MSM83C154S
controllers.
I hope this fits, I tried to follow the SDCC standard
closely. when doing it this morning.

HTH,
Matthias

----------------------------------------------------------------------

>Comment By: Matthias Arndt (simonsunnyboy)
Date: 2005-07-29 08:57

Message:
Logged In: YES 
user_id=584841

Ofcourse do any changes to the file you think to be needed.
Rename, restyle, relicense, whatever needed.

Actually I took a look at the 8052.h file and styled mine in
the same way, e.q. the comment block was simply cut'n'paste
into the editor.
I'm glad to contribute in some way :)

cheers,
Matthias

----------------------------------------------------------------------

Comment By: Erik Petrich (epetrich)
Date: 2005-07-28 23:12

Message:
Logged In: YES 
user_id=635249

I don't think the GPL allows pasting a new license in its
place. Although I agree the LGPL would be better, Matthias
would need to approve this change in licensing terms for it
to be proper.


----------------------------------------------------------------------

Comment By: Maarten Brock (maartenbrock)
Date: 2005-07-28 20:21

Message:
Logged In: YES 
user_id=888171

I will replace the license, convert to double-underscored 
keywords and rename the file to msm8xc154s.h including the 
encapsulating define (REG... becomes MSM8...)

I will also change to bracketed addresses. Is this something 
we want to use more often? I'm all in favor of it as it brings 
something like sfr16 at (0x81, 0x82) a step closer (if only in 
one's mind).

And after all this I will commit to cvs if noone objects.

----------------------------------------------------------------------

Comment By: Frieder Ferlemann (frief)
Date: 2005-07-28 18:44

Message:
Logged In: YES 
user_id=589052

Some minor comments:

- the LGPL instead of GPL licence would be more appropriate
for a library

- definitions with double underscore are considered more
ANSI compliant,
  so it would be f.e.  __sfr __at (0x80) P0;

- the brackets around the address allow to use an empty define
  [like #define __at(x)] to remove MCU specific keywords.
  (helps if you should want to run another compiler over
(part of) 
  your code)

- SDCC uses a flat name space for all mcs51 derivatives. In
the looong
  run this doesn't scale well and might lead to name clashes.
  To avoid this please don't use "8" as first character of 
  the filename, msm8..... or oki8..... would look better to me.

Thanks,
Frieder


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300599&aid=1246774&group_id=599