[sdcc-devel] [ sdcc-Patches-1089163 ] [RFC,PIC16] simplified genCmp

[SourceForge.net <no...@so...>]

Patches item #1089163, was opened at 2004-12-21 18:37
Message generated for change (Comment added) made by vrokas
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300599&aid=1089163&group_id=599

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: ccsporters (tecodev)
>Assigned to: Vangelis Rokas (vrokas)
Summary: [RFC,PIC16] simplified genCmp

Initial Comment:
I developed a new, simpler and easier understandable
version of genCmp(). I did this because I tried to fix
an issue with genCmp with while (a < HIDDEN) in
/device/lib/_ulong2fs.c but could not pinpoint the error...

Furthermore the current version fails to assign the
result of the comparison to the desired result register
(producing wrong code for e.g. device/lib/_divslong.c).

My version aims at readability trying to avoid too many
special cases. I admit that it is in some cases less
efficient than the current version but maybe we could
use the new plan as a starting point for a better version?

Proposal/patch attached.

Regards,
  Raphael Neider

----------------------------------------------------------------------

>Comment By: Vangelis Rokas (vrokas)
Date: 2004-12-22 09:25

Message:
Logged In: YES 
user_id=770505

Does the new version cover all the necessery cases?


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300599&aid=1089163&group_id=599