Re: [sdcc-devel] Variables in code space on 8051

[Johan K. <joh...@id...>]

> +      /* if possible use indexed addressing mode for code data access
with positive byte offset */
> +      if ( (aop->code) && (offset == (offset & 0xff)) )
> +       {
> +         emitcode ("mov", "a,#0x%02x", offset & 0xff);
> +         emitcode ("movc", "a,@a+dptr");
> +         return (dname ? "acc" : "a");
> +       }
> +
>        while (offset > aop->coff)
>         {
>           emitcode ("inc", "dptr");

The generated code looks nicer and does save time although it doesn't save
space . But this doesn't take into account the fact that aop->coff could
already be != 0. Very unlikely and maybe even impossible, but still. I think
this is too dangerous.

Nice catch though! Please go on.

Johan