Re: [rox-devel] Panel height

[Geoff Y. <g...@in...>]

On Fri, Mar 21, 2003 at 11:57:44AM +0000, Thomas Leonard wrote:
> On Thu, Mar 20, 2003 at 07:13:50PM +0000, Geoff Youngs wrote:
> > On Thu, Mar 20, 2003 at 01:48:26PM +0000, Thomas Leonard wrote:
> > > On Sat, Mar 15, 2003 at 04:24:27AM +0100, Alain Schlesser wrote:
> > > > Hi.

> > > > I have a question concerning the panel. I first wanted to post
> > > > to ROX Users, but I think this list is more appropriate.

> > > > I am trying ROX for a few days now and I really like it. But I
> > > > have now already changed the source of three or four apps and
> > > > redrawn some pictures just so that the panel stays at the same
> > > > height. Is there a function to ask the panel for its current
> > > > height? Can you change it through configuration?

> > > No, although I'm still open to a patch...

> > I'm banging my head against a brick wall with work at the moment, so
> > any diversion is welcome :(

> > Try the attached - it allows the maximum icon size to be set
> > arbitrarily via the options box.   The maximum size is the maximum
> > horizontal or vertical dimension for an icon.

> I've had a play... it's rather fun! However, I think it leaves too
> much space around many icons. I'd prefer to set the panel width/height
> directly, and have the icons scale to fill their allocated area. That
> is, applications (with no text underneath) should scale to the full
> height of the panel, whereas directories (with text below) should fill
> whatever area isn't used for the text).
OK - done.

> Likewise, if the panel height is 42, then icons don't have to take up
> the full width of 42, only their actual width.
Oops. Fixed.

> Having an explicitly set panel-height would also mean that applets
> could scale to that, instead of trying to force the panel larger
> (since they can't tell how big you want them at the moment).

The attached won't affect applets - I'm not sure whether it would be
better to set a property (as for panel sides) on the socket as an
advisory for the applet or to prevent the socket from taking more than a
specified area.  

It might be better to allow an applet to specify a minimum size (which
should probably then resize the current icons if bigger than the current
size), but it's an issue which perhaps needs more discussion than simply
limiting the size of standard panel icons.

The patch also includes a minor patch for view_details.c, which is
trivial, but allows the current CVS version to compile with GTK2.0
(which doesn't appear to have a gtk_tree_selection_count_selected_rows()
function).

Again, this patch has been tested with both horzontal and vertical
panels and appears to function correctly with both in all text/icon
combinations and with a variety of different font sizes.

TTFN,


Geoff.