[rox-devel] Options changes

[Thomas L. <ta...@ec...>]

For people making patches with options, note that the system has just
changed slightly (again ;-).

Before, you registered an option with, eg:

	option_add_int("key", default, callback)

The Option structure was dynamically allocated. This isn't all that
useful. The new system is:

	static Option o_key;
	...
	option_add_int(&o_key, "key", default)

You can then get the value using o_key.int_value (or o_key.value for
strings) instead of option_get_int("key"). This is faster and simpler.

The callback has gone too. Turns out that the few places where it was used
were just caching the value to save option_get_int()s later, which is no
longer useful :-)

You should now use just the notify callbacks to do updates. Since there is
no cached 'old' copy to compare with to see if the option has changed,
there is a new flag, option.has_changed which indicates whether the value
is different from the last notify.

Anyway, the code is shorter, neater, faster, and buggier now ;-)


-- 
Thomas Leonard			http://rox.sourceforge.net
ta...@ec...		ta...@us...